From patchwork Wed May 5 20:17:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sergiu Ivanov X-Patchwork-Id: 29142 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9EDAC27BC82; Wed, 5 May 2021 22:54:27 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 22AC827BC81 for ; Wed, 5 May 2021 22:54:27 +0100 (BST) Received: from localhost ([::1]:46058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lePTO-00071G-5q for patchwork@mira.cbaines.net; Wed, 05 May 2021 17:54:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lePT0-0006zK-Lm for guix-patches@gnu.org; Wed, 05 May 2021 17:54:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lePT0-0003YO-EF for guix-patches@gnu.org; Wed, 05 May 2021 17:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lePT0-00052K-DR for guix-patches@gnu.org; Wed, 05 May 2021 17:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48128] [PATCH] Add font-montserrat. Resent-From: Sergiu Ivanov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 May 2021 21:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48128 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Ludovic =?utf-8?q?Court=C3=A8s?= Cc: 48128@debbugs.gnu.org Received: via spool by 48128-submit@debbugs.gnu.org id=B48128.162025161719337 (code B ref 48128); Wed, 05 May 2021 21:54:02 +0000 Received: (at 48128) by debbugs.gnu.org; 5 May 2021 21:53:37 +0000 Received: from localhost ([127.0.0.1]:34721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lePSY-00051p-Rm for submit@debbugs.gnu.org; Wed, 05 May 2021 17:53:37 -0400 Received: from marvid.fr ([163.172.81.107]:43316 helo=courriel.marvid.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leNxc-0003uO-Ez for 48128@debbugs.gnu.org; Wed, 05 May 2021 16:17:34 -0400 Received: from localhost (schwifty.marvid.fr [51.159.4.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sahkopoika (Postfix) with ESMTPSA id E68765261115; Wed, 5 May 2021 22:17:25 +0200 (CEST) References: <87im43wlcl.fsf@colimite.fr> <874kfjyeva.fsf@gnu.org> User-agent: mu4e 1.4.15; emacs 27.2 From: Sergiu Ivanov In-reply-to: <874kfjyeva.fsf@gnu.org> Date: Wed, 05 May 2021 22:17:25 +0200 Message-ID: <87eeelszoq.fsf@colimite.fr> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 05 May 2021 17:53:33 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Ludovic, Thank you for taking the time to answer and giving me the opportunity to learn! Also, sorry for the delay. Thus quoth Ludovic Courtès on Mon May 03 2021 at 18:13 (+0200): > Hi Sergiu, > > Sergiu Ivanov skribis: > >> I retrieve the release zipball from GitHub using a direct url-fetch >> rather than git-fetch, because I've seen both in fonts.scm. If you think >> git-fetch is more appropriate, I'll change the method. > > > [...] > >> + (method url-fetch) >> + (uri (string-append >> + "https://github.com/JulietaUla/Montserrat/archive/refs/tags/v" version ".zip")) > > This is a generated tarball that may change over time, which is why > ‘guix lint’ warns about it. So yes, I think you should use ‘git-fetch’ > instead. I changed that, thank you. > You’ll also have to add a ‘file-name’ field to the origin, as ‘guix > lint’ suggests. Indeed, I added that field. > There are also a couple of ‘guix lint’ warnings that I’ll let you > check. :-) I left closing parens on a separate line :O :O :O I remember thinking how guix lint was wonderful when I read the Guix Manual, and now I forgot to run it :D >> + (synopsis "The Montserat font") > ^ > Missing ‘r’. Fixed, thank you. > Could you send an updated patch? I attach the update. - Sergiu From fcec43e6a60081c2041f5827f22bcccec3c17bfd Mon Sep 17 00:00:00 2001 From: Sergiu Ivanov Date: Fri, 30 Apr 2021 22:20:16 +0200 Subject: [PATCH] Add font-montserrat. --- gnu/packages/fonts.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm index b78c46b0f8..8c9b4b68ce 100644 --- a/gnu/packages/fonts.scm +++ b/gnu/packages/fonts.scm @@ -39,6 +39,7 @@ ;;; Copyright © 2020 Tim Van den Langenbergh ;;; Copyright © 2020 Nicolò Balzarotti ;;; Copyright © 2021 Antoine Côté +;;; Copyright © 2021 Sergiu Ivanov ;;; ;;; This file is part of GNU Guix. ;;; @@ -2156,3 +2157,25 @@ suitable for a wide range of uses.") (description "Cozette is a 6x13px (bounding box) bitmap font based on Dina and heavily inspired by Creep.") (license license:expat))) + +(define-public font-montserrat + (package + (name "font-montserrat") + (version "7.210") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/JulietaUla/Montserrat") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0jn1yvfamq5xazw85sfnxgriji60g7mkss9mkf8d0117vdk838bn")))) + (build-system font-build-system) + (home-page "https://github.com/JulietaUla/Montserrat") + (synopsis "The Montserrat font") + (description "The old posters and signs in the traditional Montserrat +neighborhood of Buenos Aires inspired Julieta Ulanovsky to design this +typeface and rescue the beauty of urban typography that emerged in the first +half of the twentieth century.") + (license license:silofl1.1))) -- 2.31.1