From patchwork Sun Jun 26 19:09:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Christine Lemmer-Webber X-Patchwork-Id: 40337 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 7313227BBEA; Sun, 26 Jun 2022 20:13:18 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id F2EE027BBE9 for ; Sun, 26 Jun 2022 20:13:17 +0100 (BST) Received: from localhost ([::1]:48248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5Xh7-00062x-3n for patchwork@mira.cbaines.net; Sun, 26 Jun 2022 15:13:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5Xgs-0005yN-RJ for guix-patches@gnu.org; Sun, 26 Jun 2022 15:13:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5Xgs-0001nj-Iy for guix-patches@gnu.org; Sun, 26 Jun 2022 15:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5Xgs-0004yf-Au for guix-patches@gnu.org; Sun, 26 Jun 2022 15:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56204] Add guile-goblins Resent-From: Christine Lemmer-Webber Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Jun 2022 19:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?utf-8?q?Court=C3=A8s?= Cc: 56204@debbugs.gnu.org, Maxime Devos Received: via spool by 56204-submit@debbugs.gnu.org id=B56204.165627075719099 (code B ref 56204); Sun, 26 Jun 2022 19:13:02 +0000 Received: (at 56204) by debbugs.gnu.org; 26 Jun 2022 19:12:37 +0000 Received: from localhost ([127.0.0.1]:49035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5XgO-0004xv-Ox for submit@debbugs.gnu.org; Sun, 26 Jun 2022 15:12:37 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5XgK-0004xg-Kl for 56204@debbugs.gnu.org; Sun, 26 Jun 2022 15:12:31 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9631D5C004D; Sun, 26 Jun 2022 15:12:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 26 Jun 2022 15:12:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dustycloud.org; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656270743; x= 1656357143; bh=wRdis3pwS1qutYiXOrNDJuXlN0pE2M/KJvJVlrciiM4=; b=I kqHK/8fS9/73faAhkhS4WIt+615tZ64kJRgvOoPVFtbTx+5Mf1jf83GHWgqRvAi2 kacCSDWL1ZHjtGl3wrBCmPkfZ3o1CxZLA0iUF063ReVcVYB5HY0XY6nAo65jxfvy iIJz+vg1DCWGzQIdf7qVDFUZkfxHHlxgw7Tr+o7XPiGFaEEHLKIAoRaueh1DGo6e x21dWJaF+CAB0OxKQJY3sKYJ3yMbNK/4mpaS7Wpr4QV93NpON4ogQXr+NYeRoLrz glUQEQd1/Y8RV47hjcwmWQTMAtMyDhs8nUX6JznY4ubjDx6Ew+v8zXqNAbbb98wR xlmbsh4dllyV7dFmAHpyw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656270743; x= 1656357143; bh=wRdis3pwS1qutYiXOrNDJuXlN0pE2M/KJvJVlrciiM4=; b=f YDMXuqV60SWoSnFhs/tGkhQ9VaHxjqMb1tFi/85uttskdtQyz40IO1AJvxcqiCXJ 2g3IkToDWue9oaR2DlQ2/cB9FFuP+kbnFDwq+h+HvHzZYKtkg9AmdQbB1lgsDJzG FWKKF76f6PVMFHksApGTNDpu1x2gW8QaSwGctx3HyB2/pmDaK9Jq3+uExszoQdCm hxH9v9Z3L3A/HU6PSGbY+IkMxkMJhyVIKClvbzj0kmBNTlbF6Dtl9A1r3WMgvF/O zeRSSnjQ9KrfJ7cMI9fl6NlW70Gje49658hyEpfRK4Y28QsMR161/1F7fuB/qLGf 5jNYMCbUnlHnMzxzsMV4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudegfedgudefiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepvehh rhhishhtihhnvgcunfgvmhhmvghrqdghvggssggvrhcuoegtfigvsggsvghrseguuhhsth ihtghlohhuugdrohhrgheqnecuggftrfgrthhtvghrnhepleeukeduleefueduuedvjeeu hfeufeeuveetkeejvdfgvdefjeefffdvtdetfeehnecuffhomhgrihhnpehgihhtlhgrsg drtghomhdpmhgrkhgvfhhilhgvrdgrmhenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpegtfigvsggsvghrseguuhhsthihtghlohhuugdrohhrgh X-ME-Proxy: Feedback-ID: i006446df:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Jun 2022 15:12:23 -0400 (EDT) References: <87sfntlpns.fsf@dustycloud.org> <4e2b670f22b19164f7307a3a6579f84d96368dbf.camel@telenet.be> <87zgi0s9f8.fsf_-_@gnu.org> User-agent: mu4e 1.6.11; emacs 28.1 From: Christine Lemmer-Webber Date: Sun, 26 Jun 2022 15:09:42 -0400 In-reply-to: <87zgi0s9f8.fsf_-_@gnu.org> Message-ID: <87edzbjl2h.fsf@dustycloud.org> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Ludovic Courtès writes: > Maxime Devos skribis: > >> Christine Lemmer-Webber schreef op vr 24-06-2022 om 17:24 [-0400]: >>> +    (version "0.8") >>> +    (source >>> +     (origin >>> +       (method git-fetch) >>> +       (uri (git-reference >>> +             (url "https://gitlab.com/spritely/guile-goblins/") >>> +             (commit (string-append "v" version)))) >>> +       (file-name (string-append name "-" version)) >>> +       (sha256 >>> +        (base32 >>> +         "1mmyykh79jwhrfgnhhw94aw7a8m6qw249kj7k60ynj16mcfm5iyy")))) >> >> >> I'm not seeing "--target" in the invocation of "$(GUILE_TOOLS) >> compile", so I don't think that currently it will cross-compile >> correctly. Could you add a --target=... in the Makefile.am? > > That can come upstream in the next version of Goblins IMO. > > Ludo’. Cool, I added it to commit 6664daa27e9b3eb3220ba83d9c874b730e792f90 in guile-goblins. However I was just mimicing guile-gcrypt, so I'm not sure if it's right: #+BEGIN_SRC diff #+END_SRC Should that be sufficient? Notably, the Makefile.am here was bootstrapped using guile-hall, so my suspicion is that this is an update that should be made in guile-hall's templates also, then everyone can benefit. The next release of Goblins should be due out very quickly, I think, so we'll be able to take advantage of it then. diff --git a/Makefile.am b/Makefile.am index b8d4944..b056337 100644 --- a/Makefile.am +++ b/Makefile.am @@ -32,7 +32,7 @@ EXTRA_DIST = $(SOURCES) $(NOCOMP_SOURCES) GUILE_WARNINGS = -Wunbound-variable -Warity-mismatch -Wformat SUFFIXES = .scm .go .scm.go: - $(AM_V_GEN)$(top_builddir)/pre-inst-env $(GUILE_TOOLS) compile $(GUILE_WARNINGS) -o "$@" "$<" + $(AM_V_GEN)$(top_builddir)/pre-inst-env $(GUILE_TOOLS) compile $(GUILE_TARGET) $(GUILE_WARNINGS) -o "$@" "$<" SOURCES = goblins.scm \ goblins/ocapn/crypto-stubs.scm \