[bug#77637] services: qemu-binfmt: Add requirement.

Message ID 87e9e7c726228a47f55d000af1c4c1f5523fcf5c.1744114231.git.nigko.yerden@gmail.com
State New
Headers
Series [bug#77637] services: qemu-binfmt: Add requirement. |

Commit Message

Nigko Yerden April 8, 2025, 12:10 p.m. UTC
  * gnu/services/virtualization.scm (qemu-binfmt-shepherd-services)
[requirement]: Add file-system-/gnu/store.

qemu-binfmt service write references to the store to
/proc/sys/fs/binfmt_misc/qemu-[architecture] files, therefore
/gnu/store needs to be mounted during the lifetime of the service
instance. If /gnu/store does not remain mounted, the issues
discussed by nigko and Rutherther on IRC are arisen:

https://logs.guix.gnu.org/guix/2025-04-05.log
https://logs.guix.gnu.org/guix/2025-04-08.log

Change-Id: I7e7a42a5ba0e39aa58c997739898f3457dd793a9
---
 gnu/services/virtualization.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


base-commit: c9524b5841a057b5e64abf0dca75261e741949c5
  

Comments

Ludovic Courtès April 8, 2025, 3:03 p.m. UTC | #1
Nigko Yerden <nigko.yerden@gmail.com> skribis:

> * gnu/services/virtualization.scm (qemu-binfmt-shepherd-services)
> [requirement]: Add file-system-/gnu/store.
>
> qemu-binfmt service write references to the store to
> /proc/sys/fs/binfmt_misc/qemu-[architecture] files, therefore
> /gnu/store needs to be mounted during the lifetime of the service
> instance. If /gnu/store does not remain mounted, the issues
> discussed by nigko and Rutherther on IRC are arisen:
>
> https://logs.guix.gnu.org/guix/2025-04-05.log
> https://logs.guix.gnu.org/guix/2025-04-08.log
>
> Change-Id: I7e7a42a5ba0e39aa58c997739898f3457dd793a9

Applied, thanks!
  

Patch

diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm
index 45f3876675..0836fe7d45 100644
--- a/gnu/services/virtualization.scm
+++ b/gnu/services/virtualization.scm
@@ -8,6 +8,7 @@ 
 ;;; Copyright © 2023 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2024 Raven Hallsby <karl@hallsby.com>
 ;;; Copyright © 2025 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2025 Nigko Yerden <nigko.yerden@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -999,7 +1000,8 @@  (define qemu-binfmt-shepherd-services
      (list (shepherd-service
             (provision '(qemu-binfmt))
             (documentation "Install binfmt_misc handlers for QEMU.")
-            (requirement '(file-system-/proc/sys/fs/binfmt_misc))
+            (requirement '(file-system-/proc/sys/fs/binfmt_misc
+                           file-system-/gnu/store))
             (start #~(lambda ()
                        ;; Register the handlers for all of PLATFORMS.
                        (for-each (lambda (str)