| Message ID | 87blh8anv1.fsf@gnu.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#43922] installer: Add Emacs EXWM desktop environment. [WAS Re: Call for 1.2 installer testing.] | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | fail | View Laminar job |
Hey janneke, > It works for me; I found Emacs EXWM missing however. After zenny also > asked about that this morning, I decided to create a patch. Thanks for testing and for the patch! I think it might be necessary to add "emacs-exwm" to "installation-target-os-for-gui-tests" in (gnu tests install) module. To make sure that it's working fine you can run: --8<---------------cut here---------------start------------->8--- make check-system TESTS="gui-installed-os gui-installed-os-encrypted gui-installed-desktop-os-encrypted" --8<---------------cut here---------------end--------------->8--- Otherwise, it looks fine. Thanks, Mathieu
Mathieu Othacehe writes: Hi Mathieu, >> It works for me; I found Emacs EXWM missing however. After zenny also >> asked about that this morning, I decided to create a patch. > > Thanks for testing Using it is real easy, pleasant, and fast. One thing that I got wrong a couple of times is to actually select a suggested option while partitioning, I pressed TAB and RET (like in previous screens), then selecting the button that is clearly marked EXIT. Then it tries to continue with a non-partitioned or badly partitioned drive, which then may give an unexpected error. Clearly a user error, not a problem and I also do not have a better suggestion. Also, my mistake was very obvious to me later. > and for the patch! I think it might be necessary to > add "emacs-exwm" to "installation-target-os-for-gui-tests" in (gnu tests > install) module. Good call. I verified that the test fails without it.. > To make sure that it's working fine you can run: > > make check-system TESTS="gui-installed-os gui-installed-os-encrypted > gui-installed-desktop-os-encrypted" --8<---------------cut here---------------start------------->8--- cannot build derivation `/gnu/store/7xnhrap7xsv2x717yn9wrgisxpppxrmy-emacs-27.1.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/kkfdhpc81h0f0sz0mj1ayin0sxy7vkmq-emacs-desktop-environment-0.3.0.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/3amvkhwa4jv8fghljgkcvlkpg4mpwc8v-emacs-exwm-0.24.drv': 1 dependencies couldn't be built cannot build derivation `/gnu/store/q4pxd90hb9mah7cs9r1cjyb2pif1ixmz-emacs-xelb-0.18.drv': 1 dependencies couldn't be built --8<---------------cut here---------------end--------------->8--- and veried that it passes when I adding them. > Otherwise, it looks fine. Thanks, pushed to master as 1197b8b20f4fca4ce03bbc5fa75e18d54e3717c0. Greetings, Janneke
From 130480c4e76d7133f32a83cb1fa30aa171944383 Mon Sep 17 00:00:00 2001 From: "Jan (janneke) Nieuwenhuizen" <janneke@gnu.org> Date: Sun, 11 Oct 2020 12:45:00 +0200 Subject: [PATCH] installer: Add Emacs EXWM desktop environment. Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Suggested by zenny via IRC. * gnu/installer/services.scm (%system-services): Add emacs, emacs-exwm, emacs-desktop-environment. * etc/release-manifest.scm (%system-packages): Likewise. * gnu/system/examples/lightweight-desktop.tmpl: Likewise. * gnu/installer/newt/services.scm (run-desktop-environments-cbt-page): Make one entry taller. --- etc/release-manifest.scm | 2 ++ gnu/installer/newt/services.scm | 3 ++- gnu/installer/services.scm | 6 ++++++ gnu/system/examples/lightweight-desktop.tmpl | 3 ++- 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/etc/release-manifest.scm b/etc/release-manifest.scm index caa200c673..7f54fe8768 100644 --- a/etc/release-manifest.scm +++ b/etc/release-manifest.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2020 Ludovic Courtès <ludo@gnu.org> +;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org> ;;; ;;; This file is part of GNU Guix. ;;; @@ -53,6 +54,7 @@ TARGET." (append (map specification->package '("xorg-server" "xfce" "gnome" "mate" "enlightenment" "openbox" "awesome" "i3-wm" "ratpoison" + "emacs" "emacs-exwm" "emacs-desktop-environment" "xlockmore" "slock" "libreoffice" "connman" "network-manager" "network-manager-applet" "openssh" "ntp" "tor" diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.scm index 4f32d9077b..6d431cb4bb 100644 --- a/gnu/installer/newt/services.scm +++ b/gnu/installer/newt/services.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com> ;;; Copyright © 2019 Ludovic Courtès <ludo@gnu.org> +;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org> ;;; ;;; This file is part of GNU Guix. ;;; @@ -40,7 +41,7 @@ choose the one to use on the log-in screen.") #:items items #:selection (map system-service-recommended? items) #:item->text system-service-name ;no i18n for DE names - #:checkbox-tree-height 8 + #:checkbox-tree-height 9 #:exit-button-callback-procedure (lambda () (raise diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm index dbac79196d..ec5ea30594 100644 --- a/gnu/installer/services.scm +++ b/gnu/installer/services.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com> ;;; Copyright © 2019 Ludovic Courtès <ludo@gnu.org> +;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org> ;;; ;;; This file is part of GNU Guix. ;;; @@ -82,6 +83,11 @@ (name "ratpoison") (packages '((specification->package "ratpoison") (specification->package "xterm")))) + (desktop-environment + (name "Emacs EXWM") + (packages '((specification->package "emacs") + (specification->package "emacs-exwm") + (specification->package "emacs-desktop-environment")))) ;; Networking. (system-service diff --git a/gnu/system/examples/lightweight-desktop.tmpl b/gnu/system/examples/lightweight-desktop.tmpl index b4037d4f79..8e38095a03 100644 --- a/gnu/system/examples/lightweight-desktop.tmpl +++ b/gnu/system/examples/lightweight-desktop.tmpl @@ -4,7 +4,7 @@ (use-modules (gnu) (gnu system nss)) (use-service-modules desktop) -(use-package-modules bootloaders certs ratpoison suckless wm xorg) +(use-package-modules bootloaders certs emacs-xyz ratpoison suckless wm xorg) (operating-system (host-name "antelope") @@ -43,6 +43,7 @@ (packages (append (list ;; window managers ratpoison i3-wm i3status dmenu + emacs-exwm emacs-desktop-environment ;; terminal emulator xterm ;; for HTTPS access -- Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com