From patchwork Sun Jan 22 22:58:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ricardo Wurmus X-Patchwork-Id: 46345 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id DAE0C27BBEB; Sun, 22 Jan 2023 23:04:20 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D59DF27BBE9 for ; Sun, 22 Jan 2023 23:04:16 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJjNc-0007tL-AB; Sun, 22 Jan 2023 18:04:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJjNa-0007tA-Dt for guix-patches@gnu.org; Sun, 22 Jan 2023 18:04:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJjNa-0000Qv-5W for guix-patches@gnu.org; Sun, 22 Jan 2023 18:04:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJjNZ-00048u-NO for guix-patches@gnu.org; Sun, 22 Jan 2023 18:04:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#58681] [PATCH v2] gnu: Add synthpod. References: In-Reply-To: Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 Jan 2023 23:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58681 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: 58681@debbugs.gnu.org Cc: Sughosha Received: via spool by 58681-submit@debbugs.gnu.org id=B58681.167442862315896 (code B ref 58681); Sun, 22 Jan 2023 23:04:01 +0000 Received: (at 58681) by debbugs.gnu.org; 22 Jan 2023 23:03:43 +0000 Received: from localhost ([127.0.0.1]:52786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJjNG-00048J-Ik for submit@debbugs.gnu.org; Sun, 22 Jan 2023 18:03:43 -0500 Received: from sender3-of-o59.zoho.com ([136.143.184.59]:21964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJjND-000489-VE for 58681@debbugs.gnu.org; Sun, 22 Jan 2023 18:03:41 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1674428616; cv=none; d=zohomail.com; s=zohoarc; b=OLBJaZtG4h11TOjyvTto4wJKR03zri/VuT6SKl3KlAvXRXuoBvAks7J9zNZFd3JWu5I5ltc5DssqNRGQxqaS8+hXJGbLXORdZewVIpT2PEAwTWkxEWEfxXvCl5h8Z4UDIoZQFuFarx5IlinTDsT6K4GNWeJGgCF6U6T3LXfCDLM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674428616; h=Content-Type:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=9+NL52Dd4LQF+dv3OxOj8KvuyzBCoIR5rsrVxO1aJIE=; b=Hr3mYdKcvELii7+LIaqx78IN6kMcyxwvpV4qzEWr10ArGKKVNNSsHVivOk1w/1aeDKtcfayv9/tlgr56gX0UvZ2CvpKet5OVQESkoA4WCK6zVl/AFMIwg++0GKzUqNMR6UJUs7K/hdp258kZdRVvnvFTNhezoBWbLHYOLSYArck= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1674428616; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=9+NL52Dd4LQF+dv3OxOj8KvuyzBCoIR5rsrVxO1aJIE=; b=Dn8wLXr3mHigWuWHXkaUlM5j1v15o7A3E+N0MvVxx4vLzpPMGVOceHj6tRQq72Bw Q/g0exCMj9/Y1lDX1ncyHn+IOVGassvO6dHGI5cCOnrgyN0NBVxN9r5zbAF8ObwNnO6 cCnm7KbCy2AnYB6+1LLIJFb4smpDAEDccx8eEuFw= Received: from localhost (196-108-142-46.pool.kielnet.net [46.142.108.196]) by mx.zohomail.com with SMTPS id 1674428615272258.17014992715303; Sun, 22 Jan 2023 15:03:35 -0800 (PST) User-agent: mu4e 1.8.13; emacs 28.2 From: Ricardo Wurmus Date: Sun, 22 Jan 2023 23:58:25 +0100 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87bkmqf9z4.fsf@elephly.net> MIME-Version: 1.0 X-ZohoMailClient: External X-Zoho-Virus-Status: 1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi, I made these changes: It avoids propagation of lilv and patches synthpod_ui to look for other executables in a known location. We should probably also wrap the scripts to set PATH to where “grep”, “coreutils”, “sed”, and “gawk” are found, but I wasn’t able to add (gnu packages gawk) to the imports of (gnu packages music). Unfortunately, the program crashes because it can’t find the LV2 files for Synthpod itself: --8<---------------cut here---------------start------------->8--- $ /gnu/store/pp3rysfcssf3kigh01mrz7jc16dgp51p-synthpod-0.1.6507/bin/synthpod_ui error: failed to open file /home/rekado/.lv2/Synthpod_default.preset.lv2/manifest.ttl (No such file or directory) lilv_world_load_file(): error: Error loading file `file:///home/rekado/.lv2/Synthpod_default.preset.lv2/manifest.ttl' lilv_world_load_bundle(): error: Error reading file:///home/rekado/.lv2/Synthpod_default.preset.lv2/manifest.ttl Plugin not found. Synthpod 0.1.6507 Copyright (c) 2015-2016 Hanspeter Portner (dev@open-music-kontrollers.ch) Released under Artistic License 2.0 by Open Music Kontrollers error: failed to open file /home/rekado/dev/gx/branches/master/manifest.ttl (No such file or directory) lilv_world_load_file(): error: Error loading file `file:///home/rekado/dev/gx/branches/master/manifest.ttl' lilv_world_load_bundle(): error: Error reading file:///home/rekado/dev/gx/branches/master/manifest.ttl lilv_plugins_get_by_uri failed Segmentation fault --8<---------------cut here---------------end--------------->8--- These probably should be looked up in $out/lib/synthpod/lv2 instead of searching the LV2 path. diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index ca058638f2..f2f5289dba 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -44,7 +44,7 @@ ;;; Copyright © 2021 Simon Streit ;;; Copyright © 2021 Xinglu Chen ;;; Copyright © 2021 Thomas Albers Raviola -;;; Copyright © 2022 Sughosha +;;; Copyright © 2022, 2023 Sughosha ;;; Copyright © 2022 Remco van 't Veer ;;; Copyright © 2022 Maxim Cournoyer ;;; Copyright © 2022 Wamm K. D. @@ -3566,44 +3566,53 @@ (define-public synthpod (source (origin (method git-fetch) (uri (git-reference - (url "https://git.open-music-kontrollers.ch/lv2/synthpod") - ;; Version is not tagged but mentioned in VERSION file. - (commit "6e84a075ea8fea95094dcbc2b30f968717a81960"))) + (url "https://git.open-music-kontrollers.ch/lv2/synthpod") + ;; Version is not tagged but mentioned in VERSION file. + (commit "6e84a075ea8fea95094dcbc2b30f968717a81960"))) (file-name (git-file-name name version)) (sha256 - (base32 - "1chazkdxjgjzfxqmlk4ywhilkj9l3bybd9xghjg9r67df2diqhbs")))) + (base32 + "1chazkdxjgjzfxqmlk4ywhilkj9l3bybd9xghjg9r67df2diqhbs")))) (build-system meson-build-system) (arguments (list #:phases #~(modify-phases %standard-phases - (add-before 'check 'fix-home-directory + (add-after 'unpack 'patch-references + (lambda* (#:key inputs #:allow-other-keys) + (substitute* '("bin/synthpod_ui" + "bin/synthpod_d2tk") + (("lv2info") (search-input-file inputs "/bin/lv2info")) + ((" synthpod_sandbox_x11") + (string-append " " #$output "/bin/synthpod_sandbox_x11"))))) + (add-before 'check 'set-home-directory (lambda _ ;; Tests fail with: Fontconfig error: No writable cache ;; directories (setenv "HOME" "/tmp")))))) - (propagated-inputs (list lilv)) ;required for lv2info - (inputs (list alsa-lib - cairo - eudev - freetype - font-fira-code - font-fira-sans - fontconfig - glew - glu - jack-1 - libevdev - libinput - libvterm - lv2 - pixman - sratom - xcb-util - xcb-util-wm - xcb-util-xrm - zita-alsa-pcmi)) + (inputs + (list alsa-lib + cairo + eudev + freetype + font-fira-code + font-fira-sans + fontconfig + glew + glu + grep + jack-2 + libevdev + libinput + libvterm + lilv ;for lv2info + lv2 + pixman + sratom + xcb-util + xcb-util-wm + xcb-util-xrm + zita-alsa-pcmi)) (native-inputs (list pkg-config)) (home-page "https://open-music-kontrollers.ch/lv2/synthpod/") (synopsis "Nonlinear LV2 plugin container")