| Message ID | 87bkcugyky.fsf@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#66643] gnu: icedove/wayland: Use wrap-program. | expand |
Hello, just a gentle ping -- could anyone review this patch? If using wrap-program isn't quite appropriate, I can fix it another way.
Hi, Another month has passed since the last letter, I am sending another ping, this time I added members of the mozilla team to the CC. The patch is still working, but if it’s unnecessary, I can just close the thread.
On Fri, Jan 12 2024, Aleksandr Vityazev wrote: > Hi, > > Another month has passed since the last letter, I am sending another > ping, this time I added members of the mozilla team to the CC. The patch > is still working, but if it’s unnecessary, I can just close the thread. Hey Aleksandr, Sorry for not replying earlier. Wouldn't putting quotes around $@ (like \"$@\") be enough? Thanks, Clément
On 2024-01-12 01:48, Clément Lassieur wrote: > On Fri, Jan 12 2024, Aleksandr Vityazev wrote: > >> Hi, >> >> Another month has passed since the last letter, I am sending another >> ping, this time I added members of the mozilla team to the CC. The patch >> is still working, but if it’s unnecessary, I can just close the thread. > > Hey Aleksandr, > > Sorry for not replying earlier. there's no need to apologize, it's okay. I often forget to add team members in the CC field of an email. > > Wouldn't putting quotes around $@ (like \"$@\") be enough? > both options solve the problem, the proposed one is simpler, so you can choose this one. I will send v2 patch in the next mail.
On Fri, Jan 12 2024, Aleksandr Vityazev wrote: > On 2024-01-12 01:48, Clément Lassieur wrote: > >> On Fri, Jan 12 2024, Aleksandr Vityazev wrote: >> >>> Hi, >>> >>> Another month has passed since the last letter, I am sending another >>> ping, this time I added members of the mozilla team to the CC. The patch >>> is still working, but if it’s unnecessary, I can just close the thread. >> >> Hey Aleksandr, >> >> Sorry for not replying earlier. > > there's no need to apologize, it's okay. I often forget to add team > members in the CC field of an email. > >> >> Wouldn't putting quotes around $@ (like \"$@\") be enough? >> > > both options solve the problem, the proposed one is simpler, so you can > choose this one. I will send v2 patch in the next mail. Ok, the simpler the better! Pushed, thanks.
diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index a367d7a00f..7a71fc8cb9 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -20,6 +20,7 @@ ;;; Copyright © 2021, 2022, 2023 Maxim Cournoyer <maxim.cournoyer@gmail.com> ;;; Copyright © 2021 Baptiste Strazzul <bstrazzull@hotmail.fr> ;;; Copyright © 2022 SeerLite <seerlite@disroot.org> +;;; Copyright © 2023 Aleksandr Vityazev <avityazew@gmail.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -2076,14 +2077,11 @@ (define-public icedove/wayland #~(begin (use-modules (guix build utils)) (let* ((exe (string-append #$output "/bin/icedove"))) - (mkdir-p (dirname exe)) - (call-with-output-file exe - (lambda (port) - (format port "#!~a - MOZ_ENABLE_WAYLAND=1 exec ~a $@" - #$(file-append bash-minimal "/bin/bash") - #$(file-append icedove "/bin/icedove")))) - (chmod exe #o555) + (install-file #$(file-append icedove "/bin/icedove") + (string-append #$output "/bin")) + (wrap-program exe + #:sh #$(file-append bash-minimal "/bin/bash") + '("MOZ_ENABLE_WAYLAND" "" = ("1"))) ;; Provide the manual and .desktop file. (copy-recursively (string-append #$icedove "/share") (string-append #$output "/share"))