[bug#34600,1/5] gnu: emacs-which-key: Update to 3.3.1.

Message ID 87a7ipvqgb.fsf@posteo.net
State Accepted
Headers show
Series [bug#34600,1/5] gnu: emacs-which-key: Update to 3.3.1. | expand

Checks

Context Check Description
cbaines/applying patch fail Apply failed
cbaines/applying patch fail Apply failed
cbaines/applying patch fail Apply failed
cbaines/applying patch fail Apply failed
cbaines/applying patch fail Apply failed

Commit Message

Brett Gilio Feb. 21, 2019, 2:13 a.m. UTC

Comments

swedebugia Feb. 21, 2019, 7:30 p.m. UTC | #1
Brett Gilio <brettg@posteo.net> skrev: (21 februari 2019 03:13:40 CET)
>

Hi Brett
You send a patch series without first sending an email to get a bug number.
We do this to keep series together under 1 number.

Could you try again and close these?
Brett Gilio Feb. 21, 2019, 7:46 p.m. UTC | #2
swedebugia writes:

> Brett Gilio <brettg@posteo.net> skrev: (21 februari 2019 03:13:40 CET)
>>
>
> Hi Brett
> You send a patch series without first sending an email to get a bug number.
> We do this to keep series together under 1 number.
>
> Could you try again and close these?

You're going to have to be more specific. Do all patch series go under a
single bug number?
Leo Famulari Feb. 21, 2019, 8:30 p.m. UTC | #3
On Thu, Feb 21, 2019 at 01:46:03PM -0600, Brett Gilio wrote:
> You're going to have to be more specific. Do all patch series go under a
> single bug number?

If the patches are related, or depend on each other, then they should be
mailed to the same bug number. Otherwise it's more difficult to review
the patches.

You can send an intro email to <guix-patches@gnu.org>, wait for the
number to be assigned, and then send the patches to that numbered
address <NNN@debbugs.gnu.org>.
Brett Gilio Feb. 21, 2019, 9:30 p.m. UTC | #4
Leo Famulari writes:

> On Thu, Feb 21, 2019 at 01:46:03PM -0600, Brett Gilio wrote:
>> You're going to have to be more specific. Do all patch series go under a
>> single bug number?
>
> If the patches are related, or depend on each other, then they should be
> mailed to the same bug number. Otherwise it's more difficult to review
> the patches.
>
> You can send an intro email to <guix-patches@gnu.org>, wait for the
> number to be assigned, and then send the patches to that numbered
> address <NNN@debbugs.gnu.org>.

Understood. Thank you, I will fix this asap.
swedebugia Feb. 22, 2019, 8:28 a.m. UTC | #5
On 02/21/2019 08:46 PM, Brett Gilio wrote:
> swedebugia writes:
>
>> Brett Gilio <brettg@posteo.net> skrev: (21 februari 2019 03:13:40 CET)
>> Hi Brett
>> You send a patch series without first sending an email to get a bug number.
>> We do this to keep series together under 1 number.
>>
>> Could you try again and close these?
> You're going to have to be more specific. Do all patch series go under a
> single bug number?

Sorry if I was unclear. Yes.

The details are here: 
http://guix.info/manual/en/Submitting-Patches.html#Sending-a-Patch-Series

It was a bad idea to tell you to send them again, but it is nice to have 
them together.

And thanks for the patches anyway :)
宋文武 Feb. 24, 2019, 3:10 a.m. UTC | #6
Brett Gilio <brettg@posteo.net> writes:

>>From f4ce2f1459ed5a3dc08094c03d98c4cc1eb91348 Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg@posteo.net>
> Date: Wed, 20 Feb 2019 19:55:07 -0600
> Subject: [PATCH 1/5] gnu: emacs-which-key: Update to 3.3.1.

Applied, thanks!

Patch

From f4ce2f1459ed5a3dc08094c03d98c4cc1eb91348 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg@posteo.net>
Date: Wed, 20 Feb 2019 19:55:07 -0600
Subject: [PATCH 1/5] gnu: emacs-which-key: Update to 3.3.1.

* gnu/packages/emacs-xyz.scm (emacs-which-key): Update to 3.3.1.
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index cedc1efbc..80dc9eb63 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7214,7 +7214,7 @@  or @code{treemacs}, but leveraging @code{Dired} to do the job of display.")
 (define-public emacs-which-key
   (package
     (name "emacs-which-key")
-    (version "3.3.0")
+    (version "3.3.1")
     (source
      (origin
        (method url-fetch)
@@ -7223,7 +7223,7 @@  or @code{treemacs}, but leveraging @code{Dired} to do the job of display.")
              version ".tar.gz"))
        (sha256
         (base32
-         "1lsj314111cp2hjjwnv3f46ws1za6bm39rgy3l19044xf6a68j5w"))
+         "1g8k0js21bc8mlw6hvmg93zgfjhil77c30cv1hf85y4qb9ldvika"))
        (file-name (string-append name "-" version ".tar.gz"))))
     (build-system emacs-build-system)
     (arguments
-- 
2.20.1