From patchwork Wed Feb 12 20:08:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kyle Meyer X-Patchwork-Id: 20233 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A615127BBE4; Wed, 12 Feb 2020 20:10:11 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id CCC0527BBEA for ; Wed, 12 Feb 2020 20:10:10 +0000 (GMT) Received: from localhost ([::1]:42724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1yKo-00007w-AJ for patchwork@mira.cbaines.net; Wed, 12 Feb 2020 15:10:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38642) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1yKh-00007n-Nd for guix-patches@gnu.org; Wed, 12 Feb 2020 15:10:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1yKg-0005Y8-Jq for guix-patches@gnu.org; Wed, 12 Feb 2020 15:10:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53123) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1yKg-0005Y0-E2 for guix-patches@gnu.org; Wed, 12 Feb 2020 15:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1yKg-0001Wt-9Y for guix-patches@gnu.org; Wed, 12 Feb 2020 15:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#39146] [PATCH v3] gnu: icecat: Remove about:buildconfig store references. References: <20200115222115.322ymuuqkwlnbl3v@zdrowyportier.kadziolka.net> Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 12 Feb 2020 20:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39146 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jakub =?utf-8?b?S8SFZHppb8WCa2E=?= , 39146@debbugs.gnu.org Cc: Mark H Weaver , Marius Bakke , Tobias Geerinckx-Rice , Danny Milosavljevic Received: via spool by 39146-submit@debbugs.gnu.org id=B39146.15815381495811 (code B ref 39146); Wed, 12 Feb 2020 20:10:02 +0000 Received: (at 39146) by debbugs.gnu.org; 12 Feb 2020 20:09:09 +0000 Received: from localhost ([127.0.0.1]:59096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1yJi-0001VV-AE for submit@debbugs.gnu.org; Wed, 12 Feb 2020 15:09:09 -0500 Received: from pb-smtp21.pobox.com ([173.228.157.53]:58296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1yJf-0001V7-CH for 39146@debbugs.gnu.org; Wed, 12 Feb 2020 15:09:00 -0500 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 4E9A1B44E7; Wed, 12 Feb 2020 15:08:58 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:date:message-id:mime-version:content-type :content-transfer-encoding; s=sasl; bh=rYb7mTur1Lr0E2qGGgb2kpR6e 1U=; b=unj91QUa3jYCw84GQK78xHCNXjcjJLbhbJLgWfjuuF/l7QVjZrfJIP6Vm rR/74/uq4wWz0WWO9gCxWFwcj08aFgOeox3HqyeNBECaSNnNEIvfDbDYu3vrRK26 tZ63TTuUOGJjXcyObzZWWyQjbDKjOnDmgX3hOzb/bqJiApJptY= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 4713AB44E6; Wed, 12 Feb 2020 15:08:58 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:date:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=pYvtoMkSUVjjHOn+7I/UOWD/rrtppoPo1+/RtPhxrak=; b=DYP6GBJGK81BdyHplLaq1YxpIOmW5TrvrghDReWVHVZPvTJFnmF2EFZoPJTlURrFdREKN93+SOpXjHoBE+YoSXNvPYC04jD96SFFkYizHf8o3fumhXOpotyYC0R0r3CCeUblO7XUkZs44T0lx/I0lRnXOFxXPtyyYC6IvC2woAw= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id B18F6B44E5; Wed, 12 Feb 2020 15:08:55 -0500 (EST) (envelope-from kyle@kyleam.com) From: Kyle Meyer In-Reply-To: <20200212194525.joyg66cikh5xfnuu@gravity> Date: Wed, 12 Feb 2020 20:08:54 +0000 Message-ID: <87a75nin55.fsf@kyleam.com> MIME-Version: 1.0 X-Pobox-Relay-ID: 7F4D873A-4DD3-11EA-8C2F-8D86F504CC47-24757444!pb-smtp21.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Jakub Kądziołka writes: > BTW, do you happen to know a good way to send a patch as a reply? I > ended up using `neomutt -H' and then specifying all the CC's manually... One option is to reply to the message as you normally would and then insert the patch under scissors. Here's an example using your patch. I've kept the "From:" line, but that's not necessary if the sender of the email matches the patch author. On the other end, that can be applied with `git am --scissors'. -- >8 -- From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= Subject: [PATCH v3] gnu: icecat: Remove about:buildconfig store references. * gnu/packages/gnuzilla.scm (icecat)[arguments]: New ‘neutralise-store-references’ phase. Co-authored-by: Tobias Geerinckx-Rice --- gnu/packages/gnuzilla.scm | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 863edb3b4e..7d5020f7c2 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -7,10 +7,11 @@ ;;; Copyright © 2016 Alex Griffin ;;; Copyright © 2017 Clément Lassieur ;;; Copyright © 2017 ng0 -;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice +;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice ;;; Copyright © 2018 Ricardo Wurmus ;;; Copyright © 2019 Ivan Petkov ;;; Copyright © 2020 Oleg Pykhalov +;;; Copyright © 2020 Jakub Kądziołka ;;; ;;; This file is part of GNU Guix. ;;; @@ -1067,6 +1068,17 @@ (define-public icecat (force-output) (retry (- remaining-attempts 1)))) (apply build args))))))) + (add-after 'build 'neutralise-store-references + (lambda _ + ;; Mangle the store references to compilers & other build tools in + ;; about:buildconfig, reducing IceCat's closure by 1 GiB on x86-64. + (substitute* + "dist/bin/chrome/toolkit/content/global/buildconfig.html" + (((format #f "(~a/)([0-9a-z]{32})" (%store-directory)) _ store hash) + (string-append store (string-take hash 8) + "" + (string-drop hash 8)))) + #t)) (add-before 'configure 'install-desktop-entry (lambda* (#:key outputs #:allow-other-keys) ;; Install the '.desktop' file.