diff mbox series

[bug#50425] gnu: Add minetest-advtrains.

Message ID 87a6kqm6f3.fsf@planete-kraus.eu
State Accepted
Headers show
Series [bug#50425] gnu: Add minetest-advtrains. | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Vivien Kraus Sept. 6, 2021, 8:53 a.m. UTC
Dear Guix,

I’d like to have the advtrains minetest mod in Guix, what do you think?

Best regards,

Vivien

Comments

M Sept. 6, 2021, 11:03 a.m. UTC | #1
Maxime Devos schreef op ma 06-09-2021 om 13:02 [+0200]:
> 

Please ignore, I accidentally pushed 'Sent' before writing
anything.
M Sept. 6, 2021, 11:17 a.m. UTC | #2
Vivien Kraus via Guix-patches via schreef op ma 06-09-2021 om 10:53 [+0200]:
> Guix,
> 
> I’d like to have the advtrains minetest mod in Guix, what do you think?

Did the minetest importer work well for you?

> +- Almost-realistic tracks with actual curves and switches
> +- Railway signals, controllable by various means
> +- ATC: Simple, command-like automatic train control
> +- LuaATC: Powerful Lua-scripted automatic train operation(requires some programming knowledge)*

Package descriptions are in texinfo, not markdown.  You'll need
to make the necessary adjustments.  Being proper Texinfo is necessary
for things like <https://guix.gnu.org/en/packages/minetest-mesecons-1.2.1-0.db58797/>.

(It would be nice if guix could automatically convert the markup ...)

> +    (license
> +     (list license:cc-by-sa3.0 license:agpl3))

According to http://git.bananach.space/basic_trains.git/tree/license.txt,
it's agpl3+ actually.  I now that the ContentDB page (and hence, the importer)
says it's AGPL-3.0-only, but ContentDB only very recently distinguishes between
AGPL-3.0-only and AGPL-3.0-or-later.  I sent a bug report upstream.

Greetings,
Maxime.
diff mbox series

Patch

From 2a0abac482a9a40a1263419766d23a169ec61e89 Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Sun, 5 Sep 2021 15:21:35 +0200
Subject: [PATCH] gnu: add minetest-advtrains

* gnu/packages/minetest.scm (minetest-advtrains): New variable.
* gnu/packages/minetest.scm (minetest-basic-trains): New variable.
---
 gnu/packages/minetest.scm | 61 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/gnu/packages/minetest.scm b/gnu/packages/minetest.scm
index 5453f4d16a..13ea6036f5 100644
--- a/gnu/packages/minetest.scm
+++ b/gnu/packages/minetest.scm
@@ -624,3 +624,64 @@  track of important locations.")
                    license:cc-by4.0 license:cc-by-sa3.0 license:public-domain
                    license:cc0 license:fdl1.2+))
     (properties `((upstream-name . "RealBadAngel/unified_inventory")))))
+
+(define-public minetest-advtrains
+  (package
+    (name "minetest-advtrains")
+    (version "2.3.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.bananach.space/advtrains.git")
+             (commit "release-2.3.1")))
+       (sha256
+        (base32 "1ijqlchh269jpvmgmdmdvy3nsnk0bszkvvcqk6vaysvxam695ggw"))
+       (file-name (git-file-name name version))))
+    (build-system minetest-mod-build-system)
+    (home-page "http://advtrains.de/")
+    (synopsis
+     "Adds good-looking, realistic trains with realistic rails.")
+    (description
+     "This mod features realistic trains and various equipment for railways, with a focus on automated train operation.
+
+Main features:
+
+- Almost-realistic tracks with actual curves and switches
+- Railway signals, controllable by various means
+- ATC: Simple, command-like automatic train control
+- LuaATC: Powerful Lua-scripted automatic train operation(requires some programming knowledge)*
+- An Interlocking system, featuring track sections, routes and automatic stopping before signals")
+    (license
+     (list license:cc-by-sa3.0 license:agpl3))
+    (properties
+     `((upstream-name . "orwell/advtrains")))))
+
+(define-public minetest-basic-trains
+  (package
+    (name "minetest-basic-trains")
+    (version "1.0.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "http://git.bananach.space/basic_trains.git/")
+             (commit
+              "d44c410f7c2a7202ee68b66fc50febae89e0c5dc")))
+       (sha256
+        (base32
+         "0vvzndj48kgdz2bfgivfm217sbmc2lmxpp2mispcy7byn4i26prx"))
+       (file-name (git-file-name name version))))
+    (build-system minetest-mod-build-system)
+    (propagated-inputs
+     `(("minetest-advtrains" ,minetest-advtrains)))
+    (home-page
+     "http://advtrains.de/wiki/doku.php?id=usage:trains:basic_trains")
+    (synopsis
+     "Collection of basic trains for the Advanced Trains mod. Formerly included in main advtrains modpack (until 2.3.0)")
+    (description
+     "This modpack contains the trains which were the \"default\" trains in advtrains up to version 2.2.1.")
+    (license
+     (list license:cc-by-sa3.0 license:agpl3))
+    (properties
+     `((upstream-name . "orwell/basic_trains")))))
-- 
2.33.0