From patchwork Tue Feb 1 17:02:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Niklas Eklund X-Patchwork-Id: 36921 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6BC3027BBE9; Tue, 1 Feb 2022 20:39:35 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 26093166FF for ; Tue, 1 Feb 2022 20:39:35 +0000 (GMT) Received: from localhost ([::1]:36106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEzw6-0007At-6K for patchwork@mira.cbaines.net; Tue, 01 Feb 2022 15:39:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEwYY-000541-5O for guix-patches@gnu.org; Tue, 01 Feb 2022 12:03:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51064) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEwYX-0004uI-Rb for guix-patches@gnu.org; Tue, 01 Feb 2022 12:03:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEwYX-0002j9-OJ for guix-patches@gnu.org; Tue, 01 Feb 2022 12:03:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53535] [PATCH] gnu: Add emacs-popper Resent-From: Niklas Eklund Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Feb 2022 17:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53535 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 53535@debbugs.gnu.org Received: via spool by 53535-submit@debbugs.gnu.org id=B53535.164373495810444 (code B ref 53535); Tue, 01 Feb 2022 17:03:01 +0000 Received: (at 53535) by debbugs.gnu.org; 1 Feb 2022 17:02:38 +0000 Received: from localhost ([127.0.0.1]:43967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEwY9-0002iO-Nc for submit@debbugs.gnu.org; Tue, 01 Feb 2022 12:02:38 -0500 Received: from mout01.posteo.de ([185.67.36.65]:39477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEwY5-0002i8-Gf for 53535@debbugs.gnu.org; Tue, 01 Feb 2022 12:02:36 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 4C744240027 for <53535@debbugs.gnu.org>; Tue, 1 Feb 2022 18:02:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1643734947; bh=UPaPnnk5rSamJp6AvZxpnaoAlBUA99M2CWlb37UJDu4=; h=From:To:Cc:Subject:Date:From; b=dhY+LlgFIa/MuF4S/kKeIX/KoSLIgKVjisjD+AuQo0dAQHajm8x+tT6BrffCUh1kC 94FfD8aOUpOQftm9WYphCq5G7t/vNKVa4ORTJ8s//HP8S49RKT0471jIAPQU8+HFJ4 UfSEorUESPrbgDmstiuIR+M+rAZ13BNihK+Xdl68i0cw9qRt3IEu9qnrONUSRy/nBN YSLaLy2qBoTHu8q0kXKk14Jw6H0RwPsznGP4n2PLz9kxtio/TzzPO0kGmo8sM8GSth UWu5CNBOseVYDYNT0OimjVs2HCqtkVwVIY6eWlAtIcsdEJTLMchU6N8eMglfKJ9TKE Wcd3QKEsOo6WA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JpB7Q1TKlz6tmW; Tue, 1 Feb 2022 18:02:26 +0100 (CET) From: Niklas Eklund In-Reply-To: References: Date: Tue, 01 Feb 2022 17:02:25 +0000 Message-ID: <87a6fafrku.fsf@posteo.net> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Niklas Eklund writes: > Nicolas Goaziou writes: > >> Hello, >> >> Niklas Eklund writes: >> >>> this patch adds the emacs-popper package. >> >> Thank you. Somme comments follow.. >> >>> Subject: [PATCH] gnu: Add emacs-popper. >> >> The commit message is missing a line: >> >> * gnu/packages/emacs-xyz.scm (emacs-popper): New variable. Aha, I hadn't grasped that before. Thanks for mentioning it. Fixed that in this new patch. >>> +(define-public emacs-popper >>> + ;; No tagged release upstream for version 0.45 >> >> This is true, but the commit matching release 0.45 is >> "851d83882192ac9599ac5b053614a42d683b3fab", not the one you're using. >> >>> + (let ((commit "527a85c49174e6e79220f0ed0761c204a979eae6") (revision "0")) >> >> Could you add a newline between (commit ...) and (revision ...)? >>> + (package >>> + (name "emacs-popper") >>> + (version "0.45") >> >> You bound revision, but you're not actually making use of it. I think >> there are two possibilities here: >> >> - if you use commit 851d83882192ac9599ac5b053614a42d683b3fab, you can >> keep using (version "0.45"), and explain in a comment that the chosen >> commit matches version bump; >> >> - if you use another commit, you need to use (git-version "0.45" >> revision commit) instead, and explain in a comment why you're using an >> untagged commit. >> >> Could you send an updated patch? Good points. I have changed to the 851d83882192ac9599ac5b053614a42d683b3fab commit and dropped revision. >> Regards, >> -- >> Nicolas Goaziou /Niklas From 3f064617c9b001ced07a92bac86edcc7e31c2a1e Mon Sep 17 00:00:00 2001 From: Niklas Eklund Date: Wed, 26 Jan 2022 00:23:29 +0100 Subject: [PATCH] gnu: Add emacs-popper. * gnu/packages/emacs-xyz.scm (emacs-popper): New variable. --- gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 9d9adbb1e5..865c7c4172 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -7068,6 +7068,29 @@ (define-public emacs-popup and popup menus.") (license license:gpl3+))) +(define-public emacs-popper + ;; No tagged release upstream for version 0.45 + (let ((commit "851d83882192ac9599ac5b053614a42d683b3fab")) + (package + (name "emacs-popper") + (version "0.45") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/karthink/popper") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0pk5wzqlz7n6v8rb1957i3ql0wjx578l68a3rp2m9pxr7a8a03h4")))) + (build-system emacs-build-system) + (home-page "https://github.com/karthink/popper") + (synopsis "Emacs minor-mode to summon and dismiss buffers easily") + (description + "Popper is a minor-mode to tame the flood of ephemeral +windows Emacs produces, while still keeping them within arm’s reach.") + (license license:gpl3+)))) + (define-public emacs-python-black (package (name "emacs-python-black") -- 2.32.0