From patchwork Tue Nov 29 08:23:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ontje.Luensdorf@dlr.de X-Patchwork-Id: 44956 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E3A3A27BBE9; Tue, 29 Nov 2022 08:24:15 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D262F27BBEB for ; Tue, 29 Nov 2022 08:24:13 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozvuQ-0003Un-IT; Tue, 29 Nov 2022 03:24:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozvuN-0003Ue-Qe for guix-patches@gnu.org; Tue, 29 Nov 2022 03:24:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozvuN-0000LU-8f for guix-patches@gnu.org; Tue, 29 Nov 2022 03:24:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozvuM-0005dj-4N for guix-patches@gnu.org; Tue, 29 Nov 2022 03:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59177] [PATCH] python-protobuf: Use C++ implementation Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Nov 2022 08:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59177 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cc: 59177@debbugs.gnu.org Received: via spool by 59177-submit@debbugs.gnu.org id=B59177.166971022721670 (code B ref 59177); Tue, 29 Nov 2022 08:24:02 +0000 Received: (at 59177) by debbugs.gnu.org; 29 Nov 2022 08:23:47 +0000 Received: from localhost ([127.0.0.1]:54095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozvu6-0005dS-HS for submit@debbugs.gnu.org; Tue, 29 Nov 2022 03:23:46 -0500 Received: from mailin.dlr.de ([194.94.201.12]:61620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozvu4-0005dM-KE for 59177@debbugs.gnu.org; Tue, 29 Nov 2022 03:23:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dlr.de; i=@dlr.de; q=dns/txt; s=052022; t=1669710224; x=1701246224; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=V5/E7sKytJkSPeZyqvzDoChJHFm6O4r8ZwU0hupWxD0=; b=TBErlftk3//X4aTXOg38kRYOdKTZ+Y+lGNehEFPVEIdzbXx3X5owU9IF hbz3xkxRdcCasGc9J0DzYZxg9/FQbWbS/rtylAIirtHQXMqK5WXgOUoXT CPtcOqkrpfth8anLgTug2ezMms6/ua+De/ymDjSGo8TpUEnY9xPJUniEY NjoaMYSUNbcIH+Def2atfSuomueBc/e+bIvNUfGR4wZA3yj8dLmth6Sge kpTAjyVB3W5iOEpiwTNaKFv7jer5ebQkUjrkaUFz+TfpfwU7VYFiILNsE UZnH+z9UwqWMB2oXV/OoUo69PQMk7q9xcOM1BSITZ71VXbFOfnSFLHarz Q==; X-IPAS-Result: A2EuAwDjv4Vj/xiKuApaHgEBCxIMggQLgy8CgVgXhDiRGwOdNIF+CAcBAQEBAQEBAQEIATUPBAEBhQUCFoR0JjQJDgECBAEBAQEDAgMBAQEBAQEDAQEGAQEBAQEBBgQBAQKBGYUvOQ2CNSKCBQEBAQEBAQEBAQEBAQEcAg1SdwEBAQECASNWBQsCAQgRAwECCiECAgINASIdCAIEDgUOgnCCfyMTrT96gTKBAYRxnD0KBoFAiQaDSYRHglCBFYMqPoJiAoF3CS2DCoJnBIEpggaKXoMRhzEDRB02CgMLOzIKQzcIBh4DIGwFQQ8oL2QrHBsHgQwqKBUDBAQDAgYTAyACDSkxFAQpEw0rJ28JAgMiZQUDAwQoLAMJIR8HFhEmPAdWOgEEAwIPIDgGAwkDAiJUgSMmBQMLFSUIBUsECDkFBiQvEgIKEQMSDwYmRg5IPjkWBidCATAODhMDXYFpBDUtOYEVMS+aD4Euc4EOHBCCO5MDg0WKKUeBQaADB4Ifh3GFLZU5ln2SHIdSj2WKboJVmgwCBAIEBQIWgWJ2gSBxT4JnUhcCD5ISil51OwIHAQoBAQMJhkeCRIEUAQE IronPort-PHdr: A9a23:ION2BRKWX78G+ILcatmcuKxmWUAX0o4c3iYr45Yqw4hDbr6kt8y7e hCFubMy1xSQBNWTq6odzbaM6Oa4AS1IyK3CmUhKSIZLWR4BhJdetC0bK+nBN3fGKuX3ZTcxB sVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+KPjrFY7OlcS30P2594HObwlSizexf7x/I A+0oAjfucUanJZuJ6UswRfNvndEZv5ayGx2KV+dhRrw+tu88Jt++ClMpvwt8NJNX7/ndKoiV 7xYCzomM2Ex5ML1sBTIUBWC6HgBXGgIixREGwfK4g30UZf3qSv6q/Fy2DKGMs3sTLA7Qiqt4 qF2QxL1kigHNjo58GbKisxsia9QvRysqwBjz4PSfYqYMud1cKHActMAXWdPXthfWjJcDIOgY YUBDOQBMuRZr4bhqFQDth6+CRW2Ce711jNEmn370Ksn2OohCwHG2wkgEsoJvXrNqtX1KKUSX v6vwKfO0DXMcfVW2Szg54jPaBAhr+qBUq90ccrL00UgCh3Kg0yWpIf4MDybyv4DvHKH7+p8S +2vkWgnphlyrzav2sshi4rEip8bx13Z9Ch0wpg4KNylRUJlYNOpEpReuS6VOYZ1XM8vXWBlt Tokx7AbpZO2eCsHxIk5yhPCbfGMbouG4gr7WeqMPTt0nm9pdbGwihqo7EStxO7xWtOq3FtFt iZJj8XAumoQ2xHQ5cWLUOZx80mi1DqVyQze6u5JLEYpnqTBMZEh2KQ/lp8LvETGGS/5hVv5g beNdkUh5uio8+PnYqj6ppOEN497lAX+MqM2l8KxB+o2PAcAUWib9+q717Pt+lf3TKtFg/M5k 6bUrorWJcUdpq6lGQ9ayJwv5Au7Dze8ytgXgGcIIEpEeBKBkYfpJ0nDLO3kAfulnlihkzhmy +rbMrDvAZjBNGbPnbj5cbZ48UFcyQ4zzd5F55JTD7EMOOv9WknttNzaEBA1KQq6w/v5B9V7z YMRRGWPArWXMK7JrFCI4vgvL/ORa4ALoDr9LeMq6Ob0jXAlgV8dYbWp3ZwPZXymBvhmOVmWY WLwgtcdFmcHpg4+TPH3h12FSjNTaHCyX78m6jE8EoKmAp/PRpqxj7yZwCe7AppWa3hGB12ID HvldYeJVuwRZy2MOcBuiSEEVbe6S4M72hGushL6x6BgLurO9S1L/a7kgYxx+uHUvR406HpzF cvLgE+XSGQhykQOWz07moRirEpmxlCZ34B0h+YeGdEFtKABaRszKZOJl78yMNv1QA+UJr+0 IronPort-Data: A9a23:G77jQ6BKdAVpDhVW/7Hiw5YqxClBgxIJ4kV8jC+edUTsnH49nyhHn yZMAVkyCI+KYmL0Zo4oLZD2vA5e5sjIjpQ8DF0+6H8ocmlH7OGABNGBKkr1MiWOJ9HCS0Qh9 8wCYdmowKscR3KCrUzwb+m6pHMii6/QFuOhU7SdYnEsS1U/Fnkv10xvx7Foid4124O1WV3ct 9ijrZeAaVb8g2V6bGtN4a6O8XuD0BiKVBYw5zTSMtgS5g6C/5VsMLofOb2pNCm/BYZVAu6nT aDIy7T+8WTe8BMgTcu/lar8eFAEKoI+RjNi/Ee6IYD5xEQqmxEP70obCBY9QRYHgjiAwosom IUcvsPhEV55b6CSw7gWD0lVTngnNvJI0bKWenLXXe5/bqHln9kA5900USna6KVBor4f7Vlmr KBecnZUBvy6r7re6KqhTeVxjdgUIsDuPYcO0llt1jix4cwOGPgveI2Xo44GtNsMrpoWR6yHP pBIMWAHgCnoOnWjBH9GUPrSo8/13hETQxUAwHqJqKw+5XTkzQAZ+NAB5/KMJ7Rm7e0M9qqpj jquE1bRW3n2B/TDodaxyU9As8eU9c/NtCP+I5XjnhJiqAX7KmX+k3T6X3PjyRWyohbWt96yt yX4U8fhxEQ/3BXDczXzY/G3iFuGpzI9cdRRKMgB+AK0z6iO7QilK3dRG1ataPR+3CM3bRAO+ nKnsfbIIAQ17JClYjSc8KuOpHW+PTJTIWJqiS0sFFNDuom/5tho3lSVEr6PE4bs5jHxMRb23 zKH6gwjirMIgckR2Y23+UqBjz/ESp3hEV9kuliKBzzNAgVRPtS3aInz0gfi4NVqfL68S2Kek F0pop3LhAwJJdTX/MCXe80JAb2uz/mDLXvbm1EHN8Rwrmvy03Kud4pN7yo4K0F0dMEedlfUj FT7tQdd6ZFdOXqvdfUrbpK6TcUs0bLpU9jhTLbYY7Kif6RMSeNOxwk2DWb44ownuBJEfX0XU XtDTfuRMA== IronPort-HdrOrdr: A9a23:kJCbwKGU1KYrKMW4pLqE7ceALOsnbusQ8zAXPiFKOHlom6Oj/f xG8M536faWslcssRMb9uxoUZPoKRjhHPVOj7X5U43PYOGe01HYT71K3M/Y/xbBPGnbzMAY7p tGN4hSYeeRMbAt5vyKgjWFLw== X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos; i="5.96,202,1665439200"; d="scan'208,223"; a="79945516" From: Thread-Topic: bug#59177: [PATCH] python-protobuf: Use C++ implementation Thread-Index: AQHY9N24Ss9Kraga5EqaDUG1YLyDEq5U/283gACd0gA= Date: Tue, 29 Nov 2022 08:23:37 +0000 Message-ID: <87a64amanr.fsf@dlr.de> References: <878rkjz08w.fsf@dlr.de> <87lenu91wy.fsf@gnu.org> In-Reply-To: <87lenu91wy.fsf@gnu.org> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi Ludovic, Ludovic Courtès writes: > Impressive. It would be nice to have that info as a comment in the code > for future reference. ... > Does it really need to be propagated? Would be nice if this could be > avoided, for instance by adding a phase that hardcodes the absolute file > name of the protobuf shared library, if that’s the reason why it’s being > propagated. And if we really have to propagate it, then it’d be nice > to clarify what. WDYT? you are right, it doesn't need to be propagated, the python shared object paths look good if inputs is used instead of propagated-inputs (thanks, good to know :) $ ldd /gnu/store/r6lxp1x9lj0a4980730pyd44mcvqv8pr-python-protobuf-3.20.1/lib/python3.9/site-packages/google/protobuf/pyext/_message.cpython-39-x86_64-linux-gnu.so linux-vdso.so.1 (0x00007ffe50ba5000) libprotobuf.so.32 => /gnu/store/75d8pq1yxixr10dxfw59lv8k294nrck5-protobuf-3.21.9/lib/libprotobuf.so.32 (0x00007ffa6b600000) ... I've also added a comment in the updated patch below. Thanks & best regards, Ontje From a1f443dcf7ad1e222a9796441f6d96425dbfe787 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ontje=20L=C3=BCnsdorf?= Date: Thu, 10 Nov 2022 09:11:11 +0100 Subject: [PATCH] gnu: python-protobuf: Use C++ implementation. * gnu/packages/protobuf.scm (python-protobuf): Use C++ implementation. [inputs]: Add protobuf. [arguments]: Add --cpp_implementation configure flags. --- gnu/packages/protobuf.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/protobuf.scm b/gnu/packages/protobuf.scm index f7184bd49a..ab701b254d 100644 --- a/gnu/packages/protobuf.scm +++ b/gnu/packages/protobuf.scm @@ -406,6 +406,12 @@ (define-public python-protobuf (base32 "1ja2vpk9nklllmsirmil2s4l7ni9yfqvbvj47zz5xx17s1k1bhxd")))) (build-system python-build-system) + (inputs (list protobuf)) + (arguments + `(;; Favor C++ implementation from protobuf over the native Python + ;; implementation. The additional dependency yields significant + ;; performance improvements for some workloads. + #:configure-flags '("--cpp_implementation"))) (home-page "https://github.com/google/protobuf") (synopsis "Protocol buffers is a data interchange format") (description -- 2.38.1