diff mbox series

[bug#36300] gnu: Add emacs-gnugo.

Message ID 878stxruoo.fsf@gmail.com
State Accepted
Headers show
Series [bug#36300] gnu: Add emacs-gnugo. | expand

Checks

Context Check Description
cbaines/applying patch fail Apply failed

Commit Message

Maxim Cournoyer June 20, 2019, 12:01 a.m. UTC 
Hello!

This adds emacs-gnugo, an Emacs mode for playing GNU Go!

Enjoy,

Maxim

Comments

Ludovic Courtès June 24, 2019, 9:15 p.m. UTC | #1 
Hello Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> This adds emacs-gnugo, an Emacs mode for playing GNU Go!

The patches LGTM!  I would perhaps put emacs-gnugo in emacs-xyz.scm
rather than games.scm, but I don’t have a strong opinion.

Thanks!

Ludo’.
Maxim Cournoyer June 26, 2019, 4:08 a.m. UTC | #2 
Hello Ludovic!

Ludovic Courtès <ludo@gnu.org> writes:

> Hello Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> This adds emacs-gnugo, an Emacs mode for playing GNU Go!
>
> The patches LGTM!  I would perhaps put emacs-gnugo in emacs-xyz.scm
> rather than games.scm, but I don’t have a strong opinion.
>

Thanks for the review! I've adapted the patch with your proposed changes
and pushed to master (commit dc7c489605)

Thank you,

Maxim
Maxim Cournoyer June 26, 2019, 4:09 a.m. UTC | #3 
Hello Ludovic!

Ludovic Courtès <ludo@gnu.org> writes:

> Hello Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> This adds emacs-gnugo, an Emacs mode for playing GNU Go!
>
> The patches LGTM!  I would perhaps put emacs-gnugo in emacs-xyz.scm
> rather than games.scm, but I don’t have a strong opinion.
>

Thanks for the review! I've adapted the patch with your proposed changes
and pushed to master (commit dc7c489605)

Thank you,

Maxim
diff mbox series

Patch

From d6ef391bccbeb398836b7dead18c1c284b26dec1 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Thu, 20 Jun 2019 08:58:47 +0900
Subject: [PATCH 3/3] gnu: Add emacs-gnugo.

* gnu/packages/games.scm (emacs-gnugo): New variable.
---
 gnu/packages/games.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 202221a987..273ef05319 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -40,6 +40,7 @@ 
 ;;; Copyright © 2019 Oleg Pykhalov <go.wigust@gmail.com>
 ;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
 ;;; Copyright © 2019 Julien Lepiller <julien@lepiller.eu>
+;;; Copyright © 2019 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -86,6 +87,7 @@ 
   #:use-module (gnu packages cyrus-sasl)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages docbook)
+  #:use-module (gnu packages emacs-xyz)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages fltk)
   #:use-module (gnu packages fonts)
@@ -159,6 +161,7 @@ 
   #:use-module (gnu packages messaging)
   #:use-module (gnu packages networking)
   #:use-module (guix build-system glib-or-gtk)
+  #:use-module (guix build-system emacs)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system go)
   #:use-module (guix build-system meson)
@@ -2087,6 +2090,37 @@  Protocol).")
     (home-page "https://www.gnu.org/software/gnugo/")
     (license license:gpl3+)))
 
+(define-public emacs-gnugo
+  (package
+    (name "emacs-gnugo")
+    (version "3.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://elpa.gnu.org/packages/gnugo-"
+                           version ".tar"))
+       (sha256
+        (base32
+         "0xpjvs250gg71qwapdsb1hlc61gs0gpkjds01srf784fvyxx2gf1"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'configure-default-gnugo-xpms-variable
+                    (lambda _
+                      (substitute* "gnugo.el"
+                        (("defvar gnugo-xpms nil")
+                         "defvar gnugo-xpms #'gnugo-imgen-create-xpms"))
+                      #t)))))
+    (propagated-inputs
+     `(("emacs-ascii-art-to-unicode" ,emacs-ascii-art-to-unicode)
+       ("emacs-xpm" ,emacs-xpm)))
+    (home-page "https://elpa.gnu.org/packages/gnugo.html")
+    (synopsis "Emacs major mode for playing GNU Go")
+    (description "This package provides an Emacs based interface for GNU Go.
+It has a graphical mode where the board and stones are drawn using XPM images
+and supports the use of a mouse.")
+    (license license:gpl3+)))
+
 (define-public extremetuxracer
   (package
     (name "extremetuxracer")
-- 
2.21.0