From patchwork Tue Mar 17 13:37:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Nicol=C3=B2_Balzarotti?= X-Patchwork-Id: 20732 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 161A427BBEA; Tue, 17 Mar 2020 13:39:11 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 9E76A27BBE4 for ; Tue, 17 Mar 2020 13:39:10 +0000 (GMT) Received: from localhost ([::1]:32988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jECR4-0000k8-4E for patchwork@mira.cbaines.net; Tue, 17 Mar 2020 09:39:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46322) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jECQx-0000jo-6M for guix-patches@gnu.org; Tue, 17 Mar 2020 09:39:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jECQw-0006oq-46 for guix-patches@gnu.org; Tue, 17 Mar 2020 09:39:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jECQv-0006lo-VN for guix-patches@gnu.org; Tue, 17 Mar 2020 09:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jECQv-0006qh-R5 for guix-patches@gnu.org; Tue, 17 Mar 2020 09:39:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#38546] [PATCH v5] Julia: Update to 1.3.1 Resent-From: =?utf-8?q?Nicol=C3=B2?= Balzarotti Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Mar 2020 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38546 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , Efraim Flashner Cc: 38546@debbugs.gnu.org, zimoun Received: via spool by 38546-submit@debbugs.gnu.org id=B38546.158445228626252 (code B ref 38546); Tue, 17 Mar 2020 13:39:01 +0000 Received: (at 38546) by debbugs.gnu.org; 17 Mar 2020 13:38:06 +0000 Received: from localhost ([127.0.0.1]:38293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jECQ1-0006pM-RM for submit@debbugs.gnu.org; Tue, 17 Mar 2020 09:38:06 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jECQ0-0006os-59 for 38546@debbugs.gnu.org; Tue, 17 Mar 2020 09:38:04 -0400 Received: by mail-wr1-f65.google.com with SMTP id a25so25726587wrd.0 for <38546@debbugs.gnu.org>; Tue, 17 Mar 2020 06:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=sXrWjzusI8PdwDmULu6VB5NyjufGQszky2oM+1aE1RU=; b=USMrOXplh71JsdLeOsznhLRsx1QZ76WjXS0aUnymaeegy1vOnsJbxAZ7jepYNnsFjy Ze2D7wmD60+uFKOOkW+/IEFV1cTIyyKwuvQoYFymha2pNbxgcYKCMl/sK1CZ1dUvseSw qhRvdtLZnUBy+6kguPiLfhc6r79rxaTV8Dic0WCZtq28Tr4v1wFF8b6uNXRd90oSi9wO xbO0DZcS2yc0JTg4jfBq7T5onNRCDm/MuFAK9h4Athj+pFVvCaue7ToB+7L9ME8dv2/V Ya8UHy159LLq/VvehbP85egzfzlPlt2dGvuMpjMXjjK8jicRiTn9Hp4zyHXAv0VREGPX Vrfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=sXrWjzusI8PdwDmULu6VB5NyjufGQszky2oM+1aE1RU=; b=fFK+16ZgksupNWEeJfvkK4TDIHYWl6IK8bV98eAzorIAQO0d7uNhRKyUWjt+MJIuqU hHNDgiKwKn0ooku45z5o/jzZHWaxxv2gW8AAbkEZN4Li1CdUk3vCMghuwdEtZCHPtlId fALdgL4g6ymQkqt7fNvVyliWEma5YKzGt8JBuP7bl2Hr30wWlJ09qm0suEuBTtjCOpR8 riofubaazYen3Oo13rL1yk/cTNyV1eY9+Vu+5ECVzFXxxgrG8Qz0fSy2jSXQzHSu9+2s vejvx+a4tRsuJNoEmLmCm305M2FYnmQYWH526ph7qbEgOA8vURMWJS8Fh2aVjWnbShka Lt9A== X-Gm-Message-State: ANhLgQ1rzUwThGTq/Ep5JK716rJkF5LOOFyTM/uw13Z9h6gJELd7Sr+5 XGktNYkKi7RZAFqs0RWZHvA= X-Google-Smtp-Source: ADFU+vs/SFWWwff2T1emdgfIrqKKlu3WLH9gcsL1rVaQekROJj7zUpfGbSUfEBsoozxNCyc9hNMTAQ== X-Received: by 2002:adf:83c4:: with SMTP id 62mr6519245wre.105.1584452278259; Tue, 17 Mar 2020 06:37:58 -0700 (PDT) Received: from guixSD (host241-136-dynamic.40-79-r.retail.telecomitalia.it. [79.40.136.241]) by smtp.gmail.com with ESMTPSA id s131sm4048853wmf.35.2020.03.17.06.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 06:37:57 -0700 (PDT) From: =?utf-8?q?Nicol=C3=B2?= Balzarotti In-Reply-To: <87zhcfb29s.fsf@devup.no> References: <87imjvwvjx.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87fteywndk.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87blplwmuk.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <20200316100641.GK927@E5400> <87fte7772m.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <20200317081210.GN927@E5400> <87zhcfb29s.fsf@devup.no> Date: Tue, 17 Mar 2020 14:37:53 +0100 Message-ID: <878sjz6r0u.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, I looked at it. THe patch is literally a one-line change[1] they make to support RFC 3986. According to [2], the patch has been ported to fedora http-parser. Our version is different form the one bundled in libgit2, but deleting the corresponding line (see snippet) libgit2 tests are now passing. However, this http-parser test is failing: *** http_parser_parse_url("http://hostname:/") "proxy empty port" test failed, unexpected rv 0 *** I opened an issue upstream here [3] so that if they fix it we can continue unbundling it without having to patch it ourselves. Hope they decide to upstream it I'll send updates if there are news on the issue, thanks, Nicolò. #+name: http-parser.patch #+begin_src diff #+end_src [1] https://github.com/libgit2/libgit2/commit/1bbdec69bef50208f77f0c4cbac7c6b56c35973f.patch [2] https://github.com/libgit2/libgit2/issues/5436#issuecomment-593773122 [3] https://github.com/nodejs/http-parser/issues/501 Marius Bakke writes: > Efraim Flashner writes: > >>> In the meanwhile, reding arch bug-tracker [2] I saw that libgit2 depends >>> on http-parser (USE_HTTP_PARSER). Should we unbundle it from git? >> >> That sounds like a separate issue, but a good idea. > > We used to unbundle it up until libgit2 0.99.0, because the release > notes said that their fork is incompatible with the released version of > http-parser. > > We should look into what the compatibility issues are before unbundling > it again. Maybe it's not relevant for Guix. diff -u a/http_parser.c b/http_parser.c --- a/http_parser.c 2020-03-17 14:05:53.542832960 +0100 +++ b/http_parser.c 2020-03-17 14:05:21.810382406 +0100 @@ -2394,7 +2394,6 @@ case s_http_host_v6_zone_start: case s_http_host_v6_zone: - case s_http_host_port_start: case s_http_userinfo: case s_http_userinfo_start: return 1; default: