Message ID | 878rkjz08w.fsf@dlr.de |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1982B27BBEB; Thu, 10 Nov 2022 16:51:32 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D915E27BBEA for <patchwork@mira.cbaines.net>; Thu, 10 Nov 2022 16:51:30 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1otAle-000471-Fn; Thu, 10 Nov 2022 11:51:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1otAlb-0003xh-Pj for guix-patches@gnu.org; Thu, 10 Nov 2022 11:51:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1otAlb-0001hU-G9 for guix-patches@gnu.org; Thu, 10 Nov 2022 11:51:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1otAlb-0003x3-9l for guix-patches@gnu.org; Thu, 10 Nov 2022 11:51:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59177] [PATCH] python-protobuf: Use C++ implementation Resent-From: <Ontje.Luensdorf@dlr.de> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Nov 2022 16:51:03 +0000 Resent-Message-ID: <handler.59177.B.166809905515132@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59177 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59177@debbugs.gnu.org X-Debbugs-Original-To: <guix-patches@gnu.org> Received: via spool by submit@debbugs.gnu.org id=B.166809905515132 (code B ref -1); Thu, 10 Nov 2022 16:51:03 +0000 Received: (at submit) by debbugs.gnu.org; 10 Nov 2022 16:50:55 +0000 Received: from localhost ([127.0.0.1]:44171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1otAlS-0003vu-S0 for submit@debbugs.gnu.org; Thu, 10 Nov 2022 11:50:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:50566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <Ontje.Luensdorf@dlr.de>) id 1ot2qe-0002YO-JN for submit@debbugs.gnu.org; Thu, 10 Nov 2022 03:23:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Ontje.Luensdorf@dlr.de>) id 1ot2qd-0006Qs-Pi for guix-patches@gnu.org; Thu, 10 Nov 2022 03:23:44 -0500 Received: from mailin.dlr.de ([194.94.201.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Ontje.Luensdorf@dlr.de>) id 1ot2qa-0005eB-FS for guix-patches@gnu.org; Thu, 10 Nov 2022 03:23:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dlr.de; i=@dlr.de; q=dns/txt; s=052022; t=1668068620; x=1699604620; h=from:to:subject:date:message-id:mime-version; bh=+3odGvbGhbaK28I3t0sptHqiHc06z6HDiDS9rLsd0k8=; b=swGw0RmSzlCstVsl56PA1wDqveP2wEE+TW2At5cSAAlD9gw5KB5ouiLs Xm2693H5l6BVWEAfGmYlWUB4OhYlhGeCXcY3wWFyia7XZSJIHrqzE/lfL fBCmdMHZp5H/ssTtP4TUJ9l4FSP0z6r+H24TYqv1mGNDJZh6tihrsbpQS mNQ1oxOR7nNhtpy2zHZAVdBuqlsChMX25mhuKKWSyoXd/AgzE/tGcA9J/ EwAyoiKcIwJdAOWiRPHzTCQ4+4tSsTl4nyABw+cpH0Sgl5cWS4fL0JBHZ 92HHPDNpHpem4E/fHNrGaNmn+aZQks7PAK5QIhXtWXp1yrUUotwAmyNeF w==; X-IPAS-Result: A2EiAwB5s2xj/xaKuApaHgEBCxIMQIFEC4MtAoFYF7MEgX4IBwEBAQEBAQEBAQgBNQ8EAQGFBYR+JjQJDgECBAEBAQEDAgMBAQEBAQEDAQEGAQEBAQEBBgQBAQKBGIUvOQ2CNSKCBAEBAQEBAQEBAQEBAQEcAg1SZgGBEQEZAwECCicNASIdCgQTDoJwgyETrAp4gTSBAYRwnD0KBoFAk1yEfYJiAoF3CS2FcQSBB4MOimODEoYGA0QdNgoDC20NSRsxJw4JHxwlDQUGEgMgbgVBDygvZyscGweBDCooFQMEBAMCBhMDIgINKTEUBCkTDSsnbwkCAyJqAwMEKCwDCSEfByckPAdXOgUDAhAiOgYDCQMCJFWBJCYFAw0XJQgFTQQIOQUGUhICChEDEg8sRw5KPjkWBid4Dg4UA16BawRiOpoagSlzgQ4slTqNboF5D598B4Ieh2yFLZU5lnuSGQGXM4puglWaDAIEAgQFAhaBYnaBIHFPgmdSFwIPkhKKXnU7AgcLAQEDCYZHgwyBEgEB IronPort-PHdr: A9a23:aSbOhx+PdxCs8/9uWcC8ngc9DxPPW53KNwIYoqAql6hJOvz6uci4Y AqEvr401Q+BHd2Cra4e0KyO6+GocFdDyK7JiGoFfp1IWk1NouQttCtkPvS4D1bmJuXhdS0wE ZcKflZk+3amLRodQ56mNBXdrXKo8DEdBAj0OxZrKeTpAI7SiNm82/yv95HJbAhEmjWwbal8I Ri4ogndq9QajIh/Iao11hfFv2FEdutIyW5mP16fgwrw6sKt95N/7ipcvO4s+dRdWqvgZaQ4S rJYDDUiM28r4cDgqAfOQwiS6HYCS2saihVHDRTL4xH8RZfxrzD1tvFh1ymAPM35Vq47VDK/5 Kp2UhDoiSMHNzkk8GHLj8F7kaxWrA69qxF53oXZZpyeOvhjcaPHZd4URXRPUNtNVyJPAY28b pcAAOUaMOZds4XwvUEDoQeiCQWxAu7k1z9GhmXx3a0/y+ksFhjI3Ao8H9IMrnvYttP7NLoMX uCz16nH0DLDb+lY2Trm9YfIdgohreuRUr1uaMfcz1QkGAzZgFuKs4PlIy+V2foXs2id9+dtV eOihmw5pwxxvzWi2tohh4rKi4waxF3K+jh1zYI3KNC5VkN1b8CoHpVRui2ENIZ6XN8uT31mt isn1LEKpZq2cS4Xw5ok3x7Sc+GLf5SS7h7+V+ucLi10iG9rdb+8nRq+71asxvXhWsWoylpGs ylIn9bWunwQ2RHe6dKLRuV980qu3zuEyhrd5fteIU8ukKrWM5shwrktmZUNqUnDBSr2mFnuj K+Ra0Uk5vCk6+T5bbXioZ+RL4F6hAfwPKohmsKxAeM2PAsJUWaB5+iwyrLt8kznTblQj/02l LXZsIrAKsgBu6G5BxVV3pw+5BmhFzum0dIYkmcbLF9dZR6Lk5LlN0zNLf33F/uznlqhnTRxy /zYILHtGpDNIWLCkLflc7Z98UlcyA8rwN5G4ZJUFrMBL+zpVkH3qdzXEBk5MxepzObgEtV92 JgTVn+LAq+DKq/drEGH6vopI+aXfIAVoiryK+A55/7yin80gUIRcbGz3ZQLcHC4AuhmI0KBb Hrjn9cBEGgLshMmTOPwlF2NTT5TaGipX68n6TE7Dp+mAZ3ERoC3j7zSlBu8S8lZe2FWT0iFD Xzoep6sVPERLiWILZkyvCYDUO31bIk91xzokBL3zaFrKfDa0iEcr9Tv2Y4mtKXoiRgu+GksX Iym2GaXQjQs9l4= IronPort-Data: A9a23:xuRAe6wdikjZmspnvWB6t+e8xyrEfRIJ4+MujC+fZmQN5Upmgn1D0 SoCGTjCaae61lCFe9l2aZDhqw8b+d+Rlok9VUIu8m1qRW9E7PfeCJGya0b1JyefK8DFUEt77 sIYLMHJMMs0JpO3jkygbuProCIthfqCTeqsV7GbNnp/SAY7RHks10I8keVj3tE234PkDgmHt IKp/JaBaAKr1WItPzoYs/7YpBkzt/2aVF/0xrAbTakjUAj2ziBNXPrzXJ2ZL2fkWpIGWam1R vrD0bv/9WTcuBgqDdyhn/HjaEoWRbTPM2CyZgFtt96fbmJq/WpuupsGCcfwSXu7qh2Cwo4hm dtD6pG7Fg4jMqSUxLpHXRcJSip3ZvZIqOaaelGy4JeZp6Hkn9oA4BnM4GUeZ9BwFjNfWDkWn RAgAGlRKErF3opa+ZrjIsF0nMMvMcL3C40Wv3Bk3FnxAO0vKXz5a/yiCeRwgXFh2KiiId6EP 5BDMGM2NEyZC/FyEg5/5KwWzb/AakbXLmUwRGK9/cIf/2XVxQpt57nhWPK9lguiHJg9cu6w/ woqzkyhav0oHIX3JQmtrhpAstTycRbTA+r+IlEZGslC2zV/zkRLYPEfuMDSTfOR0iZSUPoHQ 6AYF7ZHQQHfOyVHQ/GkNyBUrkJosTY7Y/9LL/M/6Tis7aXfyh6oBWgWaBloPYlOWM8eHVTG1 3elu//EKxJKkZitEyiwxpzSrDWuIyFTIWsYIyMJJecHy4C75thj0lSWFYYlSvTdYt7dQFkcx xitqjQ8ivM3kMMNzKm8517vjza24JTEJuIwzlqGADj/sl0jDGKjT7yt5ED+0O1qF4mAFWSjk kUdlsSHz9lbWPlhkwTIGo3hBoqB6OuEIHjEiEJkH5Q63zur5jikZ4843d1lDEttPssKdzroZ VeJ4w5B79lSOmewZOl7Z5j3B8lCIbXcKOkJn8v8NrJmCqWdvifdlM2yTSZ8B1zQrXU= IronPort-HdrOrdr: A9a23:yViJDa39uZVKcv2lK+8zRQqjBHkkLtp133Aq2lEZdPUCSL39qy nOpoV46faaslwssR0b9OxofZPvfZq+z+8X3WByB9iftVLdyQyVxehZhOOI/9D5IVyGygce78 ZdmsBFebvN5DNB7foSjjPVLz7sreP3lZxBT4/lvg9QpcIDUdAa0+8CYDzrb3GfH2N9dOYE/F /13Ls8m9JlEU5nEfhSwRE+Lpb+m+E= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos; i="5.96,153,1665439200"; d="scan'208,223"; a="79622462" From: <Ontje.Luensdorf@dlr.de> Thread-Topic: [PATCH] python-protobuf: Use C++ implementation Thread-Index: AQHY9N24Ss9Kraga5EqaDUG1YLyDEg== Date: Thu, 10 Nov 2022 08:23:34 +0000 Message-ID: <878rkjz08w.fsf@dlr.de> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-tm-snts-smtp: B4CE39206E05D9FED5ACBF58057C6E2F311D6C9E293DDF8B71155F661CDC722D2000:8 Content-Type: multipart/mixed; boundary="_002_878rkjz08wfsfdlrde_" MIME-Version: 1.0 Received-SPF: pass client-ip=194.94.201.12; envelope-from=Ontje.Luensdorf@dlr.de; helo=mailin.dlr.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 10 Nov 2022 11:50:46 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#59177] python-protobuf: Use C++ implementation
|
|
Commit Message
Ontje.Luensdorf@dlr.de
Nov. 10, 2022, 8:23 a.m. UTC
Hi Guix, this patch configures python-protobuf to use the C++ protobuf implementation. This additional dependency pays off with a 10x performance improvement in some of my workloads. Best regards, Ontje
Comments
Hi, <Ontje.Luensdorf@dlr.de> skribis: > this patch configures python-protobuf to use the C++ protobuf > implementation. This additional dependency pays off with a 10x > performance improvement in some of my workloads. Impressive. It would be nice to have that info as a comment in the code for future reference. > From f2675cccf54d2bb1291ba1614ca44966730734e1 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Ontje=20L=C3=BCnsdorf?= <ontje.luensdorf@dlr.de> > Date: Thu, 10 Nov 2022 09:11:11 +0100 > Subject: [PATCH] gnu: python-protobuf: Use C++ implementation. > > * gnu/packages/protobuf.scm (python-protobuf): Use C++ implementation. > [propagated-inputs]: Add protobuf. > [arguments]: Add --cpp_implementation configure flags. > --- > gnu/packages/protobuf.scm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gnu/packages/protobuf.scm b/gnu/packages/protobuf.scm > index 1448691a42..9be35783fb 100644 > --- a/gnu/packages/protobuf.scm > +++ b/gnu/packages/protobuf.scm > @@ -393,6 +393,9 @@ (define-public python-protobuf > (base32 > "1ja2vpk9nklllmsirmil2s4l7ni9yfqvbvj47zz5xx17s1k1bhxd")))) > (build-system python-build-system) > + (propagated-inputs (list protobuf)) Does it really need to be propagated? Would be nice if this could be avoided, for instance by adding a phase that hardcodes the absolute file name of the protobuf shared library, if that’s the reason why it’s being propagated. And if we really have to propagate it, then it’d be nice to clarify what. WDYT? Thanks, Ludo’.
From f2675cccf54d2bb1291ba1614ca44966730734e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ontje=20L=C3=BCnsdorf?= <ontje.luensdorf@dlr.de> Date: Thu, 10 Nov 2022 09:11:11 +0100 Subject: [PATCH] gnu: python-protobuf: Use C++ implementation. * gnu/packages/protobuf.scm (python-protobuf): Use C++ implementation. [propagated-inputs]: Add protobuf. [arguments]: Add --cpp_implementation configure flags. --- gnu/packages/protobuf.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnu/packages/protobuf.scm b/gnu/packages/protobuf.scm index 1448691a42..9be35783fb 100644 --- a/gnu/packages/protobuf.scm +++ b/gnu/packages/protobuf.scm @@ -393,6 +393,9 @@ (define-public python-protobuf (base32 "1ja2vpk9nklllmsirmil2s4l7ni9yfqvbvj47zz5xx17s1k1bhxd")))) (build-system python-build-system) + (propagated-inputs (list protobuf)) + (arguments + `(#:configure-flags '("--cpp_implementation"))) (home-page "https://github.com/google/protobuf") (synopsis "Protocol buffers is a data interchange format") (description -- 2.38.1