From patchwork Mon Sep 16 20:13:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 67995 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id CD19B27BBE9; Mon, 16 Sep 2024 21:15:10 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5DE6927BBE2 for ; Mon, 16 Sep 2024 21:15:09 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqI7W-0003eK-GT; Mon, 16 Sep 2024 16:14:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqI7U-0003dd-KP for guix-patches@gnu.org; Mon, 16 Sep 2024 16:14:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqI7U-0003ER-9d for guix-patches@gnu.org; Mon, 16 Sep 2024 16:14:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=+gRLLd2Hjt/GqtC3k/eQp2k0715Zpa+toi0Eh9pZWRw=; b=ilxKRszNary6ygquXd5JgyU1Jk+EV9QiSjqW1vXnuNSLznEWo0xgZtjhqrdCC7+zfw4ufrsg+ZRhRQ4Q1fT2VrZGRWMhkasmsC6OitKl2grVv00htLBDFB/nvyL03JeRvDBBByajLYTV7IVr8XFpISDIDnhvGmPKTERY8iqd8kHEHR0yGALGuvRUKO1NYkQmp7udX2UG5eCQL8uaiNLHW631uxXrnDexEnCanMGYvnVl48xtwMGFsRu3u3+HsG3qPQUA6Hjp7XCQZiprwmdVMmgO/MvHomIsRcTmPy6qUA+DksTdyCEXnTXOI1068FdIOwDngKArs8LG27jiCm6+WQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqI7h-0005mj-Ul for guix-patches@gnu.org; Mon, 16 Sep 2024 16:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73073] [PATCH 0/6] Allow origin with label as inputs. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Sep 2024 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73073 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: maxim.cournoyer@gmail.com, 73073@debbugs.gnu.org Received: via spool by 73073-submit@debbugs.gnu.org id=B73073.172651764722121 (code B ref 73073); Mon, 16 Sep 2024 20:15:01 +0000 Received: (at 73073) by debbugs.gnu.org; 16 Sep 2024 20:14:07 +0000 Received: from localhost ([127.0.0.1]:53387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI6p-0005ki-8m for submit@debbugs.gnu.org; Mon, 16 Sep 2024 16:14:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqI6n-0005k3-Tm for 73073@debbugs.gnu.org; Mon, 16 Sep 2024 16:14:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqI6T-0002sf-Sa; Mon, 16 Sep 2024 16:13:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=+gRLLd2Hjt/GqtC3k/eQp2k0715Zpa+toi0Eh9pZWRw=; b=JjJ3Pf3BFwCvHUg3kqo2 krCEeA4D92DEsTaJFRCDYzVcMjtMuAtPGDFU1fvLVDRqH1kDHqGaGYyw6BZ0BxI5xgA2lOH4qxoMi Vzhz8Slj+Ngvpjr8kJqLXpCgaaw0uYxIEVjEGBqu8ryKEXV6Lk+B6VfMaJ3niPMvTlJOgDYZX4Qq3 vCW+2vtE0Y3vdoA5QxnH9LCDU1iw6o7lfJ5R7Pu1RxsuFp9TrF1lbMspUocfZ/UDWxAV7S61pu9Po yUgLrzFRLwTUKipHxGVlEj0JPXzxmBk4QPg8F77E6rxf198NygzonQjB0Iq9xQRxc5l6VaTXVecES jk5AXYE/z/RKOQ==; From: Ludovic =?utf-8?q?Court=C3=A8s?= In-Reply-To: <875xr7r38x.fsf@gmail.com> (Simon Tournier's message of "Sat, 07 Sep 2024 15:40:30 +0200") References: <87o750wj6n.fsf@gnu.org> <875xr7r38x.fsf@gmail.com> Date: Mon, 16 Sep 2024 22:13:24 +0200 Message-ID: <878qvrbbmj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi, Simon Tournier skribis: > This solution appears to me the best approach. Somehow, it uses > ’file-name’ as internal “label”. When internal “labels” will completely > removed, e.g., using package name or else, we will adapt. > > Well, ’origin-actual-file-name’ returns for example > "libgd-2.0.4-checkout", i.e. the version would be required when calling > ’this-package-input’. Therefore, it would mean something like: > > #$(this-package-native-input (git-file-name "libgd" version)) > > This appears to me a good solution. Yes, agreed. > However, how is it possible to avoid a full rebuild because ’tzdata’ or > else? It means the package definition cannot be modified, right? When I looked the other day I came up with this: Of course this is ugly, but it’s IMO okay if we only have to do it for a few packages (and for a limited amount of time). Thanks, Ludo’. modified gnu/packages/base.scm @@ -1716,14 +1716,15 @@ (define-public tzdata (delete-file-recursively (string-append out "/share/zoneinfo-leaps"))))) (delete 'configure)))) - (inputs (list (origin - (method url-fetch) - (uri (string-append - "https://data.iana.org/time-zones/releases/tzcode" - version ".tar.gz")) - (sha256 - (base32 - "07hn7hn2klw4dfyr673ril2nrk18198hbfv25gljsvc833hzk9g9"))))) + (inputs `(("_" ;<- avoid a rebuild + ,(origin + (method url-fetch) + (uri (string-append + "https://data.iana.org/time-zones/releases/tzcode" + version ".tar.gz")) + (sha256 + (base32 + "07hn7hn2klw4dfyr673ril2nrk18198hbfv25gljsvc833hzk9g9")))))) (home-page "https://www.iana.org/time-zones") (synopsis "Database of current and historical time zones")