diff mbox series

[bug#74755] etc/git/pre-push: Run guix git authenticate before check-channel-news

Message ID 878qsovc1t.fsf@wireframe
State New
Headers
Series [bug#74755] etc/git/pre-push: Run guix git authenticate before check-channel-news |

Commit Message

Vagrant Cascadian Dec. 9, 2024, 8:25 p.m. UTC 
  Running check-channel-news before authenticating the repository could
result in running unauthenticated code; the attached patch switches the
order they are run in.

live well,
  vagrant

Comments

Ludovic Courtès Dec. 24, 2024, 2:41 p.m. UTC | #1 
Hi,

Vagrant Cascadian <vagrant@debian.org> skribis:

> From 42bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant@debian.org>
> Date: Mon, 9 Dec 2024 12:21:30 -0800
> Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before
>  check-channel-news.
>
> Running check-channel-news first could potentially be untrusted code, so
> authenticate first.
>
> * etc/git/pre-push: Run guix git authenticate before check-channel-news.

LGTM, thanks!

Ludo’.
Vagrant Cascadian Jan. 5, 2025, 9:25 p.m. UTC | #2 
On 2024-12-24, Ludovic Courtès wrote:
> Vagrant Cascadian <vagrant@debian.org> skribis:
>> From 42bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001
>> From: Vagrant Cascadian <vagrant@debian.org>
>> Date: Mon, 9 Dec 2024 12:21:30 -0800
>> Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before
>>  check-channel-news.
>>
>> Running check-channel-news first could potentially be untrusted code, so
>> authenticate first.
>>
>> * etc/git/pre-push: Run guix git authenticate before check-channel-news.
>
> LGTM, thanks!

Pushed as:

ab9cda9ebd00073d5a0783919809f2e564f141e9 etc: git: pre-push: Run guix git authenticate before check-channel-news.

live well,
  vagrant
diff mbox series

Patch

From 42bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@debian.org>
Date: Mon, 9 Dec 2024 12:21:30 -0800
Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before
 check-channel-news.

Running check-channel-news first could potentially be untrusted code, so
authenticate first.

* etc/git/pre-push: Run guix git authenticate before check-channel-news.
---
 etc/git/pre-push | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/git/pre-push b/etc/git/pre-push
index 325b23854b..752310d854 100755
--- a/etc/git/pre-push
+++ b/etc/git/pre-push
@@ -33,8 +33,8 @@  do
 		case "$2" in
 		    *.gnu.org*)
 			set -e
-			make check-channel-news
 			exec guix git authenticate
+			make check-channel-news
 			exit 127
 			;;
 		    *)

base-commit: da3c8a963f83c044568d99921480259eaa26a923
-- 
2.39.5