[bug#52275] gnu: syncthing: Update to 1.18.4.

* gnu/packages/syncthing.scm (syncthing): Update to 1.18.4.
---
 gnu/packages/syncthing.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)


base-commit: 85ed37c170756bac78e4fd7fd83adba7e9537030
--
2.34.0

On Sat, Dec 04, 2021 at 12:51:36PM +0100, simendsjo wrote:
> * gnu/packages/syncthing.scm (syncthing): Update to 1.18.4.
> +       ;; Running tests currently fails. Get the message
> +       ;; vendor/github.com/lucas-clemente/quic-go/internal/qerr/error_codes.go:6:2: build constraints exclude all Go files in /tmp/guix-build-syncthing-1.18.4.drv-0/src/github.com/syncthing/syncthing/vendor/github.com/lucas-clemente/quic-go/internal/qtls
> +       ;; followed by two lines of `exit status 1`.
> +       ;; Running on a non-guix has the same problem as for guix, but the tests runs.
> +       ;; We disable the tests for now
> +       #:tests? #f

Thanks for the patches!

Do you know what's wrong here? I think that we should at least
understand it before pushing an upgrade that doesn't pass its tests.

I tried building the entire 1.18 release series, and 1.18.0 does build
and pass its tests for me on x86_64. But I suppose there were good
reasons to make 4 minor releases since 1.18.0.

On Sun, Dec 05, 2021 at 12:44:20AM -0500, Leo Famulari wrote:
> Do you know what's wrong here? I think that we should at least
> understand it before pushing an upgrade that doesn't pass its tests.

I looked it up. Between 1.18.1 and 1.18.2, Syncthing's "build
constraints" were updated to "Go 1.17 style":

https://github.com/syncthing/syncthing/commit/d47745a86b00fe1122d8ebd5e17601aa1b7552b2

So, we can at least get 1.18.1 until we update our Go compiler. There
are pending patches to use 1.17.

1.18.1 does build and pass its tests for me.

Great! As 1.16.1 is broken due to this bug: https://github.com/syncthing/syncthing/issues/7685
I updated the patch to 1.18.1, but should we rather use 1.17.0 you think?

Leo Famulari <leo@famulari.name> writes:

> On Sun, Dec 05, 2021 at 12:44:20AM -0500, Leo Famulari wrote:
>> Do you know what's wrong here? I think that we should at least
>> understand it before pushing an upgrade that doesn't pass its tests.
>
> I looked it up. Between 1.18.1 and 1.18.2, Syncthing's "build
> constraints" were updated to "Go 1.17 style":
>
> https://github.com/syncthing/syncthing/commit/d47745a86b00fe1122d8ebd5e17601aa1b7552b2
>
> So, we can at least get 1.18.1 until we update our Go compiler. There
> are pending patches to use 1.17.
>
> 1.18.1 does build and pass its tests for me.

On Sun, Dec 5, 2021, at 03:54, Simen Endsjø wrote:
> Great! As 1.16.1 is broken due to this bug: 
> https://github.com/syncthing/syncthing/issues/7685

Broken somewhat... It works quite well in general :) The CLI is rather new and untested compared to the GUI / web API.

> I updated the patch to 1.18.1, but should we rather use 1.17.0 you 
> think?

Can you clarify why we might choose Syncthing 1.17.0 if we could use 1.18.1? Or did you mean Go 1.17?

"Leo Famulari" <leo@famulari.name> writes:

> On Sun, Dec 5, 2021, at 03:54, Simen Endsjø wrote:
>> Great! As 1.16.1 is broken due to this bug:
>> https://github.com/syncthing/syncthing/issues/7685
>
> Broken somewhat... It works quite well in general :) The CLI is rather new and untested compared to the GUI / web API.

I'm trying to run it from a server, and would like to avoid exposing a
web API.

>> I updated the patch to 1.18.1, but should we rather use 1.17.0 you
>> think?
>
> Can you clarify why we might choose Syncthing 1.17.0 if we could use 1.18.1? Or did you mean Go 1.17?

1.17.0 doesn't include any later patch versions, and might be more
stabel. Haven't looked at the issues closed 1.18.2-4, so it might be a
non-issue. I have very simple use, I just need something other than
1.16.1 as I cannot add devices with that version.

I've actually been running 1.18.4 for some time noo, without issues. Just skipping the tests makes it work, so why not? If this is a problem, I think 1.18.1 is better unless there is an important bug in it.

Le 6 décembre 2021 03:15:51 GMT-05:00, "Simen Endsjø" <simendsjo@gmail.com> a écrit :
>
>"Leo Famulari" <leo@famulari.name> writes:
>
>> On Sun, Dec 5, 2021, at 03:54, Simen Endsjø wrote:
>>> Great! As 1.16.1 is broken due to this bug:
>>> https://github.com/syncthing/syncthing/issues/7685
>>
>> Broken somewhat... It works quite well in general :) The CLI is rather new and untested compared to the GUI / web API.
>
>I'm trying to run it from a server, and would like to avoid exposing a
>web API.
>
>>> I updated the patch to 1.18.1, but should we rather use 1.17.0 you
>>> think?
>>
>> Can you clarify why we might choose Syncthing 1.17.0 if we could use 1.18.1? Or did you mean Go 1.17?
>
>1.17.0 doesn't include any later patch versions, and might be more
>stabel. Haven't looked at the issues closed 1.18.2-4, so it might be a
>non-issue. I have very simple use, I just need something other than
>1.16.1 as I cannot add devices with that version.
>
>
>

I pushed 4e282bc934488b1c9ab9e97c838efe058da9e0bd, which updates
Syncthing to 1.18.4 and builds it with Go 1.17. I did this because
Syncthing assumes that one is building with Go 1.17, based on the
changes in Syncthing 1.18.2.

I'll test the update of the Go 1.17 series shortly and hopefully put Go
1.17 into use across all packages this week.

On Mon, Dec 06, 2021 at 06:47:31AM -0500, Julien Lepiller wrote:
> I've actually been running 1.18.4 for some time noo, without issues. Just skipping the tests makes it work, so why not? If this is a problem, I think 1.18.1 is better unless there is an important bug in it.
> 
> Le 6 décembre 2021 03:15:51 GMT-05:00, "Simen Endsjø" <simendsjo@gmail.com> a écrit :
> >
> >"Leo Famulari" <leo@famulari.name> writes:
> >
> >> On Sun, Dec 5, 2021, at 03:54, Simen Endsjø wrote:
> >>> Great! As 1.16.1 is broken due to this bug:
> >>> https://github.com/syncthing/syncthing/issues/7685
> >>
> >> Broken somewhat... It works quite well in general :) The CLI is rather new and untested compared to the GUI / web API.
> >
> >I'm trying to run it from a server, and would like to avoid exposing a
> >web API.
> >
> >>> I updated the patch to 1.18.1, but should we rather use 1.17.0 you
> >>> think?
> >>
> >> Can you clarify why we might choose Syncthing 1.17.0 if we could use 1.18.1? Or did you mean Go 1.17?
> >
> >1.17.0 doesn't include any later patch versions, and might be more
> >stabel. Haven't looked at the issues closed 1.18.2-4, so it might be a
> >non-issue. I have very simple use, I just need something other than
> >1.16.1 as I cannot add devices with that version.
> >
> >
> >