From patchwork Wed Jun 1 22:36:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vagrant Cascadian X-Patchwork-Id: 39713 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A2EA127BBEA; Wed, 1 Jun 2022 23:38:12 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6B3F527BBE9 for ; Wed, 1 Jun 2022 23:38:12 +0100 (BST) Received: from localhost ([::1]:34810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwWyh-0008PM-K1 for patchwork@mira.cbaines.net; Wed, 01 Jun 2022 18:38:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwWyY-0008Oy-AP for guix-patches@gnu.org; Wed, 01 Jun 2022 18:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58277) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwWyY-0001JL-1E for guix-patches@gnu.org; Wed, 01 Jun 2022 18:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nwWyX-0004xM-Su for guix-patches@gnu.org; Wed, 01 Jun 2022 18:38:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55758] reproducible builds: keyutils: avoid embedding timestamp Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Jun 2022 22:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55758 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 55758@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165412303018984 (code B ref -1); Wed, 01 Jun 2022 22:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Jun 2022 22:37:10 +0000 Received: from localhost ([127.0.0.1]:52174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwWxi-0004w7-8f for submit@debbugs.gnu.org; Wed, 01 Jun 2022 18:37:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:42300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwWxg-0004vy-JJ for submit@debbugs.gnu.org; Wed, 01 Jun 2022 18:37:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwWxg-0008MJ-DC for guix-patches@gnu.org; Wed, 01 Jun 2022 18:37:08 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:43432) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwWxe-0001FG-1B for guix-patches@gnu.org; Wed, 01 Jun 2022 18:37:07 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@aikidev.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 383AA1AA6B for ; Wed, 1 Jun 2022 15:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=reproducible-builds.org; s=1.vagrant; t=1654123024; bh=2l73EyxSpfDMuxx6UyzYtFR0VtYXTYk7016FHDbcaIk=; h=From:To:Subject:Date:From; b=jeM/70fHvY4oXrdTSPb/Ir2APA50jT3e2EOU3QIAI299sy6flYuIr9KM9rmLanplU dMp9vyR/DYhHuzvBGtVwQlK0heXs0J//zpS8W6xDgDZ10oFw8250CaJ0H9saILXyf5 4WXKeX8U7qYTgiGulASU1MpL3L9KABUjX9HvlDp2iFTCNBCNLJEampPcT6fJoJhZmY djlwFA3y6U+QYbPf7lUPmhOA+FIG86rZAvlqjNiJc1LczZMh+BRMwow5+V1Ie0oh5I OYN2/TWM+8PzhNo46fNxlJWBrm5COuhFBjWAd5RLl/XVXI2C0xInyK8zOfSpnqvwa4 mgy8Z5siuc0Ew== From: Vagrant Cascadian Date: Wed, 01 Jun 2022 15:36:58 -0700 Message-ID: <877d60au45.fsf@contorta> MIME-Version: 1.0 Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@reproducible-builds.org; helo=cascadia.aikidev.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches This completely removes a timestamp from the build of keyutils, following the recommendation of: https://reproducible-builds.org/docs/timestamps/ "Timestamps are best avoided" Alternately, one could hard-code a specific timestamp (e.g. 2012-04-18), or patch it to use the SOURCE_DATE_EPOCH environment variable (which might at least be acceptible to submit upstream), although since SOURCE_DATE_EPOCH is always 0 in guix, this seems a bit silly to me. :) live well, vagrant From 36888e9dc33188115142ecde9d31eb3884004940 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Wed, 1 Jun 2022 09:24:00 -0700 Subject: [PATCH 3/4] gnu: keyutils: Avoid embedding build timestamp. * gnu/packages/crypto.scm (keyutils)[arguments]: Add 'avoid-embedding-timestamp phase. --- gnu/packages/crypto.scm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm index e98d9634dc..6e4b1331e7 100644 --- a/gnu/packages/crypto.scm +++ b/gnu/packages/crypto.scm @@ -398,6 +398,11 @@ (define-public keyutils #:phases #~(modify-phases %standard-phases (delete 'configure) ; no configure script + (add-after 'unpack 'avoid-embedding-timestamp + ;; Do not embed build timestamp + (lambda _ + (substitute* "Makefile" + (("shell date") "shell true")))) (add-after 'install 'install:static (lambda _ (with-directory-excursion #$output -- 2.35.1