From patchwork Thu Jul 20 08:19:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Janneke Nieuwenhuizen X-Patchwork-Id: 51857 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C6CAF27BBE2; Thu, 20 Jul 2023 09:20:22 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 0AAF927BBE9 for ; Thu, 20 Jul 2023 09:20:19 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMOtL-0000WU-DX; Thu, 20 Jul 2023 04:20:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMOtH-0000Vr-LD for guix-patches@gnu.org; Thu, 20 Jul 2023 04:20:05 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMOtH-00029e-5K for guix-patches@gnu.org; Thu, 20 Jul 2023 04:20:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMOtG-0006Db-KO for guix-patches@gnu.org; Thu, 20 Jul 2023 04:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64711] [PATCH 37/43] gnu: glib: Disable tests for the Hurd. Resent-From: Janneke Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Jul 2023 08:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64711 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Raghav Gururajan , ludo@gnu.org, 64711@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 64711-submit@debbugs.gnu.org id=B64711.168984120123891 (code B ref 64711); Thu, 20 Jul 2023 08:20:02 +0000 Received: (at 64711) by debbugs.gnu.org; 20 Jul 2023 08:20:01 +0000 Received: from localhost ([127.0.0.1]:57631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMOtE-0006DH-FV for submit@debbugs.gnu.org; Thu, 20 Jul 2023 04:20:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMOtA-0006D0-CS for 64711@debbugs.gnu.org; Thu, 20 Jul 2023 04:19:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMOt3-0001qj-3M; Thu, 20 Jul 2023 04:19:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=UI0BhE/vjz5VirohxiKxjNnmAzJpJ4fWznISUlQz+Tw=; b=nTgSL1oTyjCV95jsygNL 0h7zKt+SBrKtBISs3v3jm7wo+ROF8jp2u/ukrgcAjZnCkoqFjuCWbMrEqVpL+/G2hNBf+T5Tr1Kd9 C4MgViO1FYyNNT00LBhowGlxFsadd80fpePMDPSjXbXkTwl+XioPouL6VrFaT76PFfdo65FKH5huK rcmHDxfvRWYI9RStNqXuWIvPdQzFThGl97ah4wxiQ+Qhv1XmO1RP9LSU88w2E/1IryUtuF84i6HdN XIVWsTZXtgFxFC/k31NBLG4zWbxR+XJUgc9IAeUoYzJb8MGYyrBIUzKTk0SrIiibxCHyAdQyvMt5V Y8OF0XiY+RfZyA==; Received: from 2a02-a462-da03-1-aeb0-2f5e-e96a-dccb.fixed6.kpn.net ([2a02:a462:da03:1:aeb0:2f5e:e96a:dccb] helo=drakenpad.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMOt2-0008Ph-Af; Thu, 20 Jul 2023 04:19:48 -0400 From: Janneke Nieuwenhuizen Organization: AvatarAcademy.nl References: <99d408f562d64c2b3744463dbdbe6c1e5bff2c69.camel@gmail.com> <87lefddvtm.fsf@gnu.org> <87o7k9t27a.fsf@gmail.com> X-Url: http://AvatarAcademy.nl Date: Thu, 20 Jul 2023 10:19:43 +0200 In-Reply-To: <87o7k9t27a.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 18 Jul 2023 16:05:45 -0400") Message-ID: <877cqvuh9c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Maxim Cournoyer writes: Hello! > Janneke Nieuwenhuizen writes: > >> Liliana Marie Prikler writes: >> >>> Am Dienstag, dem 18.07.2023 um 16:40 +0200 schrieb Janneke >>> Nieuwenhuizen: >>>> * gnu/packages/glib.scm (glib)[arguments]: When building for the >>>> Hurd, >>>> set #:tests? to #false. >> >> [..] >>>> +      #:tests? (not (target-hurd?)) >> >>>> compiled >> >>> Instead of disabling tests altogether, can we just disable those that >>> fail on the Hurd? >> >> We probably can, and I have tried to do so in most cases. However, >> identifying those tests can be quite time consuming. I'm not sure how >> many tests failed here, and note that some tests will hang or crash the >> Hurd, so if we decide to do this, I would appreciate some help :-) >> >> Ludo on the other hand, argued against having more than ~20 (IIRC) test >> exceptions and using #:tests? #f instead. >> >> My idea was to get guix to build natively, and guix pull to work. Once >> we get those to work, we can possibly look forward to more contributors >> to this. > > I agree with Liliana that it's nicer to disable just these tests that > fail, but in light of what you wrote, your approach seems reasonable. Yes, I agree that if we want to make Hurd better and enabble us to create a bug report it sure helps if we have more information. Yesterday I decided to have another look into this. I have identified 20 tests that TIMEOUT after 600s, and 37 FAIL and instead of setting #:tests? to #false, I have added them to the `disable-failing-tests' phase when building on the Hurd. See attached patch. Greetings, Janneke From e65647119e4791580ef50869d35be29d4010c6bb Mon Sep 17 00:00:00 2001 Message-Id: From: Janneke Nieuwenhuizen Date: Tue, 13 Jun 2023 10:58:03 +0200 Subject: [PATCH] gnu: glib: Disable hanging and failing tests for the Hurd. * gnu/packages/glib.scm (glib)[arguments]: When building for the Hurd, in phase `disable-failing-tests', neutralize 20 hanging tests, and 37 more failing tests. --- gnu/packages/glib.scm | 104 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 103 insertions(+), 1 deletion(-) diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm index e988e8dc87..a0b85b15d1 100644 --- a/gnu/packages/glib.scm +++ b/gnu/packages/glib.scm @@ -14,7 +14,7 @@ ;;; Copyright © 2019, 2020, 2021 Marius Bakke ;;; Copyright © 2020 Nicolò Balzarotti ;;; Copyright © 2020 Florian Pelz -;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright © 2020, 2023 Janneke Nieuwenhuizen ;;; Copyright © 2020 Arthur Margerit ;;; Copyright © 2021 Maxime Devos ;;; Copyright © 2022 Petr Hodina @@ -285,6 +285,108 @@ (define glib (string-append "//" all "\n")) (("^ g_assert_cmpfloat \\(elapsed, ==.*" all) (string-append "//" all "\n")))) + '()) + #$@(if (system-hurd?) + '((with-directory-excursion "gio/tests" + ;; TIMEOUT after 600s + (substitute* '("actions.c" + "dbus-appinfo.c" + "debugcontroller.c" + "gdbus-bz627724.c" + "gdbus-connection-slow.c" + "gdbus-exit-on-close.c" + "gdbus-export.c" + "gdbus-introspection.c" + "gdbus-method-invocation.c" + "gdbus-non-socket.c" + "gdbus-proxy-threads.c" + "gdbus-proxy-unique-name.c" + "gdbus-proxy-well-known-name.c" + "gdbus-proxy.c" + "gdbus-test-codegen.c" + "gmenumodel.c" + "gnotification.c" + "stream-rw_all.c") + (("return (g_test_run|session_bus_run)" all call) + (string-append "return 0;// " call)) + ((" (ret|rtv|result) = (g_test_run|session_bus_run)" + all var call) + (string-append " " var " = 0;// " call)) + (("[ \t]*g_test_add_func.*;") "")) + + ;; commenting-out g_assert, g_test_add_func, g_test_run + ;; does not help; special-case short-circuit. + (substitute* "gdbus-connection-loss.c" ;; TODO? + ((" gchar \\*path;.*" all) + (string-append all " return 0;\n"))) + + ;; FAIL + (substitute* '("appmonitor.c" + "async-splice-output-stream.c" + "autoptr.c" + "contexts.c" + "converter-stream.c" + "file.c" + "g-file-info.c" + "g-file.c" + "g-icon.c" + "gapplication.c" + "gdbus-connection-flush.c" + "gdbus-connection.c" + "gdbus-names.c" + "gdbus-server-auth.c" + "gsocketclient-slow.c" + "gsubprocess.c" + "io-stream.c" + "live-g-file.c" + "memory-monitor.c" + "mimeapps.c" + "network-monitor-race.c" + "network-monitor.c" + "pollable.c" + "power-profile-monitor.c" + "readwrite.c" + "resources.c" + "socket-service.c" + "socket.c" + "tls-bindings.c" + "tls-certificate.c" + "tls-database.c" + "trash.c" + "vfs.c") + (("return (g_test_run|session_bus_run)" all call) + (string-append "return 0;// " call)) + ((" (ret|rtv|result) = (g_test_run|session_bus_run)" + all var call) + (string-append " " var " = 0;// " call)) + (("[ \t]*g_test_add_func.*;") "")) + + ;; commenting-out g_test_add_func, g_test_run does + ;; not help; special-case short-circuit. + (substitute* "gsettings.c" + (("#ifdef TEST_LOCALE_PATH" all) + (string-append " return 0;\n" all))) + + ;; commenting-out g_test_add_func, ;; g_test_run does + ;; not help; special-case short-circuit. + (substitute* "proxy-test.c" + ((" gint result.*;" all) + (string-append all " return 0;\n"))) + + ;; commenting-out g_test_add_func, g_test_run + ;; does not help; special-case short-circuit. + (substitute* "volumemonitor.c" + ((" gboolean ret;" all) + (string-append all " return 0;\n")))) + + (with-directory-excursion "glib/tests" + ;; TIMEOUT after 600s + (substitute* "thread-pool.c" + (("[ \t]*g_test_add_func.*;") "")) + + ;; FAIL + (substitute* "fileutils.c" + (("[ \t]*g_test_add_func.*;") "")))) '()))) ;; Python references are not being patched in patch-phase of build, ;; despite using python-wrapper as input. So we patch them manually. base-commit: c5a189d2abdbfe4c8dfeef764e3be055948b5c91 -- 2.40.1