From patchwork Tue May 19 13:31:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Rohleder X-Patchwork-Id: 22212 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 59FBC27BBE3; Tue, 19 May 2020 14:35:00 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 1A19927BBE1 for ; Tue, 19 May 2020 14:35:00 +0100 (BST) Received: from localhost ([::1]:58782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jb2OZ-0002qD-Il for patchwork@mira.cbaines.net; Tue, 19 May 2020 09:34:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jb2Lj-00065g-8O for guix-patches@gnu.org; Tue, 19 May 2020 09:32:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38062) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jb2Li-00018l-Rh for guix-patches@gnu.org; Tue, 19 May 2020 09:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jb2Li-0000hg-Oy for guix-patches@gnu.org; Tue, 19 May 2020 09:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41327] [PATCH] gnu: Add emacs-vcsh. Resent-From: Michael Rohleder Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 May 2020 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41327 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 41327@debbugs.gnu.org Received: via spool by 41327-submit@debbugs.gnu.org id=B41327.15898950932660 (code B ref 41327); Tue, 19 May 2020 13:32:02 +0000 Received: (at 41327) by debbugs.gnu.org; 19 May 2020 13:31:33 +0000 Received: from localhost ([127.0.0.1]:49607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb2LF-0000gq-G5 for submit@debbugs.gnu.org; Tue, 19 May 2020 09:31:33 -0400 Received: from wp224.webpack.hosteurope.de ([80.237.132.231]:54322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb2LE-0000ge-0m for 41327@debbugs.gnu.org; Tue, 19 May 2020 09:31:32 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jb2LB-0008Nr-Vf; Tue, 19 May 2020 15:31:29 +0200 Received: from [192.168.1.3] (helo=micha) by www.rohleder.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jb2LB-0006B2-DK; Tue, 19 May 2020 15:31:29 +0200 From: Michael Rohleder References: <87ftbz986g.fsf@rohleder.de> <87367zx0f9.fsf@nicolasgoaziou.fr> X-PGP-Fingerprint: 755E 2DE5 D0D5 85C5 2E78 2830 7C7A FFBE FEF2 CB25 X-PGP-Key: https://www.rohleder.de/~mike/pgpkey.asc Date: Tue, 19 May 2020 15:31:21 +0200 In-Reply-To: <87367zx0f9.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sat, 16 May 2020 19:19:22 +0200") Message-ID: <875zcsxd92.fsf@rohleder.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1589895092;55e9d97e; X-HE-SMSGID: 1jb2LB-0008Nr-Vf X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Nicolas, thank you for reviewing the patch. Nicolas Goaziou writes: >> + (base32 >> + "183pffdiqb7qqmjq31wxl3fpv8qswqgg99gb716rddiyk15ysri7")))) > > Nitpick: could you move the string on the line above? done. >> + (description >> + "This library only provides basic \"enter\" functionality >> +(`vcsh-link', `vcsh-unlink') and a few convenience commands >> +(`vcsh-new' to init a repo and add files to it, >> +`vcsh-write-gitignore'). > > Without writing too many details, I suggest > > This library provides basic ``enter'' functionality and a few > convenience commands to init a repository and add files to it. > > However, it may be useful to write somewhere what is "vcsh". As a user, > do I need/want that? I modified the description to your suggesting and added a short sentence, why/how this package could be useful. e.g. I use it in this function (that i call from a hydra): > Could you send an updated patch? Regards, From 43a46ffd415ff780eda5dfeb5bd8de8ebaa04259 Mon Sep 17 00:00:00 2001 From: Michael Rohleder Date: Tue, 19 May 2020 15:05:16 +0200 Subject: [PATCH] gnu: Add emacs-vcsh. * gnu/packages/emacs-xyz.scm (emacs-vcsh): New variable. --- gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 69786f335b..77ab2977ee 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -14919,6 +14919,28 @@ repository, @code{magit-org-todos} will create a section in your Magit status buffer with each of your todos.") (license license:gpl3+)))) +(define-public emacs-vcsh + (package + (name "emacs-vcsh") + (version "0.4.4") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.com/stepnem/vcsh-el.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "183pffdiqb7qqmjq31wxl3fpv8qswqgg99gb716rddiyk15ysri7")))) + (build-system emacs-build-system) + (home-page "https://gitlab.com/stepnem/vcsh-el") + (synopsis "Emacs vcsh integration") + (description + "This library provides basic \"enter\" functionality and a few +convenience commands to init a repo and add files to it. This is useful to +use @code{magit} with a @code{vcsh} repo.") + (license license:public-domain))) + (define-public emacs-f3 (package (name "emacs-f3") -- 2.26.2