From patchwork Thu Oct 8 06:26:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Janneke Nieuwenhuizen X-Patchwork-Id: 24505 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5137527BBE8; Thu, 8 Oct 2020 07:27:13 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5F9C727BBE9 for ; Thu, 8 Oct 2020 07:27:12 +0100 (BST) Received: from localhost ([::1]:38388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQPOR-00088K-E9 for patchwork@mira.cbaines.net; Thu, 08 Oct 2020 02:27:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQPOJ-00086H-Ia for guix-patches@gnu.org; Thu, 08 Oct 2020 02:27:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQPOI-0006dX-Hp for guix-patches@gnu.org; Thu, 08 Oct 2020 02:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQPOI-0001ET-Eh for guix-patches@gnu.org; Thu, 08 Oct 2020 02:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43860] [PATCH] gnu: python: Disable failing tests for the Hurd. Resent-From: Jan Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Oct 2020 06:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43860@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16021383974702 (code B ref -1); Thu, 08 Oct 2020 06:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Oct 2020 06:26:37 +0000 Received: from localhost ([127.0.0.1]:58495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQPNo-0001Dh-Rl for submit@debbugs.gnu.org; Thu, 08 Oct 2020 02:26:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:53940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQPNn-0001Da-KL for submit@debbugs.gnu.org; Thu, 08 Oct 2020 02:26:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQPNn-0007W0-EL for guix-patches@gnu.org; Thu, 08 Oct 2020 02:26:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59210) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQPNn-0006aH-4D; Thu, 08 Oct 2020 02:26:31 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=43742 helo=dundal.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kQPNm-0000yG-2Q; Thu, 08 Oct 2020 02:26:30 -0400 From: Jan Nieuwenhuizen Organization: AvatarAcademy.nl X-Url: http://AvatarAcademy.nl Date: Thu, 08 Oct 2020 08:26:26 +0200 Message-ID: <875z7l5j3h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi! This patch disables 27 additional tests for the Hurd, and enabled me to build (a copy of) python-minimal natively --8<---------------cut here---------------start------------->8--- /gnu/store/9xm1idqyvyyz6xcqaa20aw2p8ap9zxcj-python-hurd-minimal-3.8.2 --8<---------------cut here---------------end--------------->8--- That sounds bad, but Debian disables ~15 tests by default (varies per platform), where we only disable test_socket, and 17 additional for the Hurd: https://salsa.debian.org/cpython-team/python3/-/raw/python3.8/debian/rules and our exclude sets have some overlap, but also some "underlap"... It's tempting to do --8<---------------cut here---------------start------------->8--- #:tests? ,(not (hurd-target?)) --8<---------------cut here---------------end--------------->8--- just like https://bugs.gnu.org/43857 suggests: "rather not fiddle too much with test suites until we have defined what’s available in the default build environment." on the other hand, now some 350 tests run and pass. (It would be nice if Python had a less fragile test suite, or if packages (the GNU standard?) defined a "smoke test" we could run.) Then there is also this 2013 bug report in Debian https://bugs.debian.org/708652 "hurd has several tests disabled because they hang the testsuite, at least on the buildds. These should be investigated..." and we/they probably will, when someone finds the time. One last thing: pushing this patch rebuilds world for the Hurd; probably not the best timing to push today? Ideas? Greetings, Janneke From 66eb46ed2f7166bff6d17dcbfe64f195ec1bb6b3 Mon Sep 17 00:00:00 2001 From: "Jan (janneke) Nieuwenhuizen" Date: Wed, 7 Oct 2020 23:01:26 +0200 Subject: [PATCH] gnu: python: Disable failing tests for the Hurd. Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 * gnu/packages/python.scm (python-3.8)[arguments]: When building for the Hurd, disable more tests. --- gnu/packages/python.scm | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 8f2651decf..43704bccae 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -395,7 +395,39 @@ data types.") " --exclude test_mmap" ;; test_socket may hang and eventually run out of memory ;; on some systems: . - " test_socket"))) + " test_socket" + ,@(if (hurd-target?) + '(" test_posix" ;multiple errors + " test_time" + " test_pty" + " test_shutil" + " test_tempfile" ;chflags: invalid argument: + ; tbv14c9t/dir0/dir0/dir0/test0.txt + " test_asyncio" ;runs over 10min + " test_os" ;stty: 'standard input': + ; Inappropriate ioctl for device + " test_openpty" ;No such file or directory + " test_selectors" ;assertEqual(NUM_FDS // 2, len(fds)) + ; 32752 != 4 + " test_compileall" ;multiple errors + " test_poll" ;list index out of range + " test_subprocess" ;runs over 10min + " test_asyncore" ;multiple errors + " test_threadsignals" + " test_eintr" ;Process return code is -14 + " test_io" ;multiple errors + " test_logging" + " test_signal" + " test_threading" ;runs over 10min + " test_flags" ;ERROR + " test_bidirectional_pty" + " test_create_unix_connection" + " test_unix_sock_client_ops" + " test_open_unix_connection" + " test_open_unix_connection_error" + " test_read_pty_output" + " test_write_pty") + '())))) ((#:phases phases) `(modify-phases ,phases ,@(if (hurd-system?) -- Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com