diff mbox series

[bug#53525] gnu: Add emacs-puni

Message ID 875yq7pxv4.fsf@posteo.net
State Accepted
Headers show
Series [bug#53525] gnu: Add emacs-puni | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Niklas Eklund Jan. 25, 2022, 4:46 p.m. UTC 
Hi,

this patch adds the Emacs puni package.

/Niklas

Comments

Nicolas Goaziou Jan. 25, 2022, 5:09 p.m. UTC | #1 
Hello,

Niklas Eklund <niklas.eklund@posteo.net> writes:

> Subject: [PATCH] gnu: Add emacs-puni

Thank you.

> +(define-public emacs-puni
> +  ;; No tagged release upstream
> +  (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0"))

Nitpick: could you add a newline character between (commit ...) and
(revision ...)?

> +      (home-page "https://github.com/AmaiKinono/puni")
> +      (synopsis "Parentheses Universalistic")

This synopsis is not very useful. Could you expound it a bit?
> +      (description
> +       "Structured editing (soft deletion, expression navigating & manipulating) that supports many major modes out of the box.")

Description are expected to consist of full sentences. I suggest:

   Puni is an Emacs minor mode for structured editing: soft deletion,
   expression navigating and manipulating.  It supports many major modes
   out of the box.

Could you send an updated patch?

Regards,
diff mbox series

Patch

From db8621385ed0b3b60f24396732dfb94800732822 Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Tue, 25 Jan 2022 17:42:48 +0100
Subject: [PATCH] gnu: Add emacs-puni

---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 387f1b93fd..205b6d84c6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -633,6 +633,29 @@  (define-public emacs-paredit
 when typing parentheses directly or commenting out code line by line.")
     (license license:gpl3+)))
 
+(define-public emacs-puni
+  ;; No tagged release upstream
+  (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0"))
+    (package
+      (name "emacs-puni")
+      (version (git-version "0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/AmaiKinono/puni")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "14lcqf0qdkq2rklx12v12qpgfahz2bpqmnl3bzcz5myawgjjcphd"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-with-editor))
+      (home-page "https://github.com/AmaiKinono/puni")
+      (synopsis "Parentheses Universalistic")
+      (description
+       "Structured editing (soft deletion, expression navigating & manipulating) that supports many major modes out of the box.")
+      (license license:gpl3+))))
+
 (define-public emacs-project
   (package
     (name "emacs-project")
-- 
2.32.0