diff mbox series

[bug#65717] gnu: Add emacs-latex-extra.

Message ID 875y4ri1n7.fsf@colimite.fr
State New
Headers show
Series [bug#65717] gnu: Add emacs-latex-extra. | expand

Commit Message

Sergiu Ivanov Sept. 3, 2023, 5:52 p.m. UTC 
Dear Guix,

Here's a patch packaging the MELPA package https://github.com/Malabarba/latex-extra .

Thanks!

-
Sergiu

Comments

Nicolas Goaziou Sept. 3, 2023, 7:44 p.m. UTC | #1 
Hello,

Sergiu Ivanov <sivanov@colimite.fr> writes:

> Subject: [PATCH] gnu: Add emacs-latex-extra.

Thank you.

Some comments follow.

> +      (build-system emacs-build-system)
> +      (arguments
> +       `(#:phases (modify-phases %standard-phases
> +                    (add-before 'build 'set-home
> +                      (lambda _
> +                        (setenv "HOME"
> +                                (getcwd)))))))

Why is it needed ?

Also, upstream provides tests. Could you run them?

> +      (inputs (list emacs-auctex))

Usually, inputs are propagated, although it doesn't make a difference
for Emacs.

> +      (home-page "https://github.com/Malabarba/latex-extra")
> +      (synopsis "Usability improvements for latex-mode")

Nitpick: "latex-mode" -> "LaTeX mode"

> +      (description
> +       "Latex-extra defines extra commands and keys for LaTeX-mode, as well
> +as brings user experience improvements.")

Nitpick: "LaTeX-mode" -> "LaTeX mode"

Could you send an updated patch?

Regards,
diff mbox series

Patch

From d0e143ed7f1ac22891e67cf354ccecb7439c190a Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov <sivanov@colimite.fr>
Date: Sun, 3 Sep 2023 19:29:03 +0200
Subject: [PATCH] gnu: Add emacs-latex-extra.

* gnu/packages/emacs-xyz.scm (emacs-latex-extra): New variable.
---
 gnu/packages/emacs-xyz.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dc2998a217..9dc9bcc6a7 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -132,6 +132,7 @@ 
 ;;; Copyright © 2023 Fabio Natali <me@fabionatali.com>
 ;;; Copyright © 2023 Arnaud Lechevallier <arnaud.lechevallier@free.fr>
 ;;; Copyright © 2023 Ahmad Draidi <a.r.draidi@redscript.org>
+;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4067,6 +4068,36 @@  (define-public emacs-auctex
 or XEmacs.")
     (license license:gpl3+)))
 
+(define-public emacs-latex-extra
+  (let ((commit "a81e7588448f85c5fcc3f3fc71cf957d0928a656")
+        (revision "0"))
+    (package
+      (name "emacs-latex-extra")
+      (version (git-version "1.14" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/Malabarba/latex-extra")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "0sajg5vmygnkcnmkrpf8r7c4b8v95hgsv1y6pz868jpznmldnxkb"))
+                (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (arguments
+       `(#:phases (modify-phases %standard-phases
+                    (add-before 'build 'set-home
+                      (lambda _
+                        (setenv "HOME"
+                                (getcwd)))))))
+      (inputs (list emacs-auctex))
+      (home-page "https://github.com/Malabarba/latex-extra")
+      (synopsis "Usability improvements for latex-mode")
+      (description
+       "Latex-extra defines extra commands and keys for LaTeX-mode, as well
+as brings user experience improvements.")
+      (license license:gpl3+))))
+
 (define-public emacs-autothemer
   (let ((commit "8f72afc6dba5ad7cc3a201a084fd20571f945d2e")) ;version bump
     (package
-- 
2.41.0