From patchwork Wed Apr 17 09:06:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 63098 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2CEE627BBEB; Wed, 17 Apr 2024 10:08:13 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3A8AB27BBEA for ; Wed, 17 Apr 2024 10:08:12 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rx1Gh-0002YT-0f; Wed, 17 Apr 2024 05:07:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx1Gf-0002Y7-K1 for guix-patches@gnu.org; Wed, 17 Apr 2024 05:07:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rx1Gf-000704-C0 for guix-patches@gnu.org; Wed, 17 Apr 2024 05:07:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rx1Gr-0007zD-TN for guix-patches@gnu.org; Wed, 17 Apr 2024 05:08:01 -0400 Subject: bug#68448: Add guile-rsv package definition. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 17 Apr 2024 09:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68448 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Yuval Langer Cc: 68448-done@debbugs.gnu.org Mail-Followup-To: 68448@debbugs.gnu.org, ludo@gnu.org, yuval.langer@gmail.com Received: via spool by 68448-done@debbugs.gnu.org id=D68448.171334484530416 (code D ref 68448); Wed, 17 Apr 2024 09:08:01 +0000 Received: (at 68448-done) by debbugs.gnu.org; 17 Apr 2024 09:07:25 +0000 Received: from localhost ([127.0.0.1]:45725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx1GE-0007uU-Sj for submit@debbugs.gnu.org; Wed, 17 Apr 2024 05:07:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx1G9-0007t6-KQ for 68448-done@debbugs.gnu.org; Wed, 17 Apr 2024 05:07:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx1Fr-0006up-9K; Wed, 17 Apr 2024 05:06:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=qr1Jl8RbQBgbOiy30d1RYUFNC35xCj8O5PTcFCRx/6A=; b=Ad9SjEAW5Gk1NAxO6n84 FAAJKGI7oMQbWTKwkA3Bh+V0IZ7VKnAs3ddQcbf3IiIAizOH05fb1chlJSE4B8ymjqUG4yz1azW/V scJ2/NIKLuQlPtUgL395e6oXx6e5mFv6E3IGWcd3SifffGe5QcQXEoSST4XJKS2R0m05QlCxNMBjP Pt+RDv9kXganfjMfVM+mubmKPIabIShSd/HCkXeg4CNTYh25jnmKpiJHJFx/2s46Fn7I+Iwg7m/GU EoBNPFjAnNXikHXbB9CcYywTE9KkFuOaO3Avmh0bJxdwlqOqo1U/+mwBKEYGCq1fvBB9Qib8iwJor UvZ7d1RLc4emWw==; From: Ludovic =?utf-8?q?Court=C3=A8s?= In-Reply-To: (Yuval Langer's message of "Tue, 6 Feb 2024 15:15:50 +0200") References: <87sf2hdtvt.fsf@gnu.org> Date: Wed, 17 Apr 2024 11:06:56 +0200 Message-ID: <875xwgjr2n.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi Yulav, Yuval Langer skribis: > I have: > > - Replaced the square brackets with parentheses in the let > definitions, > - added a revision number and used `git-version`, > - rewrote the synopsis and description, > - checked the style with `guix style -L . guile-rsv` in my own Guix > channel with this guile-rsv package definition, which seems to show > no style errors or recommendations, and > > I hope these are sufficient. Apologies for the long delay. I made the cosmetic changes below, added a commit log, and committed it. Thanks! Ludo’. diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index 874dd3d98a..c0b0dfd78c 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -5498,21 +5498,19 @@ (define-public guile-eris (define-public guile-rsv (let ((commit "41b04c85eef31d4d51001c6d66e8fd339fcc614c") - (revision "1") - (base32-string "1w9jbkpmh13zrxkj915nm3l537smm0jsrdzrzcxylb6w59vqpw6l") - (git-repository-url "https://codeberg.org/kakafarm/guile-rsv/")) + (revision "1")) (package (name "guile-rsv") (version (git-version "0.2.0" revision commit)) + (home-page "https://codeberg.org/kakafarm/guile-rsv/") (source (origin - (uri (git-reference - (url git-repository-url) - (commit commit))) + (uri (git-reference (url home-page) (commit commit))) (method git-fetch) (file-name (git-file-name name version)) (sha256 - (base32 base32-string)))) + (base32 + "1w9jbkpmh13zrxkj915nm3l537smm0jsrdzrzcxylb6w59vqpw6l")))) (inputs (list guile-3.0 bash)) (build-system guile-build-system) (arguments @@ -5530,9 +5528,9 @@ (define-public guile-rsv (mkdir-p bin) (for-each (lambda (command-name) (let ((source-script (string-append #$output - scm "/" - command-name - ".scm")) + scm "/" + command-name + ".scm")) (target-command (string-append bin "/" command-name))) @@ -5544,22 +5542,19 @@ (define-public guile-rsv `("GUILE_LOAD_COMPILED_PATH" prefix (,(string-append #$output go)))))) (list "scm2rsv" "rsv2scm")))))))) - (home-page git-repository-url) - (synopsis - "Library for reading and writing Rows of String Values data format") + (synopsis "Reading and writing @acronym{RSV, rows of string values} data format") (description - "R7RS-small Scheme library for reading and writing RSV (Rows of String -Values) data format, a very simple binary format for storing tables of -strings. It is a competitor for e.g. CSV (Comma Seperated Values), -and TSV (Tab Separated Values). Its main benefit is that the strings -are represented as Unicode encoded as UTF-8, and the value and row -separators are byte values that are never used in UTF-8, so the -strings do not need any error prone escaping and thus can be written -and read verbatim. + "R7RS-small Scheme library for reading and writing @acronym{RSV, rows +of string values} data format, a very simple binary format for storing tables +of strings. It is a competitor for CSV (Comma Seperated Values) and TSV (Tab +Separated Values). Its main benefit is that the strings are represented as +Unicode encoded as UTF-8, and the value and row separators are byte values +that are never used in UTF-8, so the strings do not need any error prone +escaping and thus can be written and read verbatim. -Specified in https://github.com/Stenway/RSV-Specification and -demonstrated in https://www.youtube.com/watch?v=tb_70o6ohMA.") - (license (list license:gpl3+ license:expat-0))))) +The RSV format is specified in +@url{https://github.com/Stenway/RSV-Specification}.") + (license license:gpl3+)))) (define-public guile-r6rs-protobuf (package