| Message ID | 874lcj2vp5.fsf@roquette.mug.biscuolo.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#33387] doc: fix typo in connman config | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/applying patch | fail | Apply failed |
On Wed, Nov 14, 2018 at 10:30:46PM +0100, Giovanni Biscuolo wrote: > Dear maintainers, > > reading at the manual I found what it seems a typo to me, please have a > look at my tiny patch > > best regards > Giovanni > Here's the relevant code from gnu/services/networking.scm: (define-record-type* <connman-configuration> connman-configuration make-connman-configuration connman-configuration? (connman connman-configuration-connman (default connman)) (disable-vpn? connman-configuration-disable-vpn? (default #f))) (define (connman-activation config) (let ((disable-vpn? (connman-configuration-disable-vpn? config))) (with-imported-modules '((guix build utils)) #~(begin (use-modules (guix build utils)) (mkdir-p "/var/lib/connman/") (unless #$disable-vpn? (mkdir-p "/var/lib/connman-vpn/")))))) So it looks like the documentation is wrong. > From 8cf66fa64d495857a71bafffcd0c6cc56abf2eec Mon Sep 17 00:00:00 2001 > From: Giovanni Biscuolo <g@xelera.eu> > Date: Wed, 14 Nov 2018 21:44:13 +0100 > Subject: [PATCH] doc: fix typo in connman config > > * doc/guix.texi (Networking Services): fix typo in connman config > "disable-vpn?" parameter documentation, semantic is inverted > --- > doc/guix.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/guix.texi b/doc/guix.texi > index 0ba034e82..765261fc6 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -11832,7 +11832,7 @@ Data Type representing the configuration of connman. > The connman package to use. > > @item @code{disable-vpn?} (default: @code{#f}) > -When true, enable connman's vpn plugin. > +When true, disable connman's vpn plugin. > @end table > @end deftp > > -- > 2.11.0 > > > -- > Giovanni Biscuolo > > Xelera IT Infrastructures
Commit pushed as c61f36f368c563c48815de0abe625383909b0a8d
From 8cf66fa64d495857a71bafffcd0c6cc56abf2eec Mon Sep 17 00:00:00 2001 From: Giovanni Biscuolo <g@xelera.eu> Date: Wed, 14 Nov 2018 21:44:13 +0100 Subject: [PATCH] doc: fix typo in connman config * doc/guix.texi (Networking Services): fix typo in connman config "disable-vpn?" parameter documentation, semantic is inverted --- doc/guix.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guix.texi b/doc/guix.texi index 0ba034e82..765261fc6 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -11832,7 +11832,7 @@ Data Type representing the configuration of connman. The connman package to use. @item @code{disable-vpn?} (default: @code{#f}) -When true, enable connman's vpn plugin. +When true, disable connman's vpn plugin. @end table @end deftp -- 2.11.0