Message ID | 874kf979i1.fsf_-_@rohleder.de |
---|---|
State | Accepted |
Headers | show |
Series | [bug#48194] gnu: libmediainfo: Fix usage of libcurl and libtinyxml2. | expand |
Context | Check | Description |
---|---|---|
cbaines/comparison | success | View comparision |
cbaines/git branch | success | View Git branch |
cbaines/applying patch | success | View Laminar job |
cbaines/issue | success | View issue |
Michael Rohleder <mike@rohleder.de> skribis: >>From 6612d1189263cc4670b820e26f5e75d4df9c68b0 Mon Sep 17 00:00:00 2001 > From: Michael Rohleder <mike@rohleder.de> > Date: Tue, 11 May 2021 14:05:13 +0200 > Subject: [PATCH] gnu: mediainfo: Fix usage of libcurl and tinyxml2. > > * gnu/packages/video.scm (mediainfo): Fix usage of libcurl and tinyxml2. Please mention [arguments] and [propagated-inputs]. > gnu/packages/video.scm | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index 481ab46b6e..630edf49b6 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -3834,6 +3834,8 @@ practically any type of media.") > (build-system gnu-build-system) > (arguments > '(#:tests? #f ; see above TODO > + #:configure-flags > + (list "--with-libcurl" "--with-libtinyxml2") > #:phases > ;; build scripts not in root of archive > (modify-phases %standard-phases > @@ -3888,6 +3890,8 @@ MPEG-2, MPEG-4, DVD (VOB)... > ("libtool" ,libtool) > ("pkg-config" ,pkg-config) > ("zlib" ,zlib) > + ("curl" ,curl) ;; In Requires.private of libmediainfo pkg-config files. > + ("tinyxml2" ,tinyxml2) Shouldn’t we also remove them from ‘native-inputs’, which looks bogus anyway? Thanks, Ludo’.
Ping! :-) Ludovic Courtès <ludo@gnu.org> skribis: > Michael Rohleder <mike@rohleder.de> skribis: > >>>>From 6612d1189263cc4670b820e26f5e75d4df9c68b0 Mon Sep 17 00:00:00 2001 >> From: Michael Rohleder <mike@rohleder.de> >> Date: Tue, 11 May 2021 14:05:13 +0200 >> Subject: [PATCH] gnu: mediainfo: Fix usage of libcurl and tinyxml2. >> >> * gnu/packages/video.scm (mediainfo): Fix usage of libcurl and tinyxml2. > > Please mention [arguments] and [propagated-inputs]. > > >> gnu/packages/video.scm | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm >> index 481ab46b6e..630edf49b6 100644 >> --- a/gnu/packages/video.scm >> +++ b/gnu/packages/video.scm >> @@ -3834,6 +3834,8 @@ practically any type of media.") >> (build-system gnu-build-system) >> (arguments >> '(#:tests? #f ; see above TODO >> + #:configure-flags >> + (list "--with-libcurl" "--with-libtinyxml2") >> #:phases >> ;; build scripts not in root of archive >> (modify-phases %standard-phases >> @@ -3888,6 +3890,8 @@ MPEG-2, MPEG-4, DVD (VOB)... >> ("libtool" ,libtool) >> ("pkg-config" ,pkg-config) >> ("zlib" ,zlib) >> + ("curl" ,curl) ;; In Requires.private of libmediainfo pkg-config files. >> + ("tinyxml2" ,tinyxml2) > > Shouldn’t we also remove them from ‘native-inputs’, which looks bogus > anyway? > > Thanks, > Ludo’.
>From 6612d1189263cc4670b820e26f5e75d4df9c68b0 Mon Sep 17 00:00:00 2001 From: Michael Rohleder <mike@rohleder.de> Date: Tue, 11 May 2021 14:05:13 +0200 Subject: [PATCH] gnu: mediainfo: Fix usage of libcurl and tinyxml2. * gnu/packages/video.scm (mediainfo): Fix usage of libcurl and tinyxml2. --- gnu/packages/video.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 481ab46b6e..630edf49b6 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -3834,6 +3834,8 @@ practically any type of media.") (build-system gnu-build-system) (arguments '(#:tests? #f ; see above TODO + #:configure-flags + (list "--with-libcurl" "--with-libtinyxml2") #:phases ;; build scripts not in root of archive (modify-phases %standard-phases @@ -3888,6 +3890,8 @@ MPEG-2, MPEG-4, DVD (VOB)... ("libtool" ,libtool) ("pkg-config" ,pkg-config) ("zlib" ,zlib) + ("curl" ,curl) ;; In Requires.private of libmediainfo pkg-config files. + ("tinyxml2" ,tinyxml2) ("libmediainfo" ,libmediainfo) ("libzen" ,libzen))) (build-system gnu-build-system) -- 2.31.1