From patchwork Sun Sep 8 20:04:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Fabio Natali X-Patchwork-Id: 67777 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6193527BBE9; Sun, 8 Sep 2024 21:08:31 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D097C27BBE2 for ; Sun, 8 Sep 2024 21:08:27 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1snOCZ-0000L4-2r; Sun, 08 Sep 2024 16:08:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snOCV-0000KR-RE for guix-patches@gnu.org; Sun, 08 Sep 2024 16:08:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1snOCV-0002Cc-IZ for guix-patches@gnu.org; Sun, 08 Sep 2024 16:07:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:In-Reply-To:From:To:References:Subject; bh=hyJxwcDN4iqiY8DuagaeKjRDEHKStP8O3a8r0+5vM4A=; b=fKRIR45oxNjsfkgoEc2b9+nxpD8KkRYEizOBbWUDniKjSxi0mPaxZXZ2L4HqVn+DMtNnDzciXVDac3grLveBQU3uaCEmMs89vvtjK1CwT2O5/5tVdJzTuEeVku+Cl9iYXVU2s0Ngbwx/LE+YDjKhdZC1kHz/AB4HU9K9VFUf3l3qejNNCxbmKLQImDu2ah0YqxMHAQV75nIqZs1yPwMlytN+Tz3d374o3IEXBNbSSlPsQRdeE+/5Lv9bLQDoOGR/ePodLVMq2imJjXhLHftx+L0ylsjAq3GTcUoinRiF+Jkx9HDebHhaw15V59daT73sPcGydZ93PYeat7jbwCBO0g==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1snOCX-0000mE-Sj for guix-patches@gnu.org; Sun, 08 Sep 2024 16:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72398] [PATCH v6] services: Add readymedia-service-type. References: <4fee1c18adcfd29d40d5b557bf52db0e531c3f16.1722421592.git.me@fabionatali.com> Resent-From: Fabio Natali Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 08 Sep 2024 20:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72398 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72398@debbugs.gnu.org Cc: Arun Isaac , Bruno Victal , Ludovic =?utf-8?q?Court=C3=A8s?= , Fabio Natali Received: via spool by 72398-submit@debbugs.gnu.org id=B72398.17258260232909 (code B ref 72398); Sun, 08 Sep 2024 20:08:01 +0000 Received: (at 72398) by debbugs.gnu.org; 8 Sep 2024 20:07:03 +0000 Received: from localhost ([127.0.0.1]:60076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snOBa-0000kb-1F for submit@debbugs.gnu.org; Sun, 08 Sep 2024 16:07:03 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:55871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snOBX-0000kF-Ay for 72398@debbugs.gnu.org; Sun, 08 Sep 2024 16:07:01 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id D5A23FF802; Sun, 8 Sep 2024 20:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1725825990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to; bh=hyJxwcDN4iqiY8DuagaeKjRDEHKStP8O3a8r0+5vM4A=; b=p48L9ZOt8R3LrTTNRkMSzmzh9OHfcQQJXUHoT3Tj9SSFBuOspBETMQjANAlGmCnBg5U0sq rybZDvL+vFulbiVU6QR4fJcBKLy/2bHCOLxqQ56totlHuySbA/oVyhEuOhIyIRs8q+8KqJ rdLcaiubM0YaaENWQisYVUeL3zt6ErksHuVd+F5nix/UqXIY+2TJ+0ZN9uA1U5ZqbJKS9w aUirouaz9UPKkK79EOdQnU8Lely5UM/dn+zvoPgErz20I0/NVIO10GS03YgaU7XF320Ihl HfzOL4R/eZp3kHLQKird+cYlRoR4haM6pj2/Mvc/7z2y2YIC8XgrbmTCIFee1Q== In-Reply-To: <874j6swhpd.fsf@gnu.org> Date: Sun, 08 Sep 2024 21:04:14 +0100 Message-ID: <874j6p7w01.fsf@fabionatali.com> MIME-Version: 1.0 X-GND-Sasl: me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Fabio Natali X-ACL-Warn: , Fabio Natali via Guix-patches X-Patchwork-Original-From: Fabio Natali via Guix-patches via From: Fabio Natali Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * doc/guix.texi (Miscellaneous Services): New node. * gnu/local.mk: Add mention of new files. * gnu/services/upnp.scm: New file. * gnu/tests/upnp.scm: New file. Change-Id: I80b02235ec36b7a1ea85fea98bdc9e08126b09a3 --- Hi Ludo, Thanks for reviewing this and providing feedback! I think I've addressed all points. I'm adding my comments inline below plus the updated patch at the end. Thanks, cheers, Fabio. 🙏 > This is really minor, but please mention the place where this is > added, like: > > * doc/guix.texi (Section Name): New node. Fixed. > > +The @code{(gnu services upnp)} module offers services related to > > the +DLNA and UPnP-VA networking protocols. For now, it provides > > the > > I would add a few words about what DLNA and UPnP-VA allow users to do, > and perhaps what they mean. Fixed. > > +@code{readymedia-service-type} is a Guix service that wraps around > > +ReadyMedia's @code{minidlnad}. For increased security, the service > > +makes use of @code{least-authority-wrapper} which limits the > > resources +that the daemon has access to. The daemon runs as the > > +@code{readymedia} unprivileged user, which is a member of the > > +@code{readymedia} group. > > I would omit everything that follows “For increased security” since > it’s largely an implementation detail (a nice one though!) and could > get out of sync over time. Fixed. > But! While I agree in principle with what Bruno wrote about the > shortcomings of activation snippets, I would stick to an activation > snippet here to create directories etc. The change Bruno proposes > should be treated separately and systematically across all the > services, not just one of them. Fixed - reverted to using an activation snippet. > > +(define %test-readymedia-service > > Just ‘%test-readymedia’… Fixed. > > + (system-test > > + (name "readymedia-service") > > … and “readymedia”, for consistency with other tests. Fixed. Tests can be run with: --8<---------------cut here---------------start------------->8--- make check-system TESTS="readymedia" --8<---------------cut here---------------end--------------->8--- I get a green light on my machine. I had to add a slight delay to one of the tests to give enough time for a file to be created. Not super happy about it as the test could theoretically fail on a slow machine - but hopefully it's alright. doc/guix.texi | 105 +++++++++++++++++++++ gnu/local.mk | 2 + gnu/services/upnp.scm | 213 ++++++++++++++++++++++++++++++++++++++++++ gnu/tests/upnp.scm | 178 +++++++++++++++++++++++++++++++++++ 4 files changed, 498 insertions(+) create mode 100644 gnu/services/upnp.scm create mode 100644 gnu/tests/upnp.scm base-commit: 123b7226a0442ee4103c04064d453421424d5fac diff --git a/doc/guix.texi b/doc/guix.texi index 981ffb8c58..9b193bde23 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -41635,6 +41635,111 @@ Miscellaneous Services @end deftp +@c %end of fragment + +@cindex DLNA/UPnP +@subsubheading DLNA/UPnP Services + +The @code{(gnu services upnp)} module offers services related to UPnP +(Universal Plug and Play) and DLNA (Digital Living Network Alliance), +networking protocols that can be used for media streaming and device +interoperability within a local network. For now, this module +provides the @code{readymedia-service-type}. + +@uref{https://sourceforge.net/projects/minidlna/, ReadyMedia} +(formerly known as MiniDLNA) is a DLNA/UPnP-AV media server. The +project's daemon, @code{minidlnad}, can serve media files (audio, +pictures, and video) to DLNA/UPnP-AV clients available in the network. +@code{readymedia-service-type} is a Guix service that wraps around +ReadyMedia's @code{minidlnad}. + +Consider the following configuration: + +@lisp +(use-service-modules upnp @dots{}) + +(operating-system + ;; @dots{} + (services + (list + (service readymedia-service-type + (readymedia-configuration + (media-directoriess + (list + (readymedia-media-directory (path "/media/audio") + (types '(A))) + (readymedia-media-directory (path "/media/video") + (types '(V))) + (readymedia-media-directory (path "/media/misc")))) + (extra-config '(("notify_interval" . 60))))) + ;; @dots{} + ))) +@end lisp + +This sets up the ReadyMedia daemon to serve files from the media +folders specified in @code{media-directories}. The +@code{media-directories} field is mandatory. All other fields (such +as network ports and the server name) come with a predefined default +and can be omitted. + +@c %start of fragment + +@deftp {Data Type} readymedia-configuration +Available @code{readymedia-configuration} fields are: + +@table @asis +@item @code{readymedia} (default: @code{readymedia}) (type: package) +The ReadyMedia package to be used for the service. + +@item @code{friendly-name} (default: @code{#f}) (type: maybe-string) +A custom name that will be displayed on connected clients. + +@item @code{media-directories} (type: list) +The list of media folders to serve content from. Each item is a +@code{readymedia-media-directory}. + +@item @code{cache-directory} (default: @code{"/var/cache/readymedia"}) (type: string) +A folder for ReadyMedia's cache files. If not existing already, the +folder will be created as part of the service activation and the +ReadyMedia user will be assigned ownership. + +@item @code{log-directory} (default: @code{"/var/log/readymedia"}) (type: string) +A folder for ReadyMedia's log files. If not existing already, the +folder will be created as part of the service activation and the +ReadyMedia user will be assigned ownership. + +@item @code{port} (default: @code{#f}) (type: maybe-integer) +A custom port that the service will be listening on. + +@item @code{extra-config} (default: @code{'()}) (type: alist) +An association list of further options, as accepted by ReadyMedia. + +@end table + +@end deftp + +@c %end of fragment + +@c %start of fragment + +@deftp {Data Type} readymedia-media-directory +A @code{media-directories} entry includes a folder @code{path} and, +optionally, the @code{types} of media files included within the +folder. + +@table @asis +@item @code{path} (type: string) +The media folder location. + +@item @code{types} (default: @code{'()}) (type: list) +A list indicating the types of file included in the media folder. +Valid values are combinations of individual media types, i.e. symbol +@code{A} for audio, @code{P} for pictures, @code{V} for video. An +empty list means no type specified. + +@end table + +@end deftp @c %end of fragment diff --git a/gnu/local.mk b/gnu/local.mk index ed630041ff..c65e9373f1 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -754,6 +754,7 @@ GNU_SYSTEM_MODULES = \ %D%/services/syncthing.scm \ %D%/services/sysctl.scm \ %D%/services/telephony.scm \ + %D%/services/upnp.scm \ %D%/services/version-control.scm \ %D%/services/vnc.scm \ %D%/services/vpn.scm \ @@ -844,6 +845,7 @@ GNU_SYSTEM_MODULES = \ %D%/tests/singularity.scm \ %D%/tests/ssh.scm \ %D%/tests/telephony.scm \ + %D%/tests/upnp.scm \ %D%/tests/version-control.scm \ %D%/tests/virtualization.scm \ %D%/tests/vnc.scm \ diff --git a/gnu/services/upnp.scm b/gnu/services/upnp.scm new file mode 100644 index 0000000000..ad13f97827 --- /dev/null +++ b/gnu/services/upnp.scm @@ -0,0 +1,213 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2024 Fabio Natali +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu services upnp) + #:use-module (gnu build linux-container) + #:use-module (gnu packages admin) + #:use-module (gnu packages upnp) + #:use-module (gnu services admin) + #:use-module (gnu services base) + #:use-module (gnu services shepherd) + #:use-module (gnu services) + #:use-module (gnu system file-systems) + #:use-module (gnu system shadow) + #:use-module (guix gexp) + #:use-module (guix least-authority) + #:use-module (guix records) + #:use-module (ice-9 match) + #:export (%readymedia-default-cache-directory + %readymedia-default-log-directory + %readymedia-default-port + %readymedia-log-file + %readymedia-user-account + %readymedia-user-group + readymedia-configuration + readymedia-configuration-cache-directory + readymedia-configuration-extra-config + readymedia-configuration-friendly-name + readymedia-configuration-log-directory + readymedia-configuration-media-directories + readymedia-configuration-port + readymedia-configuration-readymedia + readymedia-configuration? + readymedia-media-directory + readymedia-media-directory-path + readymedia-media-directory-types + readymedia-media-directory? + readymedia-service-type)) + +;;; Commentary: +;;; +;;; UPnP services. +;;; +;;; Code: + +(define %readymedia-default-cache-directory "/var/cache/readymedia") +(define %readymedia-default-log-directory "/var/log/readymedia") +(define %readymedia-log-file "minidlna.log") +(define %readymedia-user-group "readymedia") +(define %readymedia-user-account "readymedia") + +(define-record-type* + readymedia-configuration make-readymedia-configuration + readymedia-configuration? + (readymedia readymedia-configuration-readymedia + (default readymedia)) + (cache-directory readymedia-configuration-cache-directory + (default %readymedia-default-cache-directory)) + (log-directory readymedia-configuration-log-directory + (default %readymedia-default-log-directory)) + (friendly-name readymedia-configuration-friendly-name + (default #f)) + (media-directories readymedia-configuration-media-directories) + (port readymedia-configuration-port + (default #f)) + (extra-config readymedia-configuration-extra-config + (default '()))) + +;; READYMEDIA-MEDIA-DIR is a record that indicates the path of a media folder +;; and the types of media included within it. Allowed individual types are the +;; symbols 'A' for audio, 'V' for video, and 'P' for pictures. The types field +;; can contain any combination of individual types; an empty list means no type +;; specified. +(define-record-type* + readymedia-media-directory make-readymedia-media-directory + readymedia-media-directory? + (path readymedia-media-directory-path) + (types readymedia-media-directory-types (default '()))) + +(define (readymedia-media-directory->string entry) + "Convert a media-directory ENTRY to a ReadyMedia/MiniDLNA media dir string." + (match-record + entry (path types) + (if (null? types) + (format #f "media_dir=~a" path) + (format #f + "media_dir=~a,~a" + (string-join (map symbol->string types) "") + path)))) + +(define (readymedia-extra-config-entry->string entry) + "Convert a extra-config ENTRY to a ReadyMedia/MiniDLNA configuration string." + (let ((key (car entry)) + (value (cdr entry))) + (format #f "~a=~a" key value))) + +(define (readymedia-configuration->config-file config) + "Return the ReadyMedia/MiniDLNA configuration file corresponding to CONFIG." + (let ((friendly-name (readymedia-configuration-friendly-name config)) + (media-directories (readymedia-configuration-media-directories config)) + (cache-directory (readymedia-configuration-cache-directory config)) + (log-directory (readymedia-configuration-log-directory config)) + (port (readymedia-configuration-port config)) + (extra-config (readymedia-configuration-extra-config config))) + (mixed-text-file + "minidlna.conf" + "db_dir=" cache-directory "\n" + "log_dir=" log-directory "\n" + (if friendly-name (format #f "friendly_name=~a\n" friendly-name) "") + (if port (format #f "port=~a\n" port) "") + (string-join + (map readymedia-media-directory->string media-directories) "\n" 'suffix) + (string-join + (map readymedia-extra-config-entry->string extra-config) "\n" 'suffix)))) + +(define (readymedia-shepherd-service config) + "Return a least-authority ReadyMedia/MiniDLNA Shepherd service." + (let* ((minidlna-conf (readymedia-configuration->config-file config)) + (media-directories (readymedia-configuration-media-directories config)) + (cache-directory (readymedia-configuration-cache-directory config)) + (log-directory (readymedia-configuration-log-directory config)) + (log-file (string-append log-directory "/" %readymedia-log-file)) + (readymedia (least-authority-wrapper + (file-append + (readymedia-configuration-readymedia config) + "/sbin/minidlnad") + #:name "minidlna" + #:mappings + (cons* (file-system-mapping + (source cache-directory) + (target source) + (writable? #t)) + (file-system-mapping + (source log-directory) + (target source) + (writable? #t)) + (file-system-mapping + (source minidlna-conf) + (target source)) + (map + (lambda (e) + (file-system-mapping + (source (readymedia-media-directory-path e)) + (target source) + (writable? #f))) + media-directories)) + #:namespaces (delq 'net %namespaces)))) + (list (shepherd-service + (documentation "Run the ReadyMedia/MiniDLNA daemon.") + (provision '(readymedia)) + (requirement '(networking user-processes)) + (start + #~(make-forkexec-constructor + ;; "-S" is to daemonise minidlnad. + (list #$readymedia "-f" #$minidlna-conf "-S") + #:log-file #$log-file + #:user #$%readymedia-user-account + #:group #$%readymedia-user-group)) + (stop #~(make-kill-destructor)))))) + +(define readymedia-accounts + (list (user-group + (name "readymedia") + (system? #t)) + (user-account + (name "readymedia") + (group "readymedia") + (system? #t) + (comment "ReadyMedia/MiniDLNA daemon user") + (home-directory "/var/empty") + (shell (file-append shadow "/sbin/nologin"))))) + +(define (readymedia-activation config) + "Set up directories for ReadyMedia/MiniDLNA." + (let ((cache-directory (readymedia-configuration-cache-directory config)) + (log-directory (readymedia-configuration-log-directory config)) + (media-directories (readymedia-configuration-media-directories config))) + #~(begin + (use-modules (guix build utils)) + (let* ((user (getpw #$%readymedia-user-account)) + (dirs (list #$cache-directory + #$log-directory + #$@(map (lambda (e) + (readymedia-media-directory-path e)) + media-directories))) + (init-directory (lambda (d) (unless (file-exists? d) + (mkdir-p/perms d user #o755))))) + (for-each init-directory dirs))))) + +(define readymedia-service-type + (service-type + (name 'readymedia) + (extensions + (list + (service-extension shepherd-root-service-type readymedia-shepherd-service) + (service-extension account-service-type (const readymedia-accounts)) + (service-extension activation-service-type readymedia-activation))) + (description + "Run @command{minidlnad}, the ReadyMedia/MiniDLNA media server."))) diff --git a/gnu/tests/upnp.scm b/gnu/tests/upnp.scm new file mode 100644 index 0000000000..8e92594901 --- /dev/null +++ b/gnu/tests/upnp.scm @@ -0,0 +1,178 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2024 Fabio Natali +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu tests upnp) + #:use-module (gnu services) + #:use-module (gnu services networking) + #:use-module (gnu services upnp) + #:use-module (gnu system vm) + #:use-module (gnu tests) + #:use-module (guix gexp) + #:export (%test-readymedia)) + +(define %readymedia-cache-file "files.db") +(define %readymedia-cache-path + (string-append %readymedia-default-cache-directory + "/" + %readymedia-cache-file)) +(define %readymedia-log-path + (string-append %readymedia-default-log-directory + "/" + %readymedia-log-file)) +(define %readymedia-default-port 8200) +(define %readymedia-media-directory "/media") +(define %readymedia-configuration-test + (readymedia-configuration + (media-directories + (list + (readymedia-media-directory (path %readymedia-media-directory) + (types '(A V))))))) + +(define (run-readymedia-test) + (define os + (marionette-operating-system + (simple-operating-system + (service dhcp-client-service-type) + (service readymedia-service-type + %readymedia-configuration-test)) + #:imported-modules '((gnu services herd) + (json parser)) + #:requirements '(readymedia))) + + (define test + (with-imported-modules '((gnu build marionette)) + #~(begin + (use-modules (gnu build marionette) + (srfi srfi-64)) + + (define marionette + (make-marionette + (list #$(virtual-machine + (operating-system os) + (port-forwardings '()))))) + + (test-runner-current (system-test-runner #$output)) + (test-begin "readymedia") + + ;; ReadyMedia user. + (test-assert "ReadyMedia user exists" + (marionette-eval + '(begin + (getpwnam #$%readymedia-user-account) + #t) + marionette)) + (test-assert "ReadyMedia group exists" + (marionette-eval + '(begin + (getgrnam #$%readymedia-user-group) + #t) + marionette)) + + ;; Cache directory and file. + (test-assert "cache directory exists" + (marionette-eval + '(eq? (stat:type (stat #$%readymedia-default-cache-directory)) + 'directory) + marionette)) + (test-assert "cache directory has correct ownership" + (marionette-eval + '(let ((cache-dir (stat #$%readymedia-default-cache-directory)) + (user (getpwnam #$%readymedia-user-account))) + (and (eqv? (stat:uid cache-dir) (passwd:uid user)) + (eqv? (stat:gid cache-dir) (passwd:gid user)))) + marionette)) + (test-assert "cache directory has expected permissions" + (marionette-eval + '(eqv? (stat:perms (stat #$%readymedia-default-cache-directory)) + #o755) + marionette)) + (test-assert "cache file exists" + (marionette-eval + '(begin + ;; Allow some time for the file to be created. + (sleep 2) + (file-exists? #$%readymedia-cache-path)) + marionette)) + (test-assert "cache file has expected permissions" + (marionette-eval + '(begin + (eqv? (stat:perms (stat #$%readymedia-cache-path)) + #o644)) + marionette)) + (test-assert "cache file is non-empty" + (marionette-eval + '(begin + (> (stat:size (stat #$%readymedia-cache-path)) 0)) + marionette)) + + ;; Log directory and file. + (test-assert "log directory exists" + (marionette-eval + '(eq? (stat:type (stat #$%readymedia-default-log-directory)) + 'directory) + marionette)) + (test-assert "log directory has correct ownership" + (marionette-eval + '(let ((log-dir (stat #$%readymedia-default-log-directory)) + (user (getpwnam #$%readymedia-user-account))) + (and (eqv? (stat:uid log-dir) (passwd:uid user)) + (eqv? (stat:gid log-dir) (passwd:gid user)))) + marionette)) + (test-assert "log directory has expected permissions" + (marionette-eval + '(eqv? (stat:perms (stat #$%readymedia-default-log-directory)) + #o755) + marionette)) + (test-assert "log file exists" + (marionette-eval + '(file-exists? #$%readymedia-log-path) + marionette)) + (test-assert "log file has expected permissions" + (marionette-eval + '(eqv? (stat:perms (stat #$%readymedia-log-path)) + #o640) + marionette)) + (test-assert "log file is non-empty" + (marionette-eval + '(> (stat:size (stat #$%readymedia-log-path)) 0) + marionette)) + + ;; Service. + (test-assert "ReadyMedia service is running" + (marionette-eval + '(begin + (use-modules (gnu services herd) + (srfi srfi-1)) + (live-service-running + (find (lambda (live-service) + (memq 'readymedia + (live-service-provision live-service))) + (current-services)))) + marionette)) + (test-assert "ReadyMedia service is listening for connections" + (wait-for-tcp-port #$%readymedia-default-port marionette)) + + (test-end)))) + + (gexp->derivation "readymedia-test" test)) + +(define %test-readymedia + (system-test + (name "readymedia") + (description "Test the ReadyMedia service.") + (value (run-readymedia-test))))