From patchwork Sun Mar 23 14:25:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 40735 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9059F27BBEA; Sun, 23 Mar 2025 14:26:44 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6657827BBE2 for ; Sun, 23 Mar 2025 14:26:44 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1twMHK-00032R-U9; Sun, 23 Mar 2025 10:26:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twMHI-00031Q-UF for guix-patches@gnu.org; Sun, 23 Mar 2025 10:26:17 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1twMHI-0005Vl-L9 for guix-patches@gnu.org; Sun, 23 Mar 2025 10:26:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=wZDaJpSBiec4HWURn73Fvz7bhdz1AmvaDkV9vu9Mxas=; b=shCv6bNb/ZzKdPKMNUAFsLvf5hqGG4Npx2ZrNTbA+AUHp2z+8FT/Ce5knpmfxMlLcT6eW0PRtpLSQmVf/BI/XOn3TlyVtL5T/pa6HQRyO2m9FRn8taD4C7LVrmNVPV7ZCJ6qJ8mOi08Zs67ZZlYIkARKPeHZ7a6zhuy4QdCMRpx9mM8T1d/b+Mow1flozR9Gc+l9gxWUy+7ZcfD06hIq+1VqdFhh3+OpoSXOkC1131OeRZ3HSsYEIRSMcdUIKqyHFhG6PO4i7RS3penXR71ex/mSQr2UFNAXo7t8lf12/KHjqZTVqTjolg1X0lm5ixpKAU0zJrBa751WnSTh6kpPCA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1twMHI-0005Ym-FT for guix-patches@gnu.org; Sun, 23 Mar 2025 10:26:16 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#75810] [PATCH v8 08/16] daemon: Create /var/guix/profiles/per-user unconditionally. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 23 Mar 2025 14:26:16 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75810 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75810@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= Received: via spool by 75810-submit@debbugs.gnu.org id=B75810.174273997221316 (code B ref 75810); Sun, 23 Mar 2025 14:26:16 +0000 Received: (at 75810) by debbugs.gnu.org; 23 Mar 2025 14:26:12 +0000 Received: from localhost ([127.0.0.1]:51885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twMHD-0005XS-NV for submit@debbugs.gnu.org; Sun, 23 Mar 2025 10:26:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43758) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twMGm-0005Qy-Ds for 75810@debbugs.gnu.org; Sun, 23 Mar 2025 10:25:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twMGg-0005Sa-Oq; Sun, 23 Mar 2025 10:25:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=wZDaJpSBiec4HWURn73Fvz7bhdz1AmvaDkV9vu9Mxas=; b=jYLCfniuJCpvrDoUzkAG pRd3U8YKuIK9mKyJFfefwjCywQ5dLkq/RZ8NIRm4IEMEmBLAMDsIbgB+RakeqrrxqfkP1zZ5a2WI7 b8xLT8ONUYBTpUPitilTUnyEGmM4tE2wkmMx/mmqx+sd3ZFzGacD1WJNoS9QZs8ooT9rhmzwUD898 wiUhGOaOrQB6YXszuQxp22/hUT8WGQ4ptLreM8C64IWMalaIBCilVkNopwzfl9lTHJxfwsTgzGEyx dGP6wYxt/IYXSYm10Q/YjEZi9qiWbmMTJ38V2G+lkG5l0ZpYtRX4zbGkxoAriQHztcc8ZnYECWpbU oMVDElBdw5TCdw==; From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Sun, 23 Mar 2025 15:25:01 +0100 Message-ID: <873abbe1f3ccd790863ffd5687fe2cf7a7ce2ddb.1742739609.git.ludo@gnu.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * nix/libstore/local-store.cc (LocalStore::LocalStore): Create ‘perUserDir’ unconditionally. Change-Id: I5188320f9630a81d16f79212d0fffabd55d94abe --- nix/libstore/local-store.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/nix/libstore/local-store.cc b/nix/libstore/local-store.cc index 83e6c3e16e..f6540c2117 100644 --- a/nix/libstore/local-store.cc +++ b/nix/libstore/local-store.cc @@ -79,12 +79,12 @@ LocalStore::LocalStore(bool reserveSpace) createSymlink(profilesDir, gcRootsDir + "/profiles"); } - /* Optionally, create directories and set permissions for a - multi-user install. */ + Path perUserDir = profilesDir + "/per-user"; + createDirs(perUserDir); + + /* Optionally, set permissions for a multi-user install. */ if (getuid() == 0 && settings.buildUsersGroup != "") { - Path perUserDir = profilesDir + "/per-user"; - createDirs(perUserDir); if (chmod(perUserDir.c_str(), 0755) == -1) throw SysError(format("could not set permissions on '%1%' to 755") % perUserDir);