mbox

[bug#36978,0/3] Add Unknown Horizons and dependencies

Message ID 8736ibtogp.fsf@cbaines.net
Headers show

Message

Christopher Baines Aug. 8, 2019, 8:02 p.m. UTC 
This patch series adds the Unknown Horizons game, and a couple of it's
dependencies.


Christopher Baines (3):
  gnu: Add fifechan.
  gnu: Add fifengine.
  gnu: Add unknown-horizons.

 gnu/packages/games.scm | 127 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 127 insertions(+)

Comments

Ludovic Courtès Aug. 23, 2019, 9:09 p.m. UTC | #1 
Hi Chris,

Christopher Baines <mail@cbaines.net> skribis:

> This patch series adds the Unknown Horizons game, and a couple of it's
> dependencies.

Looks all good to me!  :-)

Ludo’.
Arun Isaac Aug. 25, 2019, 6:09 a.m. UTC | #2 
>> This patch series adds the Unknown Horizons game, and a couple of it's
>> dependencies.
>
> Looks all good to me!  :-)

fifengine and unknown-horizons do have tests, though. Could you try
packaging them?
Arun Isaac Oct. 7, 2019, 9:19 p.m. UTC | #3 
> The unknown-horizons tests seem fine, but the fifengine tests don't all
> seem to run, so I've left them disabled. I don't really get what the
> test runner is doing.

Neither did I manage to completely figure out the fifengine tests. Hence
my incomplete patches. Please feel free to push without the tests or
with any other appropriate comments.
Christopher Baines Oct. 8, 2019, 6:38 p.m. UTC | #4 
Arun Isaac <arunisaac@systemreboot.net> writes:

>> The unknown-horizons tests seem fine, but the fifengine tests don't all
>> seem to run, so I've left them disabled. I don't really get what the
>> test runner is doing.
>
> Neither did I manage to completely figure out the fifengine tests. Hence
> my incomplete patches. Please feel free to push without the tests or
> with any other appropriate comments.

Ok, cool. I've pushed the patches now as
a1c1943b7c49dfb6aef9a98b2cbce0d31cbed08b.

Now I just need to work out how to play the game!

Thanks,

Chris