diff mbox series

[bug#37277,PATCHES] Thunar: Update to 1.8.9.

Message ID 8736hedc16.fsf@lprndn.info
State Accepted
Headers show
Series [bug#37277,PATCHES] Thunar: Update to 1.8.9. | expand

Commit Message

L p R n d n Sept. 2, 2019, 2:10 p.m. UTC

Comments

Ludovic Courtès Sept. 8, 2019, 12:33 p.m. UTC | #1 
L  p R n  d n    <guix@lprndn.info> skribis:

>>From 49d9ed778206d6af039029298f0f8f9aa47171ae Mon Sep 17 00:00:00 2001
> From: L  p R n  d n <guix@lprndn.info>
> Date: Mon, 19 Aug 2019 14:01:52 +0200
> Subject: [PATCH 13/19] gnu: Thunar: Update to 1.8.9.
>
> * gnu/packages/xfce.scm (thunar): Update to 1.8.9.
> [propagated-inputs] Add gtk+.
> ---
>  gnu/packages/xfce.scm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index b27e489678..db8387b9ad 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.")
>  (define-public thunar
>    (package
>      (name "thunar")
> -    (version "1.8.7")
> +    (version "1.8.9")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "http://archive.xfce.org/src/xfce/"
> @@ -649,11 +649,14 @@ like appearance, display, keyboard and mouse settings.")
>                                    "Thunar-" version ".tar.bz2"))
>                (sha256
>                 (base32
> -                "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))
> +                "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)))
> +    (propagated-inputs
> +     ;; Required by thunarx-3.pc
> +     `(("gtk+" ,gtk+)))

Hi!  We usually propagated in similar cases.  However, here that would
lead to propagating all of gtk+ to the user’s profile, which is
undesirable.  Furthermore, since thunar has only two dependents, it’s
probably not a problem if we don’t propagate gtk+.

WDYT?

Thanks,
Ludo’.
diff mbox series

Patch

From d060bbbe43867160abbe2be836d1ebb035007c80 Mon Sep 17 00:00:00 2001
From: L  p R n  d n <guix@lprndn.info>
Date: Mon, 19 Aug 2019 14:03:37 +0200
Subject: [PATCH 14/19] gnu: Thunar: Add gobject-introspection support.

* gnu/packages/xfce.scm (thunar)[native-inputs]: Add gobject-introspection.
---
 gnu/packages/xfce.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index db8387b9ad..53379b2d2c 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -653,6 +653,7 @@  like appearance, display, keyboard and mouse settings.")
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
+       ("gobject-introspection" ,gobject-introspection)
        ("intltool" ,intltool)))
     (propagated-inputs
      ;; Required by thunarx-3.pc
-- 
2.22.0