mbox

[bug#38754,0/2] Speed up the derivation linter.

Message ID 8736d7rnzg.fsf@cbaines.net
Headers show

Message

Christopher Baines Dec. 26, 2019, 5:33 p.m. UTC 
These patches speed up the derivation linter by reducing the number of
times a connection to the guix-daemon is established. In testing on my
computer, the time to lint all guix packages with the derivation linter
drops from around 6 minutes to around 3 minutes.


Christopher Baines (2):
  guix: lint: Add an optional parameter for a store connection.
  scripts: lint: Set the %link-checker-store-connection parameter.

 guix/lint.scm         | 42 ++++++++++++++++++++++++++----------------
 guix/scripts/lint.scm | 22 +++++++++++++---------
 2 files changed, 39 insertions(+), 25 deletions(-)

Comments

Ludovic Courtès Dec. 30, 2019, 10:01 p.m. UTC | #1 
Hi,

Christopher Baines <mail@cbaines.net> skribis:

> These patches speed up the derivation linter by reducing the number of
> times a connection to the guix-daemon is established. In testing on my
> computer, the time to lint all guix packages with the derivation linter
> drops from around 6 minutes to around 3 minutes.

Neat.

> Christopher Baines (2):
>   guix: lint: Add an optional parameter for a store connection.
>   scripts: lint: Set the %link-checker-store-connection parameter.

LGTM, thanks!  :-)

Ludo’.