From patchwork Mon Mar 30 18:28:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Soo X-Patchwork-Id: 20999 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A243627BBE1; Mon, 30 Mar 2020 19:29:11 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 2589B27BBEA for ; Mon, 30 Mar 2020 19:29:11 +0100 (BST) Received: from localhost ([::1]:54702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIz9q-0003iP-ID for patchwork@mira.cbaines.net; Mon, 30 Mar 2020 14:29:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45105) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIz9k-0003iG-9F for guix-patches@gnu.org; Mon, 30 Mar 2020 14:29:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIz9i-00006J-Si for guix-patches@gnu.org; Mon, 30 Mar 2020 14:29:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51736) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIz9i-00004s-Gu for guix-patches@gnu.org; Mon, 30 Mar 2020 14:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jIz9i-0008CU-7H for guix-patches@gnu.org; Mon, 30 Mar 2020 14:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40258] [PATCH] gnu: Add emacs-flycheck-elm. Resent-From: John Soo Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Mar 2020 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40258 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 40258@debbugs.gnu.org Received: via spool by 40258-submit@debbugs.gnu.org id=B40258.158559289731463 (code B ref 40258); Mon, 30 Mar 2020 18:29:02 +0000 Received: (at 40258) by debbugs.gnu.org; 30 Mar 2020 18:28:17 +0000 Received: from localhost ([127.0.0.1]:35049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIz8y-0008BP-JQ for submit@debbugs.gnu.org; Mon, 30 Mar 2020 14:28:16 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:53385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIz8w-0008BA-4m for 40258@debbugs.gnu.org; Mon, 30 Mar 2020 14:28:15 -0400 Received: by mail-pj1-f65.google.com with SMTP id l36so7992197pjb.3 for <40258@debbugs.gnu.org>; Mon, 30 Mar 2020 11:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vtgTyhnToZnydHMPEo/o+z/BG1sXREHxWc6/yYYv9KY=; b=u/t1USguDTDpA3dKclXUXPG2mHF88wCSU9nUj9s1b85gWaJZ6WclwQfPEWNRPghED5 hEnL8x8eGdn3i1zOKSsiKmfklr1Pa9O53gXwEuTx6NPmAfE6yqOo2JsHhhlWKdXKIZ9k VrzJAPKhOEdAhH1/kajPIKeirdG4KRnfF23I51GGQfJ5KDwySxeoIPlOElCN0hdsQfkz jK5emtTWqoMPhHNiM2lOQfsDCA4pWb/yuLtv79nthB8XEMCehQ6TZhY1xDwml2L/e6Vz oIUvci7NcyoGxnZav7MVlbB/izaklZkxPARvS9I0QY1wveQlY+vC0AyzQxNPrPCJ2gsi HcGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vtgTyhnToZnydHMPEo/o+z/BG1sXREHxWc6/yYYv9KY=; b=Akc59Zaz+wNnIELJ5WE7nTEdn+nkk0p7KRFk1EH6rMeyBQFN9fKfofRHH8bd3tDe3D RwpITlyG9Ci+ENxIriheGzCJ0SmziQ6lJH8NOzWtZ5HkimylfZWCh1sYCx2NNhMYzoIX kdoe0DYUyZYlr+uqJj+B6Gi/9mIIeGH1x8T0Al+tX9nAxkpmw4rNagqK0RVgpi3bkg5d W3tuC0Aaj2LyOTLRsNAVyQiDxiC9UQVTOyGlIzHRPiKSRzeOfFxCMZBcmF14ppRkS2Tj XlL5jnhCQwYmwh6Ig8l7jhfUh5Rz0F868ya8iGY4kVoYyf1/TiSeK/ZlcKVWQQZ8hW1V 0g7g== X-Gm-Message-State: AGi0PuZq4N+0gyfCVnPK9GhBB3V6rrUORxxZMKTGv0mpBG28YsGZMyop v3HpOKzv1haEOa5zAowyLAIOwW9u4K3EkQ== X-Google-Smtp-Source: APiQypICOIMmAu8FbkFVtOV7JVqrpmReN1yZ5vuPrhTS0z+BfYvwCwDnHcvNTJ15MAlXfdSSYUOpTA== X-Received: by 2002:a17:90a:c257:: with SMTP id d23mr742183pjx.192.1585592887862; Mon, 30 Mar 2020 11:28:07 -0700 (PDT) Received: from ecenter ([2600:1700:83b0:8bd0::6c3]) by smtp.gmail.com with ESMTPSA id c2sm10045256pgi.65.2020.03.30.11.28.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Mar 2020 11:28:06 -0700 (PDT) From: John Soo References: <87tv29iieh.fsf@asu.edu> <87pncw43rc.fsf@asu.edu> <87d08u7zv5.fsf@nicolasgoaziou.fr> Date: Mon, 30 Mar 2020 11:28:05 -0700 In-Reply-To: <87d08u7zv5.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Mon, 30 Mar 2020 15:10:06 +0200") Message-ID: <87369pwvd6.fsf@asu.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Nicolas, Thanks again! Nicolas Goaziou writes: >> +;;; Copyright © 2020 John Soo > > You can remove this line, already applied in a previous patch. I rebased on master so that should not be in this patch. >> +(define-public emacs-flycheck-elm >> + (package >> + (name "emacs-flycheck-elm") >> + (version "debd0af") > > This is not a proper version string (not monotonic). You should bind > `commit' to "debd0af563cb6c2944367a691c7fa3021d9378c1" and `revision' to > "O" at the top of your package definition, and use > > (version (git-version "0" revision commit)) > >> + (commit version))) > > In the case above, this should be: > > (commit commit) Done, thank you! I was confused what version to use there. >> + (inputs >> + `(("emacs-flycheck" ,emacs-flycheck) >> + ("emacs-let-alist" ,emacs-let-alist) >> + ("emacs-seq" ,emacs-seq))) > > I don't think you need "emacs-seq" since we build packages with Emacs > 26.3, which includes "seq.el" already. It builds just fine without seq, so I removed it. >> + (build-system emacs-build-system) >> + (home-page "https://github.com/bsermons/flycheck-elm") >> + (synopsis "Flycheck support for the elm language") >> + (description "Flycheck support for the elm language.") > > Nitpick: I would use Elm. Done. > The description needs to be a full sentence. Done. Though there really is not much there. It might need revision. >> + (license license:gpl2+))) > > All source code files are GPL3+, so this probably makes the project > GPL3+ licensed. LICENSE file is GPL2 (not 2+), but I would trust source > code in this case. > > You may want to tell upstream about this discrepancy. I reported the issue and put a comment over the license field. > Could you send an updated patch? Updated patch attached. Thanks so much, John From b3a7da54b71adaf0323a73b77c5c36983c80ada4 Mon Sep 17 00:00:00 2001 From: John Soo Date: Thu, 19 Mar 2020 09:57:31 -0700 Subject: [PATCH] gnu: Add emacs-flycheck-elm. * gnu/packages/emacs-xyz.scm (emacs-flycheck-elm): New variable. --- gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c029d1ed3d..f62e075e76 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -21965,3 +21965,31 @@ enables modal editing and composition of commands, too. It combines ideas of other Editors like Vim or Kakoune and tries to align them with regular Emacs conventions.") (license license:gpl3+))) + +(define-public emacs-flycheck-elm + (let ((revision "0") + (commit "debd0af563cb6c2944367a691c7fa3021d9378c1")) + (package + (name "emacs-flycheck-elm") + (version (git-version "0" revision commit)) + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/bsermons/flycheck-elm") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1vl0lss2n50pz5wscqj6vhjwb4hbg8xx2chh5vafsrnn0a3fryrd")))) + (inputs + `(("emacs-flycheck" ,emacs-flycheck) + ("emacs-let-alist" ,emacs-let-alist))) + (build-system emacs-build-system) + (home-page "https://github.com/bsermons/flycheck-elm") + (synopsis "Flycheck support for the Elm") + (description "Flycheck-elm adds flycheck support for Elm.") + ;; License file out of sync with source + ;; See https://github.com/bsermons/flycheck-elm/issues/18 + (license license:gpl3+)))) -- 2.26.0