From patchwork Sat Nov 20 23:04:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vivien Kraus X-Patchwork-Id: 34712 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 115B027BBE3; Sat, 20 Nov 2021 23:06:12 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 93D5A27BBE1 for ; Sat, 20 Nov 2021 23:06:11 +0000 (GMT) Received: from localhost ([::1]:45570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moZQw-00083n-K1 for patchwork@mira.cbaines.net; Sat, 20 Nov 2021 18:06:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moZQp-00082C-47 for guix-patches@gnu.org; Sat, 20 Nov 2021 18:06:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60516) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moZQo-0007Rj-Rh for guix-patches@gnu.org; Sat, 20 Nov 2021 18:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moZQo-0005aO-GQ for guix-patches@gnu.org; Sat, 20 Nov 2021 18:06:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52009] [PATCH core-updates-frozen] openresolv: Wrap it. Resent-From: Vivien Kraus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Nov 2021 23:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52009 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52009@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163744951421397 (code B ref -1); Sat, 20 Nov 2021 23:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Nov 2021 23:05:14 +0000 Received: from localhost ([127.0.0.1]:43828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moZQ2-0005Z2-Gs for submit@debbugs.gnu.org; Sat, 20 Nov 2021 18:05:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:47142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moZPy-0005Yo-3t for submit@debbugs.gnu.org; Sat, 20 Nov 2021 18:05:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moZPx-0007wk-Ax for guix-patches@gnu.org; Sat, 20 Nov 2021 18:05:09 -0500 Received: from [2a00:5881:4008:2810::309] (port=48540 helo=planete-kraus.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1moZPu-0007DF-Tx for guix-patches@gnu.org; Sat, 20 Nov 2021 18:05:08 -0500 Received: from planete-kraus.eu (localhost.lan [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id 76394dbf for ; Sat, 20 Nov 2021 23:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h=from :to:subject:date:message-id:mime-version:content-type; s=dkim; bh=tF1UReLZhzgC0CfsSz/sa/vgXSc=; b=Va1U1jQmwMuZ7NvUa7IbepleyTNB TDX7l5iIWkwwT4M6/3c7BIvIUxQKspKSbJy946PXpnHJyKloqrrB0N9Tn+/hSArw gqxoFDwBc+7POXEezqzY2UAI2gKp3lIOnAOth19rZIauXcvIBa38FhRGxbZp/Iir kBxG8N/tOFXN9Ro= Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id bd5590bd (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Sat, 20 Nov 2021 23:04:56 +0000 (UTC) Date: Sun, 21 Nov 2021 00:04:49 +0100 Message-ID: <8735nq5sz2.fsf@planete-kraus.eu> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:5881:4008:2810::309 (failed) Received-SPF: pass client-ip=2a00:5881:4008:2810::309; envelope-from=vivien@planete-kraus.eu; helo=planete-kraus.eu X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Vivien Kraus X-ACL-Warn: , Vivien Kraus via Guix-patches X-Patchwork-Original-From: Vivien Kraus via Guix-patches via From: Vivien Kraus X-getmail-retrieved-from-mailbox: Patches Dear guix, When I boot my system on core-updates-frozen, I get an error message: /gnu/store/xxx-openresolv-3.12.0/sbin/resolvconf: line 824: mkdir: command not found Failed to create needed directory /var/run/resolvconf I didn’t experience any DNS issue, but my network is simple on that machine. In any case, I think it would do no harm to wrap resolvconf to set its path to the coreutils so that it can find mkdir and rm. I didn’t find resolvconf to invoke any other program. What do you think? Best regards, Vivien From 426c613e226b5c7e041d6a8476c09abfeffe151c Mon Sep 17 00:00:00 2001 From: Vivien Kraus Date: Sat, 20 Nov 2021 23:48:17 +0100 Subject: [PATCH] gnu: openresolv: Wrap resolvconf. * gnu/packages/dns.scm (openresolv) [phases]: Wrap resolvconf to set PATH, for coreutils programs mkdir and rm. * gnu/packages/dns.scm (openresolv) [inputs]: Add coreutils, and bash-minimal to run the wrapper and the wrapped script. --- gnu/packages/dns.scm | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index b289aa999e..55c6c0d82d 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -1417,7 +1417,18 @@ (define-public openresolv #:configure-flags (list (string-append "--sysconfdir=/etc")) #:make-flags - (list (string-append "SYSCONFDIR=/" (assoc-ref %outputs "out") "/etc")))) + (list (string-append "SYSCONFDIR=/" (assoc-ref %outputs "out") "/etc")) + #:phases + (modify-phases %standard-phases + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (coreutils (assoc-ref inputs "coreutils"))) + (wrap-program (string-append out "/sbin/resolvconf") + `("PATH" ":" = (,(string-append coreutils "/bin")))))))))) + (inputs + `(("bash-minimal" ,bash-minimal) + ("coreutils" ,coreutils))) (home-page "https://roy.marples.name/projects/openresolv/") (synopsis "Resolvconf POSIX compliant implementation, a middleman for resolv.conf") (description "openresolv is an implementation of @command{resolvconf}, the -- 2.34.0