diff mbox series

[bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio

Message ID 871rgrkxvh.fsf@gmail.com
State Accepted
Headers show
Series [bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio | expand

Checks

Context Check Description
cbaines/submitting builds success
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Oleg Pykhalov Nov. 18, 2020, 6 a.m. UTC
Hello,

According to Git bisect, the 977eb5d0 commit breaks docker-service-type
with the following error during “guix system build” or “guix system
reconfigure”:

    guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service


The following patch fixes this.
Oleg.

Comments

Danny Milosavljevic Nov. 18, 2020, 4:26 p.m. UTC | #1
Hi,

On Wed, 18 Nov 2020 09:00:34 +0300
Oleg Pykhalov <go.wigust@gmail.com> wrote:

> According to Git bisect, the 977eb5d0 commit breaks docker-service-type
> with the following error during “guix system build” or “guix system
> reconfigure”:
> 
>     guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service

I can confirm this bug.

However, I cannot say one way or another where the patch is the right fix.
Marius Bakke Nov. 18, 2020, 9:26 p.m. UTC | #2
Danny Milosavljevic <dannym@scratchpost.org> skriver:

> Hi,
>
> On Wed, 18 Nov 2020 09:00:34 +0300
> Oleg Pykhalov <go.wigust@gmail.com> wrote:
>
>> According to Git bisect, the 977eb5d0 commit breaks docker-service-type
>> with the following error during “guix system build” or “guix system
>> reconfigure”:
>> 
>>     guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service
>
> I can confirm this bug.
>
> However, I cannot say one way or another where the patch is the right fix.

I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459,
can you confirm?
Danny Milosavljevic Nov. 19, 2020, 12:26 a.m. UTC | #3
Hi,

On Wed, 18 Nov 2020 22:26:38 +0100
Marius Bakke <marius@gnu.org> wrote:

> I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459,
> can you confirm?

Yes, it is indeed fixed for me.
Oleg Pykhalov Nov. 20, 2020, 5:11 a.m. UTC | #4
Marius Bakke <marius@gnu.org> writes:

[…]

> I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459,
> can you confirm?

Yes, closing the issue.
diff mbox series

Patch

From dcc259c3a33a470eee761f4deadf9149f0a65c55 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Wed, 18 Nov 2020 08:57:05 +0300
Subject: [PATCH] Fix file-system->shepherd-service-name.

This commit follow 977eb5d023cfdf8e336f1896480eea9cef5c04e9, which breaks
docker-service-type with error:

guix system: error: service 'dockerd' requires
'file-system-/sys/fs/cgroup/blkio', which is not provided by any service

* gnu/services/base.scm (file-system->shepherd-service-name): Add '/' to
valid characters.
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 712b3a018f..6fc966e268 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -288,7 +288,7 @@  FILE-SYSTEM."
   (define valid-characters
     ;; Valid store characters; see 'checkStoreName' in the daemon.
     (string->char-set
-     "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+-._?="))
+     "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+-._?=/"))
 
   (define mount-point
     (string-map (lambda (chr)
-- 
2.29.2