From patchwork Sat Aug 27 03:15:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Artyom V. Poptsov" X-Patchwork-Id: 41986 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 22F1927BBEA; Sat, 27 Aug 2022 04:17:19 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8013327BBE9 for ; Sat, 27 Aug 2022 04:17:18 +0100 (BST) Received: from localhost ([::1]:46966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRmJx-0005dI-MB for patchwork@mira.cbaines.net; Fri, 26 Aug 2022 23:17:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRmJj-0005ca-1x for guix-patches@gnu.org; Fri, 26 Aug 2022 23:17:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36945) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRmJi-0000rd-Ie for guix-patches@gnu.org; Fri, 26 Aug 2022 23:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRmJi-0004WO-3k for guix-patches@gnu.org; Fri, 26 Aug 2022 23:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57365] [PATCH] gnu: guile-smc: Update to 0.5.0 Resent-From: "Artyom V. Poptsov" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Aug 2022 03:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57365 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 57365@debbugs.gnu.org Received: via spool by 57365-submit@debbugs.gnu.org id=B57365.166157017217319 (code B ref 57365); Sat, 27 Aug 2022 03:17:02 +0000 Received: (at 57365) by debbugs.gnu.org; 27 Aug 2022 03:16:12 +0000 Received: from localhost ([127.0.0.1]:54927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRmIu-0004VG-6g for submit@debbugs.gnu.org; Fri, 26 Aug 2022 23:16:12 -0400 Received: from mail-lf1-f48.google.com ([209.85.167.48]:38625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRmIs-0004V4-It for 57365@debbugs.gnu.org; Fri, 26 Aug 2022 23:16:11 -0400 Received: by mail-lf1-f48.google.com with SMTP id q7so4243630lfu.5 for <57365@debbugs.gnu.org>; Fri, 26 Aug 2022 20:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc; bh=qea8ExNMqI7b6xoxTW/KqYwxK3QqG9TxLd3pmhnWXsw=; b=g9//qj4MUFL1lztnCxbvBU3dUY7CXk9+m5Om01CyKHWv8RZ0TEMbOi7tu+Ce3pEY5R +ZODdJS6tJU5vNMvKlc1U8hh4zW526dvX5k0ME0qTs9W7GHRNN8AdM3RPLoSqj5nY6Fj YKeAeWMTjCNTJDR9QQDI7GKh6PBq5pca3tkRbqDKDjh5NzkSIFvfJborBB+Fd65A9h8N JqbRS1VBmGlIxzUcIE6Kq5rp0XktvP4LTmCzZffIpd2Q2OJOP0MsXqygF/A0rlw1GvQT /4LZ2GOFC4BW/DuqDLDOkvCcedj/V70hvTSne6ulmqK9+XPDR5Wz2mM39PrPQbImZUNM QiEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=qea8ExNMqI7b6xoxTW/KqYwxK3QqG9TxLd3pmhnWXsw=; b=QJiI01aA2Xqv5YFwGqx39L/+wZ/cVewNThN9W6JRalU6dDG16dipB0fPtyn4//q96d D0mzklBsiq55UJ6eMQdw0b+cT2sevs5N78REBlpCvilfcpAkeF7kwlWR8pNe7q3aD3ry gieBiEPZNRKThddqOMt4Q+YfDtQekr/pDMY8OOEhwxHRaqOHPrf+l2S6zoe+HWAksBI4 h3SyMTyZpj9lLf3DB8zHuIvpZw+PQHF0+HjnueQ3gWOkXU1whYCUC+xZuM4Mn/1V9fGh nuONOWjr45ECHh8h01lM8+1feb8cpUHBPT9wIIV2IHii3a03QaL2knYdm0LTi7VVvLqt j2ng== X-Gm-Message-State: ACgBeo0uzg7efmA9jenXYHlDypOS8F0UkfKTasM3nEzKBJFXR6GsYLl+ vVXT6HoXim5I8p3H2DkqC0ZimfdLsCA= X-Google-Smtp-Source: AA6agR7pxO5iM7HrlfL4uDNtxAyEesvL3f4sVlZtdrUOuseYfsq/ZcvousTN1Expfwr+Yj/8gwlABw== X-Received: by 2002:a05:6512:c06:b0:48d:1d99:2a1a with SMTP id z6-20020a0565120c0600b0048d1d992a1amr3686548lfu.396.1661570163941; Fri, 26 Aug 2022 20:16:03 -0700 (PDT) Received: from elephant ([95.79.19.43]) by smtp.gmail.com with ESMTPSA id u21-20020a2e1415000000b00261b9df2ca2sm626956ljd.51.2022.08.26.20.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 20:16:03 -0700 (PDT) From: "Artyom V. Poptsov" References: <87pmgqsss3.fsf@gmail.com> <874jxzyvpv.fsf@gnu.org> Date: Sat, 27 Aug 2022 06:15:59 +0300 In-Reply-To: <874jxzyvpv.fsf@gnu.org> (Mathieu Othacehe's message of "Fri, 26 Aug 2022 15:34:36 +0200") Message-ID: <871qt2v0k0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Mathieu, Thanks for my patch review! > What is this patch about? Can't it be upstreamed? As you can see from the package description of Guile-SMC 0.3.0 there was already a problem with logging; I just tried to fix that patch for the current release. Guile-SMC tries to log to the syslog by default but it seems that this option is not working in Guix, so we need another way to log the messages. Or it may be that I just overlooked something. I wasn't able to use "" anymore as Guile-SMC now uses custom microsecond-resolution logging backend (which is required for the FSM profiler to work properly.) The problem is that this backend does not work well with "". With the new snipped Guile-SMC uses its "" class to log the messages to "/tmp/smc.log." file. I wish we had more advanced logging functionality in GNU Guile core modules but that a discussion for another thread I think. For now I agree that this snipped looks a bit hacky but that is the solution a I came up with trying to fix things fast. If you have any ideas on how to improve the snippet (or the logging in Guile-SMC for that matter), I'm all ears. Meanwhile I try to do something with Guile-SMC logging myself. > You need to describe it in the commit message: > > [native-inputs]: Add help2man. > Ditto: > > [inputs]: Use the new inputs style. Done. Here's the updated patch. - Artyom From be2605d82a44f22391b831a7090ff3ae5956d545 Mon Sep 17 00:00:00 2001 From: "Artyom V. Poptsov" Date: Tue, 23 Aug 2022 21:10:13 +0300 Subject: [PATCH 1/2] gnu: guile-smc: Update to 0.5.0. * gnu/packages/guile-xyz.scm (guile-smc): Update to 0.5.0. [native-inputs]: Add help2man. [inputs]: Use the new inputs style. --- gnu/packages/guile-xyz.scm | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index a85c7e0fc4..69f629638b 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -4796,7 +4796,7 @@ (define-public guile-gitlab (define-public guile-smc (package (name "guile-smc") - (version "0.3.0") + (version "0.5.0") (source (origin (method git-fetch) @@ -4806,7 +4806,7 @@ (define-public guile-smc (file-name (string-append name "-" version)) (sha256 (base32 - "0szkjmasi70m1vppck7nhdxg4lnxzjq6mihi6r1552s8sxm5z008")))) + "03imz9bfvvj8xnwxjaw7b26capvlwq921kqq5yzlzv15ngidky72")))) (build-system gnu-build-system) (arguments `(#:make-flags '("GUILE_AUTO_COMPILE=0") ;to prevent guild warnings @@ -4829,12 +4829,11 @@ (define-public guile-smc (format #f "#:init-value \"~a/bin/logger\"" (assoc-ref inputs "inetutils"))) - (("\\(add-handler! %logger %syslog\\)") - (string-append - "(add-handler! %logger\n" - " (make \n" - " #:file-name \"smc.log\"))\n"))) - #t)) + (("\\(add-handler! %logger %syslog\\)") + (string-append + "(add-handler! %logger\n" + " (make \n" + " #:port (open-file \"/tmp/smc.log\" \"a+\")))\n"))))) (add-after 'install 'wrap-program (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -4854,12 +4853,12 @@ (define-public guile-smc ,(string-append guile-lib go))))) #t))))) (native-inputs - (list autoconf automake pkg-config texinfo)) + (list autoconf automake pkg-config texinfo help2man)) (inputs - `(("bash" ,bash-minimal) - ("guile" ,guile-3.0) - ("guile-lib" ,guile-lib) - ("inetutils" ,inetutils))) + (list bash-minimal + guile-3.0 + guile-lib + inetutils)) (home-page "https://github.com/artyom-poptsov/guile-smc") (synopsis "GNU Guile state machine compiler") (description -- 2.34.1