From patchwork Fri May 20 03:52:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhu Zihao X-Patchwork-Id: 39532 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 06C6127BBEA; Fri, 20 May 2022 04:54:15 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 51C1227BBE9 for ; Fri, 20 May 2022 04:54:14 +0100 (BST) Received: from localhost ([::1]:54140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrtiP-0003nJ-G1 for patchwork@mira.cbaines.net; Thu, 19 May 2022 23:54:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrtiF-0003mv-0V for guix-patches@gnu.org; Thu, 19 May 2022 23:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrtiE-0000Wn-O7 for guix-patches@gnu.org; Thu, 19 May 2022 23:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nrtiE-0001LR-I3 for guix-patches@gnu.org; Thu, 19 May 2022 23:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55517] Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 May 2022 03:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55517 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 55517@debbugs.gnu.org Received: via spool by 55517-submit@debbugs.gnu.org id=B55517.16530188135131 (code B ref 55517); Fri, 20 May 2022 03:54:02 +0000 Received: (at 55517) by debbugs.gnu.org; 20 May 2022 03:53:33 +0000 Received: from localhost ([127.0.0.1]:37171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrthl-0001Kg-6u for submit@debbugs.gnu.org; Thu, 19 May 2022 23:53:33 -0400 Received: from mail-m973.mail.163.com ([123.126.97.3]:64826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrthg-0001KP-5u for 55517@debbugs.gnu.org; Thu, 19 May 2022 23:53:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=UlElh fLAEHncYc4v9shzD5S9wy9VoPhZyEtXUqk86Xw=; b=K54yFpeSc3bFZCWXrbNbX pMitrUStONbqCD2R5OeJUfK3L8CFGm05eeFSpnkkLI1bC2nv2vm5DmqRV1GeguPO U6tnPV3mxQwqx/gDfiICBEL4PfcIZUDmd3KjCy2v0SVi3X5UFYGmkW+7KbrqaEph TCbeeTolOZH92XxPM95bBI= Received: from asus-laptop (unknown [27.38.118.8]) by smtp3 (Coremail) with SMTP id G9xpCgDn_XWtEIdi8qicDg--.1002S2; Fri, 20 May 2022 11:53:19 +0800 (CST) References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Zhu Zihao Date: Fri, 20 May 2022 11:52:51 +0800 In-reply-to: Message-ID: <86leuw507n.fsf@163.com> MIME-Version: 1.0 X-CM-TRANSID: G9xpCgDn_XWtEIdi8qicDg--.1002S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUj18BDUUUU X-Originating-IP: [27.38.118.8] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/xtbBLw8Hr2HmmxbObgAAsi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches From 983a23d9ae1fde345e9ad92f49dbb30e73cc8498 Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Fri, 20 May 2022 11:51:02 +0800 Subject: [PATCH 2/2] gnu: emacs-magit: Drop the libgit backend. Drop the libgit backend for following reasons: 1. The libgit backend of Magitis very incomplete. There's almost no benefits, but extra maintenance efforts. 2. The libgit backend of Magit can be considered as an extra package. And it's still in Proof-Of-Concept status so its quaility doesn't satisfy the requirement of Guix package. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments] : Remove this argument. : Exclude the magit-libgit.el and magit-libgit-pkg.el. [inputs]: Remove emacs-libgit. --- gnu/packages/emacs-xyz.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 8198638c13..d3ca00475e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -870,9 +870,11 @@ (define-public emacs-magit (build-system emacs-build-system) (arguments (list - #:emacs emacs-no-x #:tests? #t #:test-command #~(list "make" "test") + #:exclude #~(cons* "magit-libgit.el" + "magit-libgit-pkg.el" + %default-exclude) #:phases #~(modify-phases %standard-phases (add-after 'unpack 'build-info-manual @@ -920,7 +922,7 @@ (define-public emacs-magit (inputs (list git perl)) (propagated-inputs - (list emacs-dash emacs-libgit emacs-transient emacs-with-editor)) + (list emacs-dash emacs-transient emacs-with-editor)) (home-page "https://magit.vc/") (synopsis "Emacs interface for the Git version control system") (description -- 2.36.0