From patchwork Wed Nov 23 10:42:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhu Zihao X-Patchwork-Id: 44780 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D678927BBED; Wed, 23 Nov 2022 10:46:35 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 4828E27BBEC for ; Wed, 23 Nov 2022 10:46:34 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxnGv-0001Bk-MN; Wed, 23 Nov 2022 05:46:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxnGW-00016N-3P for guix-patches@gnu.org; Wed, 23 Nov 2022 05:46:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxnGU-00031f-I8 for guix-patches@gnu.org; Wed, 23 Nov 2022 05:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxnGU-00077s-A3 for guix-patches@gnu.org; Wed, 23 Nov 2022 05:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59102] [PATCH 2/2] gnu: Add mogan. Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 23 Nov 2022 10:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59102 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 59102@debbugs.gnu.org Received: via spool by 59102-submit@debbugs.gnu.org id=B59102.166920033527352 (code B ref 59102); Wed, 23 Nov 2022 10:46:02 +0000 Received: (at 59102) by debbugs.gnu.org; 23 Nov 2022 10:45:35 +0000 Received: from localhost ([127.0.0.1]:53797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxnG2-000776-Lt for submit@debbugs.gnu.org; Wed, 23 Nov 2022 05:45:35 -0500 Received: from m12.mail.163.com ([220.181.12.197]:51976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxnFx-00076p-3j for 59102@debbugs.gnu.org; Wed, 23 Nov 2022 05:45:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=ZRJHS I08nU1UacaLs/jaKd4qeORimwSaDIHPI3ilxAo=; b=WY69ojqixc3eKxPFjMoWH OfQ2eG7y/L5NNeZb/ANfiPC9mjXE+SZmGgE6+N17fBSDHj1ACYll8toO0/CdKOIf NDqpg5+DkHFa2lsIHMunhRvj7Domk3jM5oM7B75jVxh3VqQSVPfLjD8ixK0hfhpA kCw/AoaclBYzttdpfUaXEA= Received: from asus-laptop (unknown [163.125.249.174]) by zwqz-smtp-mta-g0-2 (Coremail) with SMTP id _____wBX1vq9+X1jqlwPAA--.1065S2; Wed, 23 Nov 2022 18:45:18 +0800 (CST) References: <20221107105827.10327-1-all_but_last@163.com> <20221107105827.10327-2-all_but_last@163.com> <87iljpkvoh.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.8.11; emacs 29.0.50 From: Zhu Zihao Date: Wed, 23 Nov 2022 18:42:09 +0800 In-reply-to: <87iljpkvoh.fsf@nicolasgoaziou.fr> Message-ID: <86leo2t0ee.fsf@163.com> MIME-Version: 1.0 X-CM-TRANSID: _____wBX1vq9+X1jqlwPAA--.1065S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr18Wr17ZF15tF4kCr45Wrg_yoWkuFX_Kr 4vyF92va1IkFs0vw1Fyr4DJFZ7W39rXa40qrWagry0yr1fXanrJFZ7trW7ZFy3Ar45Zrnx Kr1Syay8A3sF9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRGYLBDUUUUU== X-Originating-IP: [163.125.249.174] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/xtbBawDCr1et6xtViwAAsS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Sorry for the late reply! I missed this mail in my mailbox :( Nicolas Goaziou writes: > Unlike TeXmacs, Mogan ships with tests. Could you also run them? The "tests" folder in mogan is inherited from TeXmacs, I think it's OK to not run them if we don't run the test of TeXmacs. > >> + (synopsis "Structural editor delivered by Xmacs Labs") > > I don't think the ads is warranted here. Maybe "Scientific text editor" > is better. > >> + (description >> + "Mogan is a fork of GNU TeXmacs created by Xmacs Labs. Its goal is >> +make everyone to enjoy it fluently and develop new feature for everyone to learn >> +and create science and technology.") > > This description is not very descriptive. I don't have any good idea, > the repository is not very helpful for that matter. At a minimum, > I suggest to remove "created by Xmacs Labs" and separate sentences with > two spaces. The second should also be replaced. > >> + (home-page "https://gitee.com/XmacsLabs/mogan"))) > > Could you move home-page above synopsis? fixed in new patch. I also make Mogan use qt-build-system because Mogan cannot find the breeze icon without XDG environment variables wrapping. From c7d14125e93c497a15c27fb4ac90e1d33efc698c Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Sat, 14 May 2022 22:19:06 +0800 Subject: [PATCH] gnu: Add mogan. * gnu/packages/text-editors.scm (mogan): New variable. --- gnu/packages/text-editors.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm index ed77113726..57341cd198 100644 --- a/gnu/packages/text-editors.scm +++ b/gnu/packages/text-editors.scm @@ -49,6 +49,7 @@ (define-module (gnu packages text-editors) #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system meson) #:use-module (guix build-system python) + #:use-module (guix build-system qt) #:use-module ((guix licenses) #:prefix license:) #:use-module (gnu packages) #:use-module (gnu packages aspell) @@ -59,6 +60,7 @@ (define-module (gnu packages text-editors) #:use-module (gnu packages code) #:use-module (gnu packages cpp) #:use-module (gnu packages crates-io) + #:use-module (gnu packages curl) #:use-module (gnu packages datastructures) #:use-module (gnu packages documentation) #:use-module (gnu packages fontutils) @@ -895,6 +897,39 @@ (define-public texmacs (license license:gpl3+) (home-page "https://www.texmacs.org/tmweb/home/welcome.en.html"))) +(define-public mogan + (package + (inherit texmacs) + (name "mogan") + (version "1.1.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/XmacsLabs/mogan") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "04wz6xmimjv2l6baxgzm8vyq5grg102m3l4wq8i6bglv529yp4ff")))) + (build-system qt-build-system) + (inputs + (modify-inputs (package-inputs texmacs) + ;; Replaced by S7 scheme + ;; TODO: Maybe unbundle S7 + (delete "guile") + (prepend curl))) + (arguments + (substitute-keyword-arguments (package-arguments texmacs) + ((#:phases orig) + #~(modify-phases #$orig + ;; The non-deterministic compression issue is solved in Mogan. + (delete 'gzip-flags))))) + (home-page "https://github.com/XmacsLabs/mogan") + (synopsis "Scientific structural text editor") + (description + "Mogan is a scientific structural text editor, a fork of GNU TeXmacs.") + (license license:gpl3+))) + (define-public textpieces (package (name "textpieces") -- 2.38.1