From patchwork Wed Oct 19 09:49:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Tournier X-Patchwork-Id: 43712 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A18C327BBEA; Wed, 19 Oct 2022 11:17:24 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 13BD327BBE9 for ; Wed, 19 Oct 2022 11:17:24 +0100 (BST) Received: from localhost ([::1]:55712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ol68Y-0002hS-UU for patchwork@mira.cbaines.net; Wed, 19 Oct 2022 06:17:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol67H-0002fU-74 for guix-patches@gnu.org; Wed, 19 Oct 2022 06:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ol67G-00012n-UC for guix-patches@gnu.org; Wed, 19 Oct 2022 06:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ol67G-0003Rz-Ob for guix-patches@gnu.org; Wed, 19 Oct 2022 06:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58587] [PATCH 00/14] Introducing pyproject-build-system. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 19 Oct 2022 10:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58587 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 58587@debbugs.gnu.org Cc: Lars-Dominik Braun , Maxim Cournoyer Received: via spool by 58587-submit@debbugs.gnu.org id=B58587.166617454913216 (code B ref 58587); Wed, 19 Oct 2022 10:16:02 +0000 Received: (at 58587) by debbugs.gnu.org; 19 Oct 2022 10:15:49 +0000 Received: from localhost ([127.0.0.1]:55890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ol672-0003R0-NQ for submit@debbugs.gnu.org; Wed, 19 Oct 2022 06:15:49 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:53184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ol66v-0003Q7-N2 for 58587@debbugs.gnu.org; Wed, 19 Oct 2022 06:15:46 -0400 Received: by mail-wm1-f51.google.com with SMTP id l32so12600449wms.2 for <58587@debbugs.gnu.org>; Wed, 19 Oct 2022 03:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=CrBTcGEucohhwIaAdYRdST//f2L2StQzwhdiYJ9PbOQ=; b=Wq7OiTedTEpDo7r+LW07YqQpWu15f+EBIoBnFAqvcJbvl9u9jXQvMbxBG2ivLVi6hJ n3AHy5ZSd1Ju+4ojiqOB5BrpKy0ye3VLJBMxyOSfrXJU8VIKsnoyW37ZbM/BTWWQNoA4 AphJHAy7uHLPSevlTACaFUR6wCuQn4np8Y3XQqfitCyFDE+UKZ0ZhoPMkQ3H8MTMHXWC YcHuxQ6EKNV5/4fM8b0USUmuCu1I9wrzo4/d2wtiQivYaPcpKhVeR47f9NFjBXKp6ist Kp6vOYJSSrWMd9KyA2jaoWt3gnSM8uzvvFbXzpKjkkjxn4sj7OkvM+niI3DIY13q3MYN p6Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CrBTcGEucohhwIaAdYRdST//f2L2StQzwhdiYJ9PbOQ=; b=hoN5N5JkqLLZTxmlvOr6gCjnf8FPrfwIklnzv68cUzu2Wzvg47DoDs91/kmbsdcmR1 i2gLbGjsGCNnGNvGFDuMkqPzseNvMQyb76Ts+vVAXb74s4JObdG2P8VJ4BLsra3zTGOn w7rPhjLDe+bGXZsYR1yABjN5shB+SjpflKaTaK8vThShhEJZb3na7Q+jQL1itKqKlAo1 GepQrQHicTxqNkprOgSfWShpi2p0TuGnbCaIIKCDAs/QWfq6yPNjuH6cnxhlpnFslIlP /MxdZFd9K7ldSsyLOOPd/6TgfU8IsyPvN4RraygcIbgdRhJfQCxGzvfuPOeZ1enhUdc4 kXnw== X-Gm-Message-State: ACrzQf1vZl+YMR1vPimzj92zc0jhIutS30LSoU4i3lf3YMDyNJIrDybc ZkLoTF9ygaBavk1Je6qAZGj7XZduw/k= X-Google-Smtp-Source: AMsMyM5Tffot+nr7OTUJAc6Ysqp/RfmXNRkzj2TGgvfEKQuyinYoA5ITrewHlZ1oyIi5LJJ9iFb8lg== X-Received: by 2002:a05:600c:5488:b0:3b5:634:731 with SMTP id iv8-20020a05600c548800b003b506340731mr24607339wmb.188.1666174536134; Wed, 19 Oct 2022 03:15:36 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id h5-20020adfe985000000b002322bff5b3bsm16078000wrm.54.2022.10.19.03.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 03:15:35 -0700 (PDT) From: zimoun In-Reply-To: <877d0wvlzg.fsf@gnu.org> References: <20221017200624.4076-1-marius@gnu.org> <86sfjlzdbn.fsf@gmail.com> <877d0wvlzg.fsf@gnu.org> Date: Wed, 19 Oct 2022 11:49:14 +0200 Message-ID: <86ilkgp2hx.fsf@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Marius, On Tue, 18 Oct 2022 at 23:51, Marius Bakke wrote: > I tried to address this in the attached documentation patch. Neat! > The idea is to: > > * Recommend it for new packages in the 'guix' channel, mostly during > patch review. > * Once we are confident in the implementation, remove the "experimental" > status and recommend it in the documentation. > * Merge pieces of it into python-build-system as we go, such as sanity > check changes, using python-toolchain, etc. > * When we "know" that there won't be any major regressions, swap out > python-build-system with pyproject-build-system entirely and mark the > latter as deprecated. I would add a note, for instance, something like that: > From 628944b6f4267c4eeb5884074298b82c8d17548c Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Tue, 18 Oct 2022 23:38:39 +0200 > Subject: [PATCH] doc: Document pyproject-build-system. > > * doc/guix.texi (Build Systems): Add pyproject-build-system section. > * doc/contributing.texi (Python Modules): Mention pyproject.toml and the > PYTHON-TOOLCHAIN package. LGTM. > --- > doc/contributing.texi | 21 +++++++++++++-------- > doc/guix.texi | 14 ++++++++++++++ > 2 files changed, 27 insertions(+), 8 deletions(-) > > diff --git a/doc/contributing.texi b/doc/contributing.texi > index 4b1eed1cb1..b9260267fa 100644 > --- a/doc/contributing.texi > +++ b/doc/contributing.texi [...] > +@defvr {Scheme Variable} pyproject-build-system > +This is a variable exported by @code{guix build-system pyproject}. It > +is a reimplementation of @code{python-build-system} designed around ^ s/code/var > +@file{pyproject.toml} and @url{https://peps.python.org/pep-0517/, PEP 517}, > +and supports a variety of build backends and test frameworks. > + > +It is considered ``experimental'' in that the implementation details are > +not set in stone yet, however users are encouraged to try it for new > +Python projects (even those using @file{setup.py}) and there should not > +be any breaking changes. > > +Eventually this build system will be deprecated and merged back into > +@code{python-build-system}, probably some time in 2024. Idem Cheers, simon diff --git a/doc/contributing.texi b/doc/contributing.texi index 4b1eed1cb1..17dd4ec7a9 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -786,6 +786,24 @@ for instance, the module python-dateutil is packaged under the names starts with @code{py} (e.g.@: @code{pytz}), we keep it and prefix it as described above. +@quotation Note +Instead of the default Python build system @var{python-build-system} +(@pxref{Build Systems}), we are encouraging to try the ``experimental'' +@var{pyproject-build-system} exported by @code{guix build-system +pyproject}. It is a reimplementation of @var{python-build-system} +designed around @file{pyproject.toml} and +@url{https://peps.python.org/pep-0517/, PEP 517}, and it supports a +variety of build backends and test frameworks. + +It is considered ``experimental'' in that the implementation details are +not set in stone yet. However, there should not be any breaking +changes, so please report any failure for new Python packages (even +those using @file{setup.py}). + +Eventually this @var{pyproject-build-system} will be deprecated and +merged back into @var{python-build-system}, probably some time in 2024. +@end quotation + @subsubsection Specifying Dependencies @cindex inputs, for Python packages