From patchwork Mon Dec 13 20:51:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Munyoki Kilyungi X-Patchwork-Id: 35211 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 89D6027BBEA; Mon, 13 Dec 2021 20:52:18 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D2E8C27BBE9 for ; Mon, 13 Dec 2021 20:52:17 +0000 (GMT) Received: from localhost ([::1]:46258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwsIy-0003GK-Oz for patchwork@mira.cbaines.net; Mon, 13 Dec 2021 15:52:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwsIk-0003Cu-FZ for guix-patches@gnu.org; Mon, 13 Dec 2021 15:52:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwsIk-00043M-6g for guix-patches@gnu.org; Mon, 13 Dec 2021 15:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwsIk-0004sY-5w for guix-patches@gnu.org; Mon, 13 Dec 2021 15:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates Resent-From: Bonface M. K Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 Dec 2021 20:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50117 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 50117@debbugs.gnu.org Received: via spool by 50117-submit@debbugs.gnu.org id=B50117.163942871418740 (code B ref 50117); Mon, 13 Dec 2021 20:52:02 +0000 Received: (at 50117) by debbugs.gnu.org; 13 Dec 2021 20:51:54 +0000 Received: from localhost ([127.0.0.1]:57025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwsIX-0004s8-GG for submit@debbugs.gnu.org; Mon, 13 Dec 2021 15:51:54 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:57521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwsIT-0004rt-OG for 50117@debbugs.gnu.org; Mon, 13 Dec 2021 15:51:48 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3EBFD3201126; Mon, 13 Dec 2021 15:51:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 13 Dec 2021 15:51:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= bonfacemunyoki.com; h=from:to:cc:subject:in-reply-to:references :date:message-id:mime-version:content-type; s=fm3; bh=FtwaNTWKB2 +9UzVnq0VKo2wSTFifyzwMo6jFdkjeY4s=; b=hcQ4Il+VcowlO/Eq1tw694utwg KQjHynZaM21fr2lv6pehyCEE260hq6s7117nBVACWVVAWNp/k9AMZTETexNvIyep +U4TE66hrOwKxbpcrnSuvQ1Y2OO93zlcoSo6k2GXjflfmQZuWzvyJ/PrEzjpg/57 jQKHaWk16UiDrmp1OWCcvjfNIDcD5JkG0wEpLTdeUHpJOxIkekTcTVe8C/MILSIC N8qVKjJx8N99tMm6B5dh8X8476asWiqDTTE3S/Ii/dbZPEjDcKy/uax7PyMDpqVd QRGIf5yKMMDjdqKMlvhD2W/NrzubMUXEoPUULr5DJ/yTAxCzMnoREoSb9VcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=FtwaNT WKB2+9UzVnq0VKo2wSTFifyzwMo6jFdkjeY4s=; b=K7+ZhlGnUk06ShvcfwsW60 zXF7bz/ivZydHfwM8Ue1mXN1/ASBpbFsTr5DeAU6kaUT/0nK/9Xn+/x/Vg1UlK3j 3DgP4sgoaXtgk70aqO9870ptcJoaQj7JHpEl9UB/3tqRDzmJuJ0aiYM/wcRvO6Ol wmW6XfbRs49Y0TCgUUWYazKLVP+/KKOqgu8nxB/Ti8zODF1fzooFNycc5qD59/P8 jsg+6ap4QvmAnOyKA7XQRa7unI7grXyoe9xayANBV8dUd1GRk3J7NimDeWucPBJL 7h6ncBmtGKK6aH8A5tFFAN8vLEWws3e9SxlOjoKtGuxwK5ASqhNIN1dk0u2ftxxg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrkeekgddugeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesghdtreertddttdenucfhrhhomhepuehonhhfrggt vgcuofdrucfmuceomhgvsegsohhnfhgrtggvmhhunhihohhkihdrtghomheqnecuggftrf grthhtvghrnhepffdtueehfeevkeekkefhjeelgeelffevvedvvdejhfdtveekjeeijedu fedtlefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgvsegsohhnfhgrtggvmhhunhihohhkihdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Dec 2021 15:51:37 -0500 (EST) From: Bonface M. K In-Reply-To: <87r1ahf35q.fsf@systemreboot.net> References: <20211210111752.20147-1-me@bonfacemunyoki.com> <87r1ahf35q.fsf@systemreboot.net> Date: Mon, 13 Dec 2021 23:51:33 +0300 Message-ID: <868rwo44a2.fsf@bonfacemunyoki.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Arun Isaac anaandika: > Hi Bonface, > >> Hi all! Find below updated patches from a review from a while back. @Arun, I >> have moved csvdiff to textutils(it makes more semantic sense). > > Sounds good. > >> I see no need of defining it as a deprecated-package since there's no >> package dependent on it ATM. > > Users might have installed csvdiff into their profiles. So, I think we > still need to define a deprecated-package. Could you send an updated > patchset? Yup. This makes sense. Find attached a new patch that adds an alias for the deprecated package. Let me know if this is okay :) From 6767f1f8ffdbaa4c47b8fdd5778fbf570f4118d8 Mon Sep 17 00:00:00 2001 From: BonfaceKilz Date: Mon, 13 Dec 2021 23:42:56 +0300 Subject: [PATCH] gnu: Move csvdiff to (gnu packages textutils). See . * gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff): Move from here * gnu/packages/textutils (csvdiff): to here. (go-github-com-aswinkarthik-csvdiff): Add deprecated alias for moved package. --- gnu/packages/golang.scm | 44 --------------------------------- gnu/packages/textutils.scm | 50 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 44 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 70731e2720..848f20fa1d 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -8754,50 +8754,6 @@ zero round-trip encryption, and other advanced features.") non-cryptographic hash algorithm, working at speeds close to RAM limits.") (license license:asl2.0))) -(define-public go-github-com-aswinkarthik-csvdiff - (package - (name "go-github-com-aswinkarthik-csvdiff") - (version "1.4.0") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/aswinkarthik/csvdiff") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b")))) - (build-system go-build-system) - (arguments - '(#:import-path "github.com/aswinkarthik/csvdiff")) - (propagated-inputs - `(("go-golang-org-x-sys" ,go-golang-org-x-sys) - ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify) - ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra) - ("go-github-com-spf13-afero" ,go-github-com-spf13-afero) - ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3) - ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable) - ("go-github-com-fatih-color" ,go-github-com-fatih-color) - ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash) - ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash))) - (home-page "https://github.com/aswinkarthik/csvdiff") - (synopsis "Fast diff tool for comparing CSV files") - (description "@code{csvdiff} is a diff tool to compute changes between two -CSV files. It can compare CSV files with a million records in under 2 -seconds. It is specifically suited for comparing CSV files dumped from -database tables. GNU Diff is orders of magnitude faster for comparing line by -line. @code{csvdiff} supports - -@itemize -@item Selective comparison of fields in a row -@item Specifying group of columns as primary-key to uniquely identify a row -@item Ignoring columns -@item Several output formats including colored git style output or -JSON for post-processing -@end itemize") - (license license:expat))) - (define-public go-gopkg-in-djherbis-times-v1 (package (name "go-gopkg-in-djherbis-times-v1") diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm index 7e7293ac16..c3baeeaa0b 100644 --- a/gnu/packages/textutils.scm +++ b/gnu/packages/textutils.scm @@ -22,6 +22,7 @@ ;;; Copyright © 2020 Maxim Cournoyer ;;; Copyright © 2021 Jean-Baptiste Volatier ;;; Copyright © 2021 Simon Tournier +;;; Copyright © 2021 Bonface Munyoki Kilyungi ;;; ;;; This file is part of GNU Guix. ;;; @@ -64,6 +65,7 @@ #:use-module (gnu packages python) #:use-module (gnu packages python-build) #:use-module (gnu packages python-xyz) + #:use-module (gnu packages syncthing) #:use-module (gnu packages readline) #:use-module (gnu packages ruby) #:use-module (gnu packages slang) @@ -1347,3 +1349,51 @@ languages such as HTML, Markdown, Asciidoc, and reStructuredText. The community around it also has a list of style guides implemented with Vale in @url{https://github.com/errata-ai/styles, their styles repo}.") (license license:expat))) + +(define-public csvdiff + (package + (name "csvdiff") + (version "1.4.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/aswinkarthik/csvdiff") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b")))) + (build-system go-build-system) + (arguments + '(#:import-path "github.com/aswinkarthik/csvdiff")) + (propagated-inputs + `(("go-golang-org-x-sys" ,go-golang-org-x-sys) + ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify) + ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra) + ("go-github-com-spf13-afero" ,go-github-com-spf13-afero) + ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3) + ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable) + ("go-github-com-fatih-color" ,go-github-com-fatih-color) + ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash) + ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash))) + (home-page "https://github.com/aswinkarthik/csvdiff") + (synopsis "Fast diff tool for comparing CSV files") + (description "@code{csvdiff} is a diff tool to compute changes between two +CSV files. It can compare CSV files with a million records in under 2 +seconds. It is specifically suited for comparing CSV files dumped from +database tables. GNU Diff is orders of magnitude faster for comparing line by +line. @code{csvdiff} supports + +@itemize +@item Selective comparison of fields in a row +@item Specifying group of columns as primary-key to uniquely identify a row +@item Ignoring columns +@item Several output formats including colored git style output or +JSON for post-processing +@end itemize") + (license license:expat))) + +(define-public go-github-com-aswinkarthik-csvdiff + (deprecated-package "go-github-com-aswinkarthik-csvdiff" csvdiff)) + -- 2.31.1