From patchwork Wed Sep 22 03:21:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sarah Morgensen X-Patchwork-Id: 33236 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 43E1827BBE3; Wed, 22 Sep 2021 04:23:28 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 37CAA27BBE1 for ; Wed, 22 Sep 2021 04:23:27 +0100 (BST) Received: from localhost ([::1]:58400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSsqz-0005Wq-UJ for patchwork@mira.cbaines.net; Tue, 21 Sep 2021 23:23:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSsqd-0005UM-9v for guix-patches@gnu.org; Tue, 21 Sep 2021 23:23:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSsqb-0001cG-Ut for guix-patches@gnu.org; Tue, 21 Sep 2021 23:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSsqb-0001fF-PT for guix-patches@gnu.org; Tue, 21 Sep 2021 23:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49619] [PATCH v3 1/2] gnu: Add python-very-pretty-table. References: In-Reply-To: Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Sep 2021 03:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49619 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 49619@debbugs.gnu.org Received: via spool by 49619-submit@debbugs.gnu.org id=B49619.16322809236279 (code B ref 49619); Wed, 22 Sep 2021 03:23:01 +0000 Received: (at 49619) by debbugs.gnu.org; 22 Sep 2021 03:22:03 +0000 Received: from localhost ([127.0.0.1]:48440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSspe-0001dD-Tv for submit@debbugs.gnu.org; Tue, 21 Sep 2021 23:22:03 -0400 Received: from out2.migadu.com ([188.165.223.204]:11540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSspb-0001cg-L2 for 49619@debbugs.gnu.org; Tue, 21 Sep 2021 23:22:01 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632280917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=bLzOT7kT7wLTGcKtgsWa7fxKj/ZmPig6UrM3zmbEauw=; b=Qcrxs/JEgagKWaPTRqg2dGJaRtb80nPDcqDIxhm/0l0B/+DKbwe8WernHMCHVCTupAamvy RMweykUoo6sjw2DiugyfzSRgxN1onpKqjo+JGK4XAjShq56GFkkkQNBVPOudsDuFB25v1q z38gYRS1oxbexCuyAEynFAibJpWLdOM= From: Sarah Morgensen Date: Tue, 21 Sep 2021 20:21:53 -0700 Message-ID: <8635pxxpke.fsf@mgsn.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, phodina writes: > Hi Sarah! > > Are these fixes now compliant to upstream the patch? It's pretty good. I went ahead and made a few changes (attached below): I tweaked the descriptions, I changed very-pretty-table to veryprettytable so the python importer can find it in the future, I changed pirate-get's propagated-inputs to inputs since it's an end-user package, and I changed the license of pirate-get to AGPL-3. * Package review checklist (WIP) Lack of a check is not proof of noncompliance. 1. [X] Package builds (guix build package) [X] x86_64 [ ] aarch64 [ ] armhf [ ] powerpc64le [ ] i686 [ ] i586 [ ] mips64le 2. [X] Build is reproducible (guix build --rounds=n package) 3. [X] Tests enabled (if available) or disabled with in-source comment 4. [X] No extraneous dependencies (guix size package) 5. [X] No unnecessary pre-built binaries/blobs 6. [X] Dependencies unvendored when available in Guix 7. [X] Cross-compile friendly (cc-for-target, patches with inputs) 8. [X] License matches source 9. [X] No problematic lints (guix lint package) 10. [X] Formatting follows guidelines - [X] Lines wrap at 80 characters - [X] Indentation passes etc/indent-code.el - [X] Two spaces used between sentences For new packages: 1. [X] Source url is robust * mirror:// used with url-fetch when possible * No auto-generated archives from source repo (prefer cloning) 2. [X] Synopsis is short, descriptive, and meaningful to a wide audience 3. [X] Description is objective, takes 5-10 lines, uses full sentences, and provides the information users need to decide whether the software fits their needs. I also gave it a spin, and it works fine as long as the SSL_CERT_DIR environment variable is defined (I think that's beyond the scope of this package). LGTM. Thanks for your work! --- Sarah From 5e99c1f791c990dd76cd63a9ab2a5196656c5c6f Mon Sep 17 00:00:00 2001 Message-Id: <5e99c1f791c990dd76cd63a9ab2a5196656c5c6f.1632277047.git.iskarian@mgsn.dev> In-Reply-To: References: From: phodina Date: Sat, 18 Sep 2021 12:45:04 +0000 Subject: [PATCH v4 2/2] gnu: Add python-pirate-get. * gnu/packages/python-xyz.scm (python-pirate-get): New variable. --- gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index b1f162d079..86962e35b8 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -1820,6 +1820,34 @@ inserted directly, read from a CSV file, or imported using a Python DB-API database cursor such as @code{sqlite3}.") (license license:bsd-3))) +(define-public python-pirate-get + (package + (name "python-pirate-get") + (version "0.4.0") + (source + (origin + (method url-fetch) + (uri (pypi-uri "pirate-get" version)) + (sha256 + (base32 + "07s5ss9dxccx1mip7pyga1fagywkqchxmzz55ng47ac9053ffxkq")))) + (build-system python-build-system) + (inputs + `(("python-colorama" ,python-colorama) + ("python-pyperclip" ,python-pyperclip) + ("python-veryprettytable" ,python-veryprettytable))) + (home-page + "https://github.com/vikstrous/pirate-get") + (synopsis + "Command line interface for The Pirate Bay") + (description + "@code{pirate-get} is an unofficial command line interface for searching +The Pirate Bay, inspired by @command{apt}. Results can be saved as JSON, +@code{.torrent} files, or magnet links, or they can be opened directly in +@command{transmission-remote}. @code{pirate-get} also supports searching +mirrors or a local copy of The Pirate Bay's database.") + (license license:agpl3))) + (define-public python2-humanfriendly (let ((base (package-with-python2 (strip-python2-variant python-humanfriendly)))) -- 2.33.0