From patchwork Sat May 28 02:11:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhu Zihao X-Patchwork-Id: 39644 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id B8B6127BBEA; Sat, 28 May 2022 03:13:29 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1974127BBE9 for ; Sat, 28 May 2022 03:13:29 +0100 (BST) Received: from localhost ([::1]:50934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nulxI-0000ek-9D for patchwork@mira.cbaines.net; Fri, 27 May 2022 22:13:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nulx2-0000eQ-QS for guix-patches@gnu.org; Fri, 27 May 2022 22:13:13 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nulwr-0001Y0-Up for guix-patches@gnu.org; Fri, 27 May 2022 22:13:12 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nulwr-0003kQ-NG for guix-patches@gnu.org; Fri, 27 May 2022 22:13:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55517] Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 May 2022 02:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55517 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 55517@debbugs.gnu.org Received: via spool by 55517-submit@debbugs.gnu.org id=B55517.165370392414339 (code B ref 55517); Sat, 28 May 2022 02:13:01 +0000 Received: (at 55517) by debbugs.gnu.org; 28 May 2022 02:12:04 +0000 Received: from localhost ([127.0.0.1]:36136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nulvv-0003jC-QR for submit@debbugs.gnu.org; Fri, 27 May 2022 22:12:04 -0400 Received: from mail-m975.mail.163.com ([123.126.97.5]:44784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nulvq-0003ib-Ln for 55517@debbugs.gnu.org; Fri, 27 May 2022 22:12:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=wN3S2 99/bqyjH/HzzafqmQZZmTjdkDQnUnnNIfO43Rg=; b=F048hy9AoWEolQxBBjwn2 hDOxuKnVhWMDD3raPGRyoH3irroRllK0PDe0/RtmnG1ad2eIuJFpk973+gokCKHx 61krE0Rke9m6UppdvlL2SRkJ4eAJa+jFlvTt5/u0ezxbIX8ZvZmpjmhLQnzM6+wr ovqzger462Nm/UhrnyXog0= Received: from asus-laptop (unknown [163.125.202.234]) by smtp5 (Coremail) with SMTP id HdxpCgDncCbkhJFixMiaEg--.9102S2; Sat, 28 May 2022 10:11:49 +0800 (CST) References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <86leuw507n.fsf@163.com> <07286c2df8ffb434e353bdde7bf8d427e9d7d9b2.camel@ist.tugraz.at> <86o7zpaoih.fsf@163.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Zhu Zihao Date: Sat, 28 May 2022 10:11:27 +0800 In-reply-to: Message-ID: <8635gu9zj5.fsf@163.com> MIME-Version: 1.0 X-CM-TRANSID: HdxpCgDncCbkhJFixMiaEg--.9102S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUj18BDUUUU X-Originating-IP: [163.125.202.234] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiTwYPr1sGbMr7lQAAs8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches From 259d81469127306c4f345598f487122659a55c9c Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Sat, 28 May 2022 10:10:31 +0800 Subject: [PATCH 2/2] gnu: emacs-magit: Drop the libgit backend. The libgit backend currently provides next to no features, but demands extra maintenance overhead. It is in fact not a usable backend; thus let's not use it. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments] : Remove this argument. : Exclude the magit-libgit.el and magit-libgit-pkg.el. [inputs]: Remove emacs-libgit. --- gnu/packages/emacs-xyz.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index a9dc687af4..21359882ad 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -870,9 +870,11 @@ (define-public emacs-magit (build-system emacs-build-system) (arguments (list - #:emacs emacs-no-x ;module support is required #:tests? #t #:test-command #~(list "make" "test") + #:exclude #~(cons* "magit-libgit.el" + "magit-libgit-pkg.el" + %default-exclude) #:phases #~(modify-phases %standard-phases (add-after 'unpack 'build-info-manual @@ -920,7 +922,7 @@ (define-public emacs-magit (inputs (list git perl)) (propagated-inputs - (list emacs-dash emacs-libgit emacs-transient emacs-with-editor)) + (list emacs-dash emacs-transient emacs-with-editor)) (home-page "https://magit.vc/") (synopsis "Emacs interface for the Git version control system") (description -- 2.36.1