| Message ID | 855zi3kb3t.fsf@disroot.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#38746] gnu: emacs-shroud: Update to 1.105. | expand |
Dec 25, 2019 9:42:15 PM Amar M. Singh : > > New in this release: > 1. Now uses Gnu build system, aka Autotools. > 2. Comes with Texinfo documentation. > Hi Amar, I am looking at this on my phone, so I might be wrong but it looks like the change to the gnu-build-system is not accompanied by any arguments installing any byte-compiled elc files to the emacs site-lisp. Did you test this change? Are the elc files getting installed? If so, how? Normally we have to work around this issue with mixing gnu and Emacs build system phases. Also, things like autoconf and automake are implicit in the gnu build system and are not needed.
Hi Brett, I am using autoconf macro 'dist_lisp_LISP' in src/Makefile.am which will install '.el' files. Autotools are automatically detecting and installing '.elc' files from 'lisp_LISP' variable. -------- Original Message -------- From: Brett Gilio <brettg@gnu.org> Sent: December 26, 2019 3:51:15 AM UTC To: "Amar M. Singh" <nly@disroot.org> Cc: 38746@debbugs.gnu.org Subject: Re: [bug#38746] [PATCH] gnu: emacs-shroud: Update to 1.105. Dec 25, 2019 9:42:15 PM Amar M. Singh : > > New in this release: > 1. Now uses Gnu build system, aka Autotools. > 2. Comes with Texinfo documentation. > Hi Amar, I am looking at this on my phone, so I might be wrong but it looks like the change to the gnu-build-system is not accompanied by any arguments installing any byte-compiled elc files to the emacs site-lisp. Did you test this change? Are the elc files getting installed? If so, how? Normally we have to work around this issue with mixing gnu and Emacs build system phases. Also, things like autoconf and automake are implicit in the gnu build system and are not needed. Regards, Amar Singh <nly@disroot.org> https://o-nly.github.io ------------------------------------------------------------- Sent from my Android device with Librem Mail. Please excuse my brevity.
On Thu, Dec 26, 2019 at 03:58:19AM +0000, Amar M. Singh wrote: > > Dec 25, 2019 9:42:15 PM Amar M. Singh : > > > > > New in this release: > > 1. Now uses Gnu build system, aka Autotools. > > 2. Comes with Texinfo documentation. > > > > Hi Amar, > > I am looking at this on my phone, so I might be wrong but it looks like the change to the gnu-build-system is not accompanied by any arguments installing any byte-compiled elc files to the emacs site-lisp. Did you test this change? Are the elc files getting installed? If so, how? Normally we have to work around this issue with mixing gnu and Emacs build system phases. Also, things like autoconf and automake are implicit in the gnu build system and are not needed. > tree /gnu/store/0m5irk4q5hf3pw2ral0gv9y51qic7m9x-emacs-shroud-1.83.4 /gnu/store/0m5irk4q5hf3pw2ral0gv9y51qic7m9x-emacs-shroud-1.83.4 └── share ├── doc │ └── emacs-shroud-1.83.4 │ └── COPYING └── emacs └── site-lisp ├── shroud-autoloads.el ├── shroud-bui.el ├── shroud-bui.elc ├── shroud-cli.el ├── shroud-cli.elc ├── shroud.el ├── shroud.elc ├── shroud-el.el └── shroud-el.elc tree /gnu/store/j0wmnl8gyzf4qwpxlml7hlvqpdzsw7p6-emacs-shroud-1.105 /gnu/store/j0wmnl8gyzf4qwpxlml7hlvqpdzsw7p6-emacs-shroud-1.105 └── share ├── doc │ ├── emacs-shroud │ │ ├── emacs-shroud.html │ │ └── README │ └── emacs-shroud-1.105 │ └── COPYING ├── emacs │ └── site-lisp │ ├── shroud-bui.el │ ├── shroud-bui.elc │ ├── shroud-cli.el │ ├── shroud-cli.elc │ ├── shroud.el │ ├── shroud.elc │ ├── shroud-el.el │ └── shroud-el.elc └── info └── emacs-shroud.info.gz > > Hi Brett, > > I am using autoconf macro 'dist_lisp_LISP' in src/Makefile.am which will install '.el' files. Autotools are automatically detecting and installing '.elc' files from 'lisp_LISP' variable. > I'm not an emacs user, do we need shroud-autoloads.el to be installed also?
Hi Efraim, Autoloads.el is used to lazily load an Elisp package. It causes the main commands to be available to Emacs user before the whole package is loaded. In Guix System, if a package doesn't have autoloads it won't be automatically loaded into Emacs. One will need to add '(require 'package) to '.emacs'. In case of my package: (require 'shroud) without this Emacs wouldn't load Shroud. Regards, Amar Singh <nly@disroot.org> https://o-nly.github.io ------------------------------------------------------------- Sent from my Android device with Librem Mail. Please excuse my brevity.
Sounds good. Patch pushed. On Thu, Dec 26, 2019 at 01:49:24PM +0000, Amar M. Singh wrote: > Hi Efraim, > > Autoloads.el is used to lazily load an Elisp package. It causes the main commands to be available to Emacs user before the whole package is loaded. > > In Guix System, if a package doesn't have autoloads it won't be automatically loaded into Emacs. One will need to add '(require 'package) to '.emacs'. > > In case of my package: > (require 'shroud) > > without this Emacs wouldn't load Shroud. > Regards, > Amar Singh <nly@disroot.org> > https://o-nly.github.io > > ------------------------------------------------------------- > Sent from my Android device with Librem Mail. Please excuse my brevity.
Thanks Efraim. Regards, Amar Singh <nly@disroot.org> https://o-nly.github.io ------------------------------------------------------------- Sent from my Android device with Librem Mail. Please excuse my brevity.
From 444fa144213999c7c37d2761b99a7ea3d7ebc5f1 Mon Sep 17 00:00:00 2001 From: Amar Singh <nly@disroot.org> Date: Thu, 26 Dec 2019 09:01:42 +0530 Subject: [PATCH] gnu: emacs-shroud: Update to 1.105. Now uses Gnu build system. * gnu/packages/emacs-xyz.scm (emacs-shroud): Update to 1.105. --- gnu/packages/emacs-xyz.scm | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f39e5da63e..71e8a1219c 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -640,17 +640,23 @@ for editing Racket's Scribble documentation syntax in Emacs.") (define-public emacs-shroud (package (name "emacs-shroud") - (version "1.83.4") + (version "1.105") (source (origin (method git-fetch) (uri (git-reference - (url "https://github.com/o-nly/emacs-shroud.git") + (url "https://git.savannah.gnu.org/git/emacs-shroud.git") (commit version))) (file-name (git-file-name name version)) (sha256 - (base32 "1yvdjx0kp4y8w5yz2cbqq9n6xl5splvmsyyx8ld1xv0q1c9872nf")))) - (build-system emacs-build-system) + (base32 "0q2pb3w8s833fjhkzicciw2php4lsnismad1dnwgp2lcway757ra")))) + (build-system gnu-build-system) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("texinfo" ,texinfo) + ("perl" ,perl) + ("emacs-minimal" ,emacs-minimal))) (propagated-inputs `(("emacs-bui" ,emacs-bui) ("emacs-dash" ,emacs-dash) @@ -658,7 +664,7 @@ for editing Racket's Scribble documentation syntax in Emacs.") ("emacs-s" ,emacs-s) ("gnupg" ,gnupg) ("shroud" ,shroud))) - (home-page "https://github.com/o-nly/emacs-shroud") + (home-page "https://www.nongnu.org/emacs-shroud") (synopsis "Emacs interface to the Shroud password manager") (description "This package provides an Emacs interface to the Shroud password manager, -- 2.24.0