Message ID | 8403c5159deb34bf4dac119d55c57c9dba530a20.1733594283.git.roman@burningswell.com |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id DA45F27BBE2; Sat, 7 Dec 2024 18:01:32 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 23BFF27BBE9 for <patchwork@mira.cbaines.net>; Sat, 7 Dec 2024 18:01:30 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1tJz74-0008JU-AG; Sat, 07 Dec 2024 13:01:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tJz72-0008JG-Bb for guix-patches@gnu.org; Sat, 07 Dec 2024 13:01:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tJz72-0008LY-2b for guix-patches@gnu.org; Sat, 07 Dec 2024 13:01:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=0eBBqYtsp0KkmKg7aCyt8kDFh2qkZWTEConDYHwF8PU=; b=JS/+zN7CA6Dow8VXdP3i4OVXaLiJcgprGq048xRku1PH3dAie0E1hWDtYT/1Mz5WbJOWPGFmRGlIl2kb0xeZuyPzmegD944TdmhuFil9Wlo4Ma9i2FhqKz5KB1xUXp6bhB0DF1YGn61ekISfyO2Ggbff90oHMXbHrQfucGXHbkuC1cQR0PFMsIyc3O5k/H8WdH1xbiacL4Cy/5/sqek5aSyoF+LhMSBUigVLWvb2mpvjyjoeFXeEE3205m9T90+tBkScnQj8CUjjQWkMLCSYrZobNu/lYPowrDONQo9yanHU5l7DRT5fBMvr69fQi3mbxDoxBFrjp4dEhbriPvhtgQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tJz70-0002Vz-GS for guix-patches@gnu.org; Sat, 07 Dec 2024 13:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74728] [PATCH] gnu: python-asyncssh: Disable flaky connection tests. Resent-From: Roman Scherer <roman@burningswell.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 07 Dec 2024 18:01:02 +0000 Resent-Message-ID: <handler.74728.B.17335944429626@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74728 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74728@debbugs.gnu.org Cc: Roman Scherer <roman@burningswell.com> X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17335944429626 (code B ref -1); Sat, 07 Dec 2024 18:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Dec 2024 18:00:42 +0000 Received: from localhost ([127.0.0.1]:48438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1tJz6g-0002VC-C7 for submit@debbugs.gnu.org; Sat, 07 Dec 2024 13:00:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:45698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <roman@burningswell.com>) id 1tJz6e-0002V4-5b for submit@debbugs.gnu.org; Sat, 07 Dec 2024 13:00:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <roman@burningswell.com>) id 1tJz6c-0008Gw-O2 for guix-patches@gnu.org; Sat, 07 Dec 2024 13:00:38 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <roman@burningswell.com>) id 1tJz6a-0008JJ-ER for guix-patches@gnu.org; Sat, 07 Dec 2024 13:00:38 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5d3e9f60bf4so505022a12.3 for <guix-patches@gnu.org>; Sat, 07 Dec 2024 10:00:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burningswell-com.20230601.gappssmtp.com; s=20230601; t=1733594434; x=1734199234; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0eBBqYtsp0KkmKg7aCyt8kDFh2qkZWTEConDYHwF8PU=; b=VtOE0Cmq5nCjLKJxJVp+mxvihC0/KnYXl2OI/QdJi1mk3jO7xcF9Xw0E/eTsgooXZN wCAsFizwQJUMfUiwBI16hwYQajVHLLQk4N9DG9dCcldXiqTXpMqT5ggJkc/vTe1SLERm q/m/W/ApkvYUJJCRKqnWCdRUUx2g1bPe8Xn0POquAQUFXn2uWCi0irddHRSUT2/7NJ6Q L2G+c4msJQx/fojHD8C4gBD2/oZc82nxJbUtUY3jO06iaROWDqGbDowB131yl4H59iT7 ngIgvtWYpRlDllmITuIU3w0CZ59LHAz8yRUxwgFWCZPaDT73heFOQ8Ot1odYwQ/XHI8D BWmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733594434; x=1734199234; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0eBBqYtsp0KkmKg7aCyt8kDFh2qkZWTEConDYHwF8PU=; b=cIE8sk5jDUvK38qlXnrV5h6XID6epjbwRmzJN/Ii03VbyAoP69i4hAJILmyr0I4Zas xBQ5ZkvzUNgzRcfLRyltyigXhjYr7RbkFN8r6dOg0+SpdF9pDvJHoBUH7iJsZGX2Avh4 XI6Ol7/Z4x9H19mTdV90Wap+MWArBgZVcb8npHH5AuJl3gCZJG652tM4VcOzh2trPa19 pEas+fQjCvTI4rgqbmVme3iZ94lYqxAYD8jOHhFTJ74PqVfhKo6UYo0jV0fGApDR8OAa FFo0A2MMjqXx6wSvPOhMPpd9jxr/Zsyr4zFp8k2JY0/ZkwICHNSr30uyj4WPn7g8bU/w L9dw== X-Gm-Message-State: AOJu0Yz3gVqUQGznm+ppdif+DvBebdMeg3/JuGjnRHDYQbcA1gn05bzc BFmLPft6TwR/3pFX0jUVy/j+vsN+h5CgBgn/ZOfEufyJK6RxgK/h3IjbdzLdYEUbC0Zyab3UNd3 n X-Gm-Gg: ASbGncv5Fn/DNxHCy3jwv4uSMJRF3H8GaaHPst9KKzHhfoUVfZ4Skj2ZgSUiVF1jK9D PJ3Fhc6cgS0D3+ii/li0waalFW4ylM8K7X7r7ZEGXLlm0Dc8dY+5UIr7I5Cq5d1xoeVKfmtS871 +MgzP/tBTIorwJeOLE2cOb3OR03iwEhJI0XjEuAukn02qnDuHh5PciUey8EYYVrqMwSj4ERztMs 2XiyGpJzSUJYJcfgpLGIitVvzU8+ZD8F6cSooLyxVCKRXHoC8mOPcpnl6cW7gdmMK/d X-Google-Smtp-Source: AGHT+IEvG8vbroQO0lyWBC0SO51y8+AB49MPAEt1pGT8NoDF5wKUUSQB/ubFb9h1TPluG1A/qlk+uA== X-Received: by 2002:a05:6402:1e8b:b0:5cf:bcaf:98ec with SMTP id 4fb4d7f45d1cf-5d3be7ac274mr5706548a12.26.1733594433837; Sat, 07 Dec 2024 10:00:33 -0800 (PST) Received: from localhost.localdomain ([2a01:599:10b:bfed:dcf6:7e6c:5587:8820]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3db53b828sm1241442a12.74.2024.12.07.10.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Dec 2024 10:00:33 -0800 (PST) From: Roman Scherer <roman@burningswell.com> Date: Sat, 7 Dec 2024 19:00:20 +0100 Message-ID: <8403c5159deb34bf4dac119d55c57c9dba530a20.1733594283.git.roman@burningswell.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=2a00:1450:4864:20::52a; envelope-from=roman@burningswell.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#74728] gnu: python-asyncssh: Disable flaky connection tests.
|
|
Commit Message
Roman Scherer
Dec. 7, 2024, 6 p.m. UTC
* gnu/packages/ssh.scm (python-asyncssh): Disable flaky connection tests. Change-Id: If99cc686679fd2c731f3d66a85abe23eff6f1234 --- gnu/packages/ssh.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) base-commit: bc630c5ebed27edd821ec363706f8b9cf1ee05cc
Comments
Hi, Thanks for the patch. Give it a try to refactor it by using pyproject-build-system, contsing much simpler test excluding mechanics. Oleg
Hi, Pushed as f2ad73507b9a313024893e837aa11774f61b273f to master. -- Thanks, Oleg
References: <87y10q73sd.fsf@gmail.com> <8403c5159deb34bf4dac119d55c57c9dba530a20.1733594283.git.roman@burningswell.com> <handler.74728.D74728.173366126726317.notifdone@debbugs.gnu.org> User-Agent: mu4e 1.12.7; emacs 29.4 Hi Oleg, thanks for applying my patch. I now tried to build python-asyncssh from the Guix master branch, but unfortunatly now other tests started to fail, which didn't fail before for some reason. I guess you don't see those issues, so maybe it is specific to my aarch64 system? I sent a new mail and added a new patch that disables more tests. Could you take a look at them? Thanks, Roman. Date: Sun, 08 Dec 2024 15:18:14 +0100 help-debbugs@gnu.org (GNU bug Tracking System) writes: > Your bug report > > #74728: [PATCH] gnu: python-asyncssh: Disable flaky connection tests. > > which was filed against the guix-patches package, has been closed. > > The explanation is attached below, along with your original report. > If you require more details, please reply to 74728@debbugs.gnu.org. > > -- > 74728: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74728 > GNU Bug Tracking System > Contact help-debbugs@gnu.org with problems > > From: Sharlatan Hellseher <sharlatanus@gmail.com> > Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests. > To: 74728-done@debbugs.gnu.org > Date: Sun, 08 Dec 2024 12:33:22 +0000 (1 hour, 42 minutes, 21 seconds ago) > > > > Hi, > > Pushed as f2ad73507b9a313024893e837aa11774f61b273f to master. > > -- > Thanks, > Oleg > > ---------- > > From: Roman Scherer <roman@burningswell.com> > Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests. > To: guix-patches@gnu.org > Cc: Roman Scherer <roman@burningswell.com> > Date: Sat, 7 Dec 2024 19:00:20 +0100 > Date: Sat, 7 Dec 2024 19:00:20 +0100 (20 hours, 15 minutes, 23 seconds ago) > > * gnu/packages/ssh.scm (python-asyncssh): Disable flaky connection tests. > > Change-Id: If99cc686679fd2c731f3d66a85abe23eff6f1234 > --- > gnu/packages/ssh.scm | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm > index 1f33259246..a44976b598 100644 > --- a/gnu/packages/ssh.scm > +++ b/gnu/packages/ssh.scm > @@ -833,7 +833,15 @@ (define-public python-asyncssh > ;; TODO Test fails for unknown reason > (("(.+)async def test_confirm" all indent) > (string-append indent "@unittest.skip('disabled by guix')\n" > - indent "async def test_confirm"))))) > + indent "async def test_confirm"))) > + (substitute* "tests/test_connection.py" > + ;; Tests fail with: asyncssh.misc.ConnectionLost: Connection lost > + (("(.+)async def test_get_server_host_key_proxy" all indent) > + (string-append indent "@unittest.skip('disabled by guix')\n" > + indent "async def test_get_server_host_key_proxy")) > + (("(.+)async def test_connect_reverse_proxy" all indent) > + (string-append indent "@unittest.skip('disabled by guix')\n" > + indent "async def test_connect_reverse_proxy"))))) > (replace 'check > (lambda* (#:key tests? inputs outputs #:allow-other-keys) > (when tests? > > base-commit: bc630c5ebed27edd821ec363706f8b9cf1ee05cc
Hi, [PATCH] gnu: python-asyncssh: Disable failing tests on aarch64. Pushed as ec1a67d4ff7435fdf50de35c3f57d2f60a9cccf9 to master. It was built successfully both on x86_68 and aarch64 in Qemu. Pleas, open other issue if you find something else ;-). -- Thanks, Oleg
diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm index 1f33259246..a44976b598 100644 --- a/gnu/packages/ssh.scm +++ b/gnu/packages/ssh.scm @@ -833,7 +833,15 @@ (define-public python-asyncssh ;; TODO Test fails for unknown reason (("(.+)async def test_confirm" all indent) (string-append indent "@unittest.skip('disabled by guix')\n" - indent "async def test_confirm"))))) + indent "async def test_confirm"))) + (substitute* "tests/test_connection.py" + ;; Tests fail with: asyncssh.misc.ConnectionLost: Connection lost + (("(.+)async def test_get_server_host_key_proxy" all indent) + (string-append indent "@unittest.skip('disabled by guix')\n" + indent "async def test_get_server_host_key_proxy")) + (("(.+)async def test_connect_reverse_proxy" all indent) + (string-append indent "@unittest.skip('disabled by guix')\n" + indent "async def test_connect_reverse_proxy"))))) (replace 'check (lambda* (#:key tests? inputs outputs #:allow-other-keys) (when tests?