diff mbox series

[bug#64356,v3,1/4] tests: xvnc: Fix test.

Message ID 83fb001a7c94895302c0e78d834ec238c29f005a.1688133473.git.mirai@makinata.eu
State New
Headers show
Series Fix GDM + VNC tests | expand

Commit Message

Bruno Victal June 30, 2023, 1:58 p.m. UTC 
* gnu/tests/vnc.scm (run-xvnc-test): Use system* instead of invoke.
---
 gnu/tests/vnc.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 8af22b493199a17f46351c2f3d9f6ee759e48564

Comments

Maxim Cournoyer July 19, 2023, 2:44 p.m. UTC | #1 
Hi,

Bruno Victal <mirai@makinata.eu> writes:

> * gnu/tests/vnc.scm (run-xvnc-test): Use system* instead of invoke.
> ---
>  gnu/tests/vnc.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/tests/vnc.scm b/gnu/tests/vnc.scm
> index 5c4bd43fa3..e59972eee4 100644
> --- a/gnu/tests/vnc.scm
> +++ b/gnu/tests/vnc.scm
> @@ -142,11 +142,11 @@ (define (run-xvnc-test)
>                (marionette-eval
>                 '(begin
>                    ;; Check that DCONF_PROFILE is set...
> -                  (invoke "/bin/sh" "-lc" "\
> +                  (system* "/bin/sh" "-lc" "\
>  pgrep gdm | head -n1 | xargs -I{} grep -Fq DCONF_PROFILE /proc/{}/environ")
>  
>                    ;; ... and that
> -                  (invoke "/bin/sh" "-lc" "\
> +                  (system* "/bin/sh" "-lc" "\
>  sudo -E -u gdm env DCONF_PROFILE=/etc/dconf/profile/gdm dbus-run-session \
>  gsettings get org.gnome.settings-daemon.plugins.power sleep-inactive-ac-type \
>  | grep -Fq nothing"))

Using system* instead of invoke would silence the errors as it doesn't
raise on errors.

The real cause of the problem was a09c7da ("tests: Fork and exec a new
Guile for the marionette REPL."), which I've fixed in 1edbadc6 ("tests:
xvnc: Fix 'gdm auto-suspend is disabled' test.").

Thanks for the report!
diff mbox series

Patch

diff --git a/gnu/tests/vnc.scm b/gnu/tests/vnc.scm
index 5c4bd43fa3..e59972eee4 100644
--- a/gnu/tests/vnc.scm
+++ b/gnu/tests/vnc.scm
@@ -142,11 +142,11 @@  (define (run-xvnc-test)
               (marionette-eval
                '(begin
                   ;; Check that DCONF_PROFILE is set...
-                  (invoke "/bin/sh" "-lc" "\
+                  (system* "/bin/sh" "-lc" "\
 pgrep gdm | head -n1 | xargs -I{} grep -Fq DCONF_PROFILE /proc/{}/environ")
 
                   ;; ... and that
-                  (invoke "/bin/sh" "-lc" "\
+                  (system* "/bin/sh" "-lc" "\
 sudo -E -u gdm env DCONF_PROFILE=/etc/dconf/profile/gdm dbus-run-session \
 gsettings get org.gnome.settings-daemon.plugins.power sleep-inactive-ac-type \
 | grep -Fq nothing"))