diff mbox series

[bug#42284] gnu: icecat: Add libxscrnsaver to runtime LD_LIBRARY_PATH

Message ID 821791594245227@mail.yandex.ru
State Accepted
Headers show
Series [bug#42284] gnu: icecat: Add libxscrnsaver to runtime LD_LIBRARY_PATH | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job

Commit Message

Ivan Kozlov July 8, 2020, 10 p.m. UTC
IceCat loads libXss.so at runtime to inhibit screen locking if other interfaces are unavailable.

Comments

Maja Kądziołka July 26, 2020, 11:14 a.m. UTC | #1
On Thu, Jul 09, 2020 at 01:00:05AM +0300, Ivan Kozlov wrote:
> IceCat loads libXss.so at runtime to inhibit screen locking if other interfaces are unavailable.
> 
> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index fa430837f9..123e8bd889 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -1115,10 +1115,12 @@ from forcing GEXP-PROMISE."
>                      (mesa (assoc-ref inputs "mesa"))
>                      (mesa-lib (string-append mesa "/lib"))
>                      (pulseaudio (assoc-ref inputs "pulseaudio"))
> -                    (pulseaudio-lib (string-append pulseaudio "/lib")))
> +                    (pulseaudio-lib (string-append pulseaudio "/lib"))
> +                    (libxscrnsaver (assoc-ref inputs "libxscrnsaver"))
> +                    (libxscrnsaver-lib (string-append libxscrnsaver "/lib")))
>                 (wrap-program (car (find-files lib "^icecat$"))
>                   `("XDG_DATA_DIRS" prefix (,gtk-share))
> -                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,mesa-lib)))
> +                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,mesa-lib ,libxscrnsaver-lib)))
>                 #t))))))
>      (home-page "https://www.gnu.org/software/gnuzilla/")
>      (synopsis "Entirely free browser derived from Mozilla Firefox")

Hi Ivan,

I gave your patch a test ride and playing videos in IceCat now correctly
inhibits the screensaver. Thanks!

I adjusted the commit message a bit and pushed the patch to master:

commit f11d429071e9350f671bc75cb899fb464c147092 (HEAD -> master, upstream/master)
Author: Ivan Kozlov <kanichos@yandex.ru>
Date:   Thu Jul 9 01:00:05 2020 +0300

    gnu: icecat: Add libxscrnsaver to runtime LD_LIBRARY_PATH

    IceCat loads libXss.so at runtime to inhibit screen locking if other interfaces are unavailable.

    * gnu/packages/gnuzilla.scm (icecat)[arguments]: Add libxscrnsaver to
    wrap-program arguments.

    Signed-off-by: Jakub Kądziołka <kuba@kadziolka.net>

Regards,
Jakub Kądziołka
diff mbox series

Patch

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index fa430837f9..123e8bd889 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1115,10 +1115,12 @@  from forcing GEXP-PROMISE."
                     (mesa (assoc-ref inputs "mesa"))
                     (mesa-lib (string-append mesa "/lib"))
                     (pulseaudio (assoc-ref inputs "pulseaudio"))
-                    (pulseaudio-lib (string-append pulseaudio "/lib")))
+                    (pulseaudio-lib (string-append pulseaudio "/lib"))
+                    (libxscrnsaver (assoc-ref inputs "libxscrnsaver"))
+                    (libxscrnsaver-lib (string-append libxscrnsaver "/lib")))
                (wrap-program (car (find-files lib "^icecat$"))
                  `("XDG_DATA_DIRS" prefix (,gtk-share))
-                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,mesa-lib)))
+                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,mesa-lib ,libxscrnsaver-lib)))
                #t))))))
     (home-page "https://www.gnu.org/software/gnuzilla/")
     (synopsis "Entirely free browser derived from Mozilla Firefox")