From patchwork Sun Feb 16 08:45:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Artyom V. Poptsov" X-Patchwork-Id: 38718 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9CB1627BBEA; Sun, 16 Feb 2025 08:46:33 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 133CF27BBE2 for ; Sun, 16 Feb 2025 08:46:33 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tjaHv-0001U1-4j; Sun, 16 Feb 2025 03:46:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tjaHr-0001Tl-VI for guix-patches@gnu.org; Sun, 16 Feb 2025 03:46:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tjaHq-0004Lj-6M for guix-patches@gnu.org; Sun, 16 Feb 2025 03:46:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=9AlhkoMYneTw7S6nhDUVIcp20B9bN1w11RS6FhD+kZ0=; b=Zj8wZfXNTD+ooaNkXabIH2J175L5gWBe+/ZqXgsCpXZIgDU+1orLxy89g2m5SvnNyLIZQA8keOb/QrXu3Xn2aUlL+ERiIoKFs/C9c7LCwpxocHUiZkvMO1WFnq3AjbhtjTNN5mlRikwb4QyQDxcw9nP9PPqylRexLxetoaFS01L8/kexdit7ujHaJPao+KgfpNxW9I3Gd0mZ2B7S6LYociT6EO3bgs+gDzoOFJrU1LxPMxpQfJ+DMTDcoocLfSWGWJWkCX92eNz6+ccbEPe+BQ7t30VfivXvzsq5a3F/a6iN0cJo06iSgwAeIHj7jQhbHtrG6945aE9NhAgeRj8pSQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tjaHq-0000ew-0o for guix-patches@gnu.org; Sun, 16 Feb 2025 03:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#76326] [PATCH 1/2] gnu: gpick: Improve the package style. Resent-From: "Artyom V. Poptsov" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 Feb 2025 08:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76326 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 76326@debbugs.gnu.org Cc: "Artyom V. Poptsov" Received: via spool by 76326-submit@debbugs.gnu.org id=B76326.173969554532699 (code B ref 76326); Sun, 16 Feb 2025 08:46:01 +0000 Received: (at 76326) by debbugs.gnu.org; 16 Feb 2025 08:45:45 +0000 Received: from localhost ([127.0.0.1]:59997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tjaHY-0008UI-A6 for submit@debbugs.gnu.org; Sun, 16 Feb 2025 03:45:44 -0500 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:38442) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tjaHV-0008AA-K5 for 76326@debbugs.gnu.org; Sun, 16 Feb 2025 03:45:42 -0500 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-54531538067so162361e87.2 for <76326@debbugs.gnu.org>; Sun, 16 Feb 2025 00:45:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739695535; x=1740300335; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9AlhkoMYneTw7S6nhDUVIcp20B9bN1w11RS6FhD+kZ0=; b=WruXaR9VwUstgsmx3S6JR2W2cLDL71gqPqUXFiUJ6cfOzlasfCdUlrF4xRZSUwLDLn e/6LFasL8mC4fRHw7Tn89sFiCCxAUiK8UVBbLRW96urwOwppfireNrY0RFXlpQeL7YjO q+lVQN7MPOI6EbLyR0ZyKrAXjeQWuj7ISlTc6G3m4CXCg2vh+27+8403nVYpkiGiko92 KbykcoOvunr1kK+T9Z6uekkU2OuBJRjqBQWfz7V1LZn9KOedHuT56uMI1M4AfhQibgeU hsOWBLSTmCKpmygC7ijmHPUTOFweGFzVrO7UyOnvI2cyolpsb4+WkiEZUuyGyzJSwJLv VG/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739695535; x=1740300335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9AlhkoMYneTw7S6nhDUVIcp20B9bN1w11RS6FhD+kZ0=; b=lcovsnTYyjxMBFzIC+3DNq+eoCj8p9h426BSJ4zIIhwwNoaalFRg39m/l+oCXbOBb/ jST+wMF+T30RSRV2oW3sBjACCcEm74PtD+hbMvOM3UqSPs1pYijD0wbjiwsziD9xGoUd JZ2tBW4tFnTq9RX4R80q9Mlez5sU1joQaAOFYqhwSc0MXO245oKmf1ld3DROemmD/DKy 1demoResXKCjcGk+nzTCyPK/jiGv3qHH50A0nqGYc27PxKRqCg4JNhgQrXgPcYIo8c5W Nj675r8k6xWGztGn48pnBmesu9Y/FRS80Ex1SapH5aPx9LiQzh7grBDw/4Mppf2tqj5h eD1g== X-Gm-Message-State: AOJu0YzJX3dH6vpLO8r2+BLNpz/qCQnmzP/qyVDW/2q/mlbBotgMizbc JlahBY53aXuJ5FLQacOHFv3/nGVueIeVXbehfwdpoM4AtdbFHutxLiDws3b+q7lNjw== X-Gm-Gg: ASbGncty0Elu+BtnlD7jYZ/9Qdx5HD905fIIAtLcgPOwPmcZcdShEmyufDzZL+HC6XU p8dSqkuRDq4NugPR9hze4wqzuPBfj4wxw8VqNfU0Ghg8s/DI9BS3ixw5dShu0v95NdHa+XW/sys 6r7tD6erBG8/1zqTU+KBlon7/5VxvtKNFmi1PQR/qm2b9dW8bT09f9opAisL7ElvW9JFyTzdKmR u+SN6YzZmw+s4l5iUqSKcBLETJPfa0uwGLQN+Sp0aANAyDSLPnHge+LZTZ6KawpiXXbl1p79+wy myhkFnfdd3D9NLx0 X-Google-Smtp-Source: AGHT+IGVkpMkPBxn+PSDxJQ8861PdU5r4AXwANFBv/EI7TkqAmP0Y6rtDevRibohq17375600V43dg== X-Received: by 2002:a05:6512:b0a:b0:545:2d03:d100 with SMTP id 2adb3069b0e04-5452fe8fdcfmr454052e87.12.1739695534817; Sun, 16 Feb 2025 00:45:34 -0800 (PST) Received: from elephant.. ([5.164.217.35]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5461dd84631sm121217e87.167.2025.02.16.00.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 00:45:33 -0800 (PST) From: "Artyom V. Poptsov" Date: Sun, 16 Feb 2025 11:45:15 +0300 Message-ID: <818b72d701f2bd4ed0349e6d7579e0e59d436029.1739695296.git.poptsov.artyom@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/image.scm (gpick): Improve the package style. [native-inputs, inputs]: Remove input labels. [arguments]: Use GEXPs. Change-Id: I7917381255ab5cd129e6c6133246579fb071a03f --- gnu/packages/image.scm | 50 +++++++++++++++++++----------------------- 1 file changed, 22 insertions(+), 28 deletions(-) diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index 99face4546..282b6582e8 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -2044,36 +2044,30 @@ (define-public gpick (package (name "gpick") (version "0.2.6") - (source (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/thezbyg/gpick") - (commit (string-append name "-" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "0nl89gca5nmbyycv5rl5bm6k7facapdk4pab9pl949aa3cjw9bk7")))) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/thezbyg/gpick") + (commit (string-append name "-" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0nl89gca5nmbyycv5rl5bm6k7facapdk4pab9pl949aa3cjw9bk7")))) (build-system scons-build-system) - (native-inputs - `(("boost" ,boost) - ("gettext" ,gettext-minimal) - ("pkg-config" ,pkg-config) - ("ragel" ,ragel))) - (inputs - `(("expat" ,expat) - ("gtk2" ,gtk+-2) - ("lua" ,lua-5.2))) + (native-inputs (list boost gettext-minimal pkg-config ragel)) + (inputs (list expat gtk+-2 lua-5.2)) (arguments - `(#:tests? #f - #:scons ,scons-python2 - #:scons-flags (list (string-append "DESTDIR=" %output)) - #:phases - (modify-phases %standard-phases - (add-before 'build 'fix-lua-reference - (lambda _ - (substitute* "SConscript" - (("lua5.2") "lua-5.2")) - #t))))) + (list + #:tests? #f + #:scons scons-python2 + #:scons-flags #~(list (string-append "DESTDIR=" #$output)) + #:phases + #~(modify-phases %standard-phases + (add-before 'build 'fix-lua-reference + (lambda _ + (substitute* "SConscript" + (("lua5.2") + "lua-5.2"))))))) (home-page "http://www.gpick.org/") (synopsis "Color picker") (description "Gpick is an advanced color picker and palette editing tool.")