[bug#71319,v2,3/3] gnu: emacs-ddskk-nicola: Improve package style.
Commit Message
* gnu/packages/emacs-xyz.scm (emacs-ddskk-nicola)[arguments]: Use newer
package style. This is necessary due to the emacs-ddskk package style update
since emacs-ddskk-nicola inherits this. It also removes the last #t values
from the lambda expressions in phases.
Change-Id: Ief8761bca476eba5e675d995b22d0a070f90de2f
---
gnu/packages/emacs-xyz.scm | 38 +++++++++++++++++++-------------------
1 file changed, 19 insertions(+), 19 deletions(-)
Comments
Hello,
gemmaro <gemmaro.dev@gmail.com> writes:
> * gnu/packages/emacs-xyz.scm (emacs-ddskk-nicola)[arguments]: Use newer
> package style. This is necessary due to the emacs-ddskk package style update
> since emacs-ddskk-nicola inherits this. It also removes the last #t values
> from the lambda expressions in phases.
Thank you. Some comments follow.
> + (append
> + (list #:make-flags
> + #~(let ((out (assoc-ref %outputs "out")))
You can remove this and use #$output instead.
> + (append
> + (list (string-append "PREFIX=" out)
> + (string-append "LISPDIR=" out "/share/emacs/site-lisp"))))
See above.
> + #:tests? #f ;no tests in this subtree
> + )
Please do not leave dangling parenthesis like this one.
> + (substitute-keyword-arguments (package-arguments emacs-ddskk)
> + ((#:phases phases)
> + #~(modify-phases #$phases
> + (add-after 'unpack 'chdir
> + (lambda _
> + (chdir "nicola")))
> + (replace 'configure
> + (lambda* (#:key outputs #:allow-other-keys)
> + (make-file-writable "NICOLA-DDSKK-CFG")
> + (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
> + ("setq NICOLA-DDSKK_PREFIX" "")))))))))
You can use (lambda _ ...) instead of (lambda* (#:key outputs ...) ...)
since you don't make use of OUTPUTS argument.
Regards,
@@ -36894,25 +36894,25 @@ (define-public emacs-ddskk-nicola
(propagated-inputs
(list emacs-ddskk))
(arguments
- `(#:make-flags
- (let ((out (assoc-ref %outputs "out")))
- (append
- (list (string-append "PREFIX=" out)
- (string-append "LISPDIR=" out "/share/emacs/site-lisp"))))
- #:tests? #f ; no tests in this subtree
- ,@(substitute-keyword-arguments (package-arguments emacs-ddskk)
- ((#:phases phases)
- `(modify-phases ,phases
- (add-after 'unpack 'chdir
- (lambda _
- (chdir "nicola")
- #t))
- (replace 'configure
- (lambda* (#:key outputs #:allow-other-keys)
- (make-file-writable "NICOLA-DDSKK-CFG")
- (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
- ("setq NICOLA-DDSKK_PREFIX" ""))
- #t)))))))
+ (append
+ (list #:make-flags
+ #~(let ((out (assoc-ref %outputs "out")))
+ (append
+ (list (string-append "PREFIX=" out)
+ (string-append "LISPDIR=" out "/share/emacs/site-lisp"))))
+ #:tests? #f ;no tests in this subtree
+ )
+ (substitute-keyword-arguments (package-arguments emacs-ddskk)
+ ((#:phases phases)
+ #~(modify-phases #$phases
+ (add-after 'unpack 'chdir
+ (lambda _
+ (chdir "nicola")))
+ (replace 'configure
+ (lambda* (#:key outputs #:allow-other-keys)
+ (make-file-writable "NICOLA-DDSKK-CFG")
+ (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
+ ("setq NICOLA-DDSKK_PREFIX" "")))))))))
(synopsis "Nicola layout for Daredevil SKK")
(description
"Daredevil SKK is a version of @acronym{SKK, Simple Kana to Kanji