| Message ID | 804e33c6f779448024d40795f1f92eda5d5aa068.1738564364.git.iyzsong@member.fsf.org |
|---|---|
| State | New |
| Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D680927BBEA; Mon, 3 Feb 2025 06:30:40 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 2703A27BBE2 for <patchwork@mira.cbaines.net>; Mon, 3 Feb 2025 06:30:40 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1tepyA-0004sQ-4F; Mon, 03 Feb 2025 01:30:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tepy7-0004qS-P6 for guix-patches@gnu.org; Mon, 03 Feb 2025 01:30:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tepy7-000493-F9 for guix-patches@gnu.org; Mon, 03 Feb 2025 01:30:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=BY/2jC/Ewu0IJuB5A8yjVcBOn3LxX+6q84bBUpICCDs=; b=saL2aja9cCd49KBFdQm5oJr81JnaGTC8U9CJj1hi0ZdZj+fhjdrPzlI5JkrZN/23layWMifmk/5tmn7yfYuGG4YilsImUy8c7yOw4qTVwKjtH5oHIWPh8QNnC+hDpi118wkqDo7HURa2lWEhrqty841RafMrN3Mb/5A24ha3UfdPUD8sZTBsvlNcco1fvF/CwxXCL3XlOig/nRbsM3OCOXayUAMd8LY5diio8D6w5MYlBsi6S6UfJx+T/795n68+DZJjXWV63jHuZC5rSw9zyKBCK3LTEf33I1pvV5n+/5KbJgvXNUcj1dF4ZYxRIeMFvVujVIBbqgU6LwedqFOvxQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tepy6-0005eh-Ny; Mon, 03 Feb 2025 01:30:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin. Resent-From: iyzsong@envs.net Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: liliana.prikler@gmail.com, maxim.cournoyer@gmail.com, vivien@planete-kraus.eu, guix-patches@gnu.org Resent-Date: Mon, 03 Feb 2025 06:30:02 +0000 Resent-Message-ID: <handler.76026.B.173856418121671@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 76026 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 76026@debbugs.gnu.org Cc: =?utf-8?b?5a6L5paH5q2m?= <iyzsong@member.fsf.org>, Liliana Marie Prikler <liliana.prikler@gmail.com>, Maxim Cournoyer <maxim.cournoyer@gmail.com>, Vivien Kraus <vivien@planete-kraus.eu> X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Liliana Marie Prikler <liliana.prikler@gmail.com>, Maxim Cournoyer <maxim.cournoyer@gmail.com>, Vivien Kraus <vivien@planete-kraus.eu> Received: via spool by submit@debbugs.gnu.org id=B.173856418121671 (code B ref -1); Mon, 03 Feb 2025 06:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Feb 2025 06:29:41 +0000 Received: from localhost ([127.0.0.1]:37397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1tepxl-0005dT-Bi for submit@debbugs.gnu.org; Mon, 03 Feb 2025 01:29:41 -0500 Received: from lists.gnu.org ([2001:470:142::17]:49734) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <iyzsong@envs.net>) id 1tepxi-0005dC-0o for submit@debbugs.gnu.org; Mon, 03 Feb 2025 01:29:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <iyzsong@envs.net>) id 1tepxc-0004n7-3U for guix-patches@gnu.org; Mon, 03 Feb 2025 01:29:32 -0500 Received: from mail.envs.net ([5.199.136.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <iyzsong@envs.net>) id 1tepxa-00041r-C7 for guix-patches@gnu.org; Mon, 03 Feb 2025 01:29:31 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 0C59038A3E69; Mon, 3 Feb 2025 06:29:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LGjvQ8Qh4KR5; Mon, 3 Feb 2025 06:29:15 +0000 (UTC) Received: from localhost (unknown [112.44.101.157]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Mon, 3 Feb 2025 06:29:15 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id cf1a2460; Mon, 3 Feb 2025 06:32:55 +0000 (UTC) Date: Mon, 3 Feb 2025 14:32:52 +0800 Message-ID: <804e33c6f779448024d40795f1f92eda5d5aa068.1738564364.git.iyzsong@member.fsf.org> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=5.199.136.28; envelope-from=iyzsong@envs.net; helo=mail.envs.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Reply-to: iyzsong@envs.net X-ACL-Warn: , iyzsong--- via Guix-patches <guix-patches@gnu.org> From: iyzsong--- via Guix-patches via <guix-patches@gnu.org> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
| Series |
[bug#76026] gnu: cogl: Disable gstreamer plugin.
|
|
Commit Message
vasilii.smirnov--- via Guix-patches" via
Feb. 3, 2025, 6:32 a.m. UTC
From: 宋文武 <iyzsong@member.fsf.org>
Fixes <https://issues.guix.gnu.org/39126>.
The cogl GStreamer sink has been broken:
<https://gitlab.gnome.org/Archive/cogl/-/issues/15>
* gnu/packages/gnome.scm (cogl)[inputs]: Remove gstreamer and
gst-plugins-base.
[arguments]: Pass "--enable-cogl-gst=no" to configure-flags.
Change-Id: I644da53effb52c6b6d8b1f9b6df293545fab963c
---
gnu/packages/gnome.scm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
base-commit: 12619742365b4bc138853ff7d79053e2089ffe1e
Comments
Hello! iyzsong@envs.net writes: > From: 宋文武 <iyzsong@member.fsf.org> > > Fixes <https://issues.guix.gnu.org/39126>. > > The cogl GStreamer sink has been broken: > <https://gitlab.gnome.org/Archive/cogl/-/issues/15> > > * gnu/packages/gnome.scm (cogl)[inputs]: Remove gstreamer and > gst-plugins-base. > [arguments]: Pass "--enable-cogl-gst=no" to configure-flags. Awesome, you are fixing a 5 years old bug :-). Nitpick, I'd used --8<---------------cut here---------------start------------->8--- Fixes: <https://issues.guix.gnu.org/39126> --8<---------------cut here---------------end--------------->8--- at the bottom of your git commit message, next to the Change-Id (these are git trailers, must be placed at the bottom of the git message, see 'man git-interpret-trailers'). > Change-Id: I644da53effb52c6b6d8b1f9b6df293545fab963c > --- > gnu/packages/gnome.scm | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 1225570c3c..1e8d813682 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -6308,12 +6308,10 @@ (define-public cogl > (list mesa > cairo > pango > - gstreamer > - gst-plugins-base > wayland)) > (arguments > `(#:disallowed-references (,xorg-server-for-tests) > - #:configure-flags (list "--enable-cogl-gst" > + #:configure-flags (list "--enable-cogl-gst=no" ;broken and unmaintained > "--enable-wayland-egl-platform" > "--enable-wayland-egl-server" That looks good to me, but reading https://blogs.gnome.org/clutter/2022/02/16/retiring-clutter/, it seems we should instead be removing cogl from the distribution, or at least never propagating it, in which case the above flag would become unnecessary. Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes: > Awesome, you are fixing a 5 years old bug :-). Nitpick, I'd used > > Fixes: <https://issues.guix.gnu.org/39126> Done, thank you! > [...] > That looks good to me, but reading > https://blogs.gnome.org/clutter/2022/02/16/retiring-clutter/, it seems > we should instead be removing cogl from the distribution, or at least > never propagating it, in which case the above flag would become > unnecessary. Yes, It's propagated and needed by clutter, which still required by 22 packages. GNOME propagated it by cheese, where cheese.pc does requires cluster. So I think remove the cogl gst plugin is right thing to do here.
Hi, 宋文武 <iyzsong@envs.net> writes: > Maxim Cournoyer <maxim.cournoyer@gmail.com> writes: > >> Awesome, you are fixing a 5 years old bug :-). Nitpick, I'd used >> >> Fixes: <https://issues.guix.gnu.org/39126> > > Done, thank you! > >> [...] >> That looks good to me, but reading >> https://blogs.gnome.org/clutter/2022/02/16/retiring-clutter/, it seems >> we should instead be removing cogl from the distribution, or at least >> never propagating it, in which case the above flag would become >> unnecessary. > > Yes, It's propagated and needed by clutter, which still required by 22 > packages. GNOME propagated it by cheese, where cheese.pc does requires > cluster. So I think remove the cogl gst plugin is right thing to do > here. cheese has been replaced by snapshot, so we should remove it from the gnome core applications [0] [0] https://gitlab.gnome.org/Teams/Releng/AppOrganization/-/issues/8#note_1820268
Hello,
Le mardi 04 février 2025 à 11:21 +0900, Maxim Cournoyer a écrit :
> cheese has been replaced by snapshot,
As far as I understand, snapshot is Rust, so I understand why we would
want to keep cheese around also.
Best regards,
Vivien
Hi, Vivien Kraus <vivien@planete-kraus.eu> writes: > Hello, > > Le mardi 04 février 2025 à 11:21 +0900, Maxim Cournoyer a écrit : >> cheese has been replaced by snapshot, > > As far as I understand, snapshot is Rust, so I understand why we would > want to keep cheese around also. GNOME already pulls librsvg, which is rust-written as well, so it's not that big of deal; especially since it can be conditionally added via (supported-package? snapshot). The bigger deal is getting it packaged :-).
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 1225570c3c..1e8d813682 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -6308,12 +6308,10 @@ (define-public cogl (list mesa cairo pango - gstreamer - gst-plugins-base wayland)) (arguments `(#:disallowed-references (,xorg-server-for-tests) - #:configure-flags (list "--enable-cogl-gst" + #:configure-flags (list "--enable-cogl-gst=no" ;broken and unmaintained "--enable-wayland-egl-platform" "--enable-wayland-egl-server"