[bug#75810,v5,02/14] daemon: Bind-mount /etc/nsswitch.conf & co. only if it exists.
Message ID | 7fa4cb05e23e14bb03832084fb60af1cbf727b39.1741973869.git.ludo@gnu.org |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 62A7827BBEA; Fri, 14 Mar 2025 17:50:47 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 9140127BBE9 for <patchwork@mira.cbaines.net>; Fri, 14 Mar 2025 17:50:46 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1tt9Ah-000560-Q5; Fri, 14 Mar 2025 13:50:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tt9Aa-00050o-L8 for guix-patches@gnu.org; Fri, 14 Mar 2025 13:50:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tt9Aa-00021n-1R for guix-patches@gnu.org; Fri, 14 Mar 2025 13:50:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=5fbggu8STjwEXFRRV3Gq/UXyTgxUmf6fh1UKO8gjNXs=; b=pDl/twze/Sz3HwgyPUZfaFStZbMgXfkZGNuUh+MG1Cl1W1pCdz2KIc9NRD8jW3IiIJmFQBCrSwqqat4l6rIrsoFQHUeLMH857kC03P3B9FGaGhJahFaHq/iLp7Uhz3tte2p6zym7Lwi3xIMm3rkH/lcVVROWgUzIQbAsR6kuO8KgZP6uFe//m3YOvBHUx2zreneIq3PH81DMbw28v0y7G7Wdtlw0qLQGAJ9JKKWR5Dxh9wFzotu9XO06Dkx6i/5kJEfORUUfVFoW5RU2NaQJMlaO1sLs5dkb54QvQCleVXNvnuvfM9PkEdn21fviKafq4DY7lgoLbyWCNxuX3Wx8bQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tt9AZ-0004R3-Ih for guix-patches@gnu.org; Fri, 14 Mar 2025 13:50:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#75810] [PATCH v5 02/14] daemon: Bind-mount /etc/nsswitch.conf & co. only if it exists. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Mar 2025 17:50:03 +0000 Resent-Message-ID: <handler.75810.B75810.174197459116955@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75810 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75810@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Received: via spool by 75810-submit@debbugs.gnu.org id=B75810.174197459116955 (code B ref 75810); Fri, 14 Mar 2025 17:50:03 +0000 Received: (at 75810) by debbugs.gnu.org; 14 Mar 2025 17:49:51 +0000 Received: from localhost ([127.0.0.1]:36005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1tt9AM-0004PO-Ro for submit@debbugs.gnu.org; Fri, 14 Mar 2025 13:49:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44260) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <ludo@gnu.org>) id 1tt9AG-0004OD-C4 for 75810@debbugs.gnu.org; Fri, 14 Mar 2025 13:49:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@gnu.org>) id 1tt9AA-0001xb-9Q; Fri, 14 Mar 2025 13:49:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=5fbggu8STjwEXFRRV3Gq/UXyTgxUmf6fh1UKO8gjNXs=; b=CDn6I66Ph4oSvPCNsgp9 zi/9luaoA7jeCiUsgsDktq5Qdpx/eoaRHvGpfOOo/bAhe1Milak0ab6FZKM8fYzkI6dTf0uPmkL7m n9qs3O+zCzEVJgZOZM9rp8l2xvmg1a+nFzLOVrzq5k6VXuq+ZrexfmlHsaJ8zMpsTFQrsqnIHgbUG xbPtYxr25HhVYPBIr7C3K3PabRMqEns1uRSu4MRhIkOZq1CgKOjcnjQ+SbPIzLsMZPSPNuoZd/sBZ V6GnoHplr3/5ZHv6i8NLwq/7csHcs7mqUFC1OigW9AUtTmkRLbRW9LoGy19tOlJ5+TjSHond+fsp4 spZMn6EPaln2lg==; From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Date: Fri, 14 Mar 2025 18:47:59 +0100 Message-ID: <7fa4cb05e23e14bb03832084fb60af1cbf727b39.1741973869.git.ludo@gnu.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <cover.1741973869.git.ludo@gnu.org> References: <cover.1741973869.git.ludo@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
Rootless guix-daemon
|
|
Commit Message
Ludovic Courtès
March 14, 2025, 5:47 p.m. UTC
Those files may be missing in some contexts, for instance within the build environment. * nix/libstore/build.cc (DerivationGoal::runChild): Add /etc/resolv.conf and related files to ‘ss’ only if they exist. Change-Id: Ie19664a86c8101a1dc82cf39ad4b7abb10f8250a --- nix/libstore/build.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc index edd01bab34..8ca5e5b732 100644 --- a/nix/libstore/build.cc +++ b/nix/libstore/build.cc @@ -2093,10 +2093,11 @@ void DerivationGoal::runChild() network, so give them access to /etc/resolv.conf and so on. */ if (fixedOutput) { - ss.push_back("/etc/resolv.conf"); - ss.push_back("/etc/nsswitch.conf"); - ss.push_back("/etc/services"); - ss.push_back("/etc/hosts"); + auto files = { "/etc/resolv.conf", "/etc/nsswitch.conf", + "/etc/services", "/etc/hosts" }; + for (auto & file: files) { + if (pathExists(file)) ss.push_back(file); + } } for (auto & i : ss) dirsInChroot[i] = i;