From patchwork Sat Nov 4 19:05:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruno Victal X-Patchwork-Id: 55937 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5CC1727BBEB; Sat, 4 Nov 2023 19:07:06 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1A46C27BBE2 for ; Sat, 4 Nov 2023 19:07:04 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzLyc-0001p9-A2; Sat, 04 Nov 2023 15:06:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzLyV-0001oU-BR for guix-patches@gnu.org; Sat, 04 Nov 2023 15:06:27 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzLyV-00062J-3f for guix-patches@gnu.org; Sat, 04 Nov 2023 15:06:27 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzLz5-0003cu-CG for guix-patches@gnu.org; Sat, 04 Nov 2023 15:07:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66935] [PATCH 1/4] services: dovecot: Use make-kill-destructor for action stop. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Nov 2023 19:07:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66935 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66935@debbugs.gnu.org Cc: Bruno Victal Received: via spool by 66935-submit@debbugs.gnu.org id=B66935.169912481513901 (code B ref 66935); Sat, 04 Nov 2023 19:07:03 +0000 Received: (at 66935) by debbugs.gnu.org; 4 Nov 2023 19:06:55 +0000 Received: from localhost ([127.0.0.1]:35744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzLyw-0003c3-Li for submit@debbugs.gnu.org; Sat, 04 Nov 2023 15:06:54 -0400 Received: from smtpmciv3.myservices.hosting ([185.26.107.239]:56032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzLyt-0003bL-SA for 66935@debbugs.gnu.org; Sat, 04 Nov 2023 15:06:52 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpmciv3.myservices.hosting (Postfix) with ESMTP id 6DCCE2103C for <66935@debbugs.gnu.org>; Sat, 4 Nov 2023 20:06:09 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id C659780092; Sat, 4 Nov 2023 20:06:08 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1Td6tEynIme0; Sat, 4 Nov 2023 20:06:08 +0100 (CET) Received: from guix-nuc.home.arpa (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id D15228005B; Sat, 4 Nov 2023 20:06:07 +0100 (CET) From: Bruno Victal Date: Sat, 4 Nov 2023 19:05:58 +0000 Message-ID: <795f0efdf6ad1716a9d3b98589a790855f88391d.1699124200.git.mirai@makinata.eu> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/services/mail.scm (dovecot-shepherd-service): Prefer file-append over string-append. Prefer shepherd mechanism for issuing stop action. Change-Id: I6a23fbb70ee4e0a2ba5f8e933e85b97283736f5d --- gnu/services/mail.scm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gnu/services/mail.scm b/gnu/services/mail.scm index 12dcc8e71d..b865a67630 100644 --- a/gnu/services/mail.scm +++ b/gnu/services/mail.scm @@ -1580,12 +1580,9 @@ (define (dovecot-shepherd-service config) (provision '(dovecot)) (requirement '(pam networking)) (start #~(make-forkexec-constructor - (list (string-append #$dovecot "/sbin/dovecot") + (list #$(file-append dovecot "/sbin/dovecot") "-F"))) - (stop #~(lambda _ - (invoke #$(file-append dovecot "/sbin/dovecot") - "stop") - #f)))))) + (stop #~(make-kill-destructor)))))) (define %dovecot-pam-services (list (unix-pam-service "dovecot")))